From patchwork Wed Feb 17 20:20:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 383917 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp3146524jao; Wed, 17 Feb 2021 13:25:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxt+RZsFLAQ4RL26T+gb3FbYPLUe3ZH1unszmA6DhMXgbuGAlAn+O/GsLUaJ4YyQ04UWj4g X-Received: by 2002:a25:7645:: with SMTP id r66mr2003015ybc.331.1613597133879; Wed, 17 Feb 2021 13:25:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613597133; cv=none; d=google.com; s=arc-20160816; b=wjq5/llElUGDXckopMIcgk9lEutXJBF/3MNTVqoHZ16m/OlqIdReAaYh4tLKbgB8Qe 00/w+JRwENwIaKIYmFlD8T1BoY/lleJ5AAh5dQATnJMm/nswCFhfmbwiBcRQ7PDNquMy DeL+hX0QJDKWl0I7kqossBBr3kuF5kK6P2QJPIcx7ZiJWawU1VV4SIkEp96VXbqpZQkp Z4atFjK/Kv9zrSlGeMLr8ggtY4b4NO4MaxlFDHvdNP56YdKVD5s7BfUSRgnU6tDxAqMo MuSuEsaoip/v/KMWVKBZi2g+tWwPJ6WwOoUCv7Pi+sJ9bcYZrc/VdMFCA79AOChw1AM/ Sjrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=9jHEmEI6EV8qZCeh+tCL5YyTrUMsHZff/il96+nDzSE=; b=lcqpoal8TP0G/H24S31GwdoX8SXTbGf5uN3PvDfYgIK0TzWjx8tc/vccOyXFG1KCS7 Vz/y4USBrIkwNZLZ29pqcxMbl+gnJf6ZRRYSObKP0JuxxBjacv3m39MKmZoLaW1ppJOG stEkbSXnWctDH+pHz6Cer5Y4Ou24JzvxijlYmrd09WU45yKTF0Q+rTI7jpQmM5gzPoNg p8XFOH+MirlneLXiPRCbudJsKyYHXFBJwYIMYytsaGAC7zpmEv8aYKWRYign+E4vQDid r/OtJ2CNqUgTvCOmHCVoSWvdWi2OrBnV4mu9qbIMhN9V04fNzGQHHTgFvVi1YiBYusJw f8tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Ax5oSPO3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x63si3572671ybc.14.2021.02.17.13.25.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Feb 2021 13:25:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Ax5oSPO3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCUKD-0000bH-AW for patch@linaro.org; Wed, 17 Feb 2021 16:25:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTMw-0001xV-Rf for qemu-devel@nongnu.org; Wed, 17 Feb 2021 15:24:20 -0500 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:45332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCTMt-0007l4-Oc for qemu-devel@nongnu.org; Wed, 17 Feb 2021 15:24:18 -0500 Received: by mail-pg1-x534.google.com with SMTP id p21so3554862pgl.12 for ; Wed, 17 Feb 2021 12:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9jHEmEI6EV8qZCeh+tCL5YyTrUMsHZff/il96+nDzSE=; b=Ax5oSPO3tlNDJuwVAlJIC9uJJIMl8CM9iVvH67ONoL6K4y9iKMdgRO86SDY3tEr5Jh O+QYvUYgmdBQG8nYI5wHrUr/vf6vdCShHLWkojEVNaG6u3onXaZguPgxeURuftyCkUxG v+OJvrytnueJoT9BeqQhYYIADTg8JVkCNNo/3QWxYYID9ef+ZqV6EtPli0B8CcdhtdP5 6tsX3wVC3xuKIwkBJc4r71T4mEOx42oCCWLVQg4RN7RTVXlpszFaI17x6rHIN7cg9beO 4pL3lmq3YdT+vxC5AlYE9Dt+eDUU19t/3klyCX/ygGDVxgEwIeBZHM1CYjIwy0DKBHHi PoAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9jHEmEI6EV8qZCeh+tCL5YyTrUMsHZff/il96+nDzSE=; b=QgNeYzaFKPBg6srNSPuSUzoPitsXppjs8NmZILA9vUC6ASwzDWkB3cBrhKAMdc5jVA SWjNdnl96QQNgN0zpg2XQ+tBj82Fb9wRsKMKuRxzT0Wctvcg8+DN7CqeOZ2i+3hoj1iJ ORljoP+WjpszUdzSU19b0wB0bnoobp4cRz+J91pqC9wI1aqBhE17iLyR1uxCvGY7q6Am ggA0dC4CUXaiMwKARCpGeJKR/jcqtaupPME3MV0BZit/VbGEdhsgmFoJfzJOG6L2TAPZ Qi9ak2n1jk07ZTs6gPvMOdUZVQlQSPCL4ghWDusVcm5x4fd/GL9CgWctdbLoyBmdUnoH 28UQ== X-Gm-Message-State: AOAM532dXv6G7v3SNBZt2lwbf0phfdyF2yoHSKFYewHQiylkJ/M5TDJy ZdlrLFEvaqyyLakUl4fcDoVVaKLA8G6FRA== X-Received: by 2002:a63:3c4e:: with SMTP id i14mr948682pgn.266.1613593454587; Wed, 17 Feb 2021 12:24:14 -0800 (PST) Received: from localhost.localdomain (047-051-160-125.biz.spectrum.com. [47.51.160.125]) by smtp.gmail.com with ESMTPSA id v126sm3232038pfv.163.2021.02.17.12.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 12:24:13 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 62/71] tcg/tci: Implement goto_ptr Date: Wed, 17 Feb 2021 12:20:27 -0800 Message-Id: <20210217202036.1724901-63-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210217202036.1724901-1-richard.henderson@linaro.org> References: <20210217202036.1724901-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, alex.bennee@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This operation is critical to staying within the interpretation loop longer, which avoids the overhead of setup and teardown for many TBs. The check in tcg_prologue_init is disabled because TCI does want to use NULL to indicate exit, as opposed to branching to a real epilogue. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target-con-set.h | 1 + tcg/tci/tcg-target.h | 2 +- tcg/tcg.c | 2 ++ tcg/tci.c | 19 +++++++++++++++++++ tcg/tci/tcg-target.c.inc | 16 ++++++++++++++++ 5 files changed, 39 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/tcg/tci/tcg-target-con-set.h b/tcg/tci/tcg-target-con-set.h index 316730f32c..ae2dc3b844 100644 --- a/tcg/tci/tcg-target-con-set.h +++ b/tcg/tci/tcg-target-con-set.h @@ -9,6 +9,7 @@ * Each operand should be a sequence of constraint letters as defined by * tcg-target-con-str.h; the constraint combination is inclusive or. */ +C_O0_I1(r) C_O0_I2(r, r) C_O0_I3(r, r, r) C_O0_I4(r, r, r, r) diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h index d953f2ead3..17911d3297 100644 --- a/tcg/tci/tcg-target.h +++ b/tcg/tci/tcg-target.h @@ -86,7 +86,7 @@ #define TCG_TARGET_HAS_muls2_i32 0 #define TCG_TARGET_HAS_muluh_i32 0 #define TCG_TARGET_HAS_mulsh_i32 0 -#define TCG_TARGET_HAS_goto_ptr 0 +#define TCG_TARGET_HAS_goto_ptr 1 #define TCG_TARGET_HAS_direct_jump 0 #define TCG_TARGET_HAS_qemu_st8_i32 0 diff --git a/tcg/tcg.c b/tcg/tcg.c index 92aec0d238..ce80adcfbe 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1314,10 +1314,12 @@ void tcg_prologue_init(TCGContext *s) } #endif +#ifndef CONFIG_TCG_INTERPRETER /* Assert that goto_ptr is implemented completely. */ if (TCG_TARGET_HAS_goto_ptr) { tcg_debug_assert(tcg_code_gen_epilogue != NULL); } +#endif } void tcg_func_start(TCGContext *s) diff --git a/tcg/tci.c b/tcg/tci.c index 76bbf440a8..c229050c66 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -69,6 +69,11 @@ static void tci_args_l(uint32_t insn, const void *tb_ptr, void **l0) *l0 = diff ? (void *)tb_ptr + diff : NULL; } +static void tci_args_r(uint32_t insn, TCGReg *r0) +{ + *r0 = extract32(insn, 8, 4); +} + static void tci_args_nl(uint32_t insn, const void *tb_ptr, uint8_t *n0, void **l1) { @@ -738,6 +743,15 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, tb_ptr = *(void **)ptr; break; + case INDEX_op_goto_ptr: + tci_args_r(insn, &r0); + ptr = (void *)regs[r0]; + if (!ptr) { + return 0; + } + tb_ptr = ptr; + break; + case INDEX_op_qemu_ld_i32: if (TARGET_LONG_BITS <= TCG_TARGET_REG_BITS) { tci_args_rrm(insn, &r0, &r1, &oi); @@ -995,6 +1009,11 @@ int print_insn_tci(bfd_vma addr, disassemble_info *info) info->fprintf_func(info->stream, "%-12s %p", op_name, ptr); break; + case INDEX_op_goto_ptr: + tci_args_r(insn, &r0); + info->fprintf_func(info->stream, "%-12s %s", op_name, str_r(r0)); + break; + case INDEX_op_call: tci_args_nl(insn, tb_ptr, &len, &ptr); info->fprintf_func(info->stream, "%-12s %d,%p", op_name, len, ptr); diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 0df8384be7..db29bc6e54 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -27,6 +27,9 @@ static TCGConstraintSetIndex tcg_target_op_def(TCGOpcode op) { switch (op) { + case INDEX_op_goto_ptr: + return C_O0_I1(r); + case INDEX_op_ld8u_i32: case INDEX_op_ld8s_i32: case INDEX_op_ld16u_i32: @@ -263,6 +266,15 @@ static void tcg_out_op_p(TCGContext *s, TCGOpcode op, void *p0) tcg_out32(s, insn); } +static void tcg_out_op_r(TCGContext *s, TCGOpcode op, TCGReg r0) +{ + tcg_insn_unit insn = 0; + + insn = deposit32(insn, 0, 8, op); + insn = deposit32(insn, 8, 4, r0); + tcg_out32(s, insn); +} + static void tcg_out_op_v(TCGContext *s, TCGOpcode op) { tcg_out32(s, (uint8_t)op); @@ -567,6 +579,10 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args, set_jmp_reset_offset(s, args[0]); break; + case INDEX_op_goto_ptr: + tcg_out_op_r(s, opc, args[0]); + break; + case INDEX_op_br: tcg_out_op_l(s, opc, arg_label(args[0])); break;