From patchwork Wed Feb 17 20:19:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 383866 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp3119451jao; Wed, 17 Feb 2021 12:39:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9wmXdzrEUrdjxyfyLcAgpGUDb4vDmXvNAZ68nyhIlPLxmihaSO1NQqhBIuI5KRRspK1FE X-Received: by 2002:a25:244c:: with SMTP id k73mr1726596ybk.368.1613594362617; Wed, 17 Feb 2021 12:39:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613594362; cv=none; d=google.com; s=arc-20160816; b=XDUdOjbK/NrUZVri5BX6pjEoLcvbQspA6gwCHMbVHtLv47hMI/q9IsjLHQgEkHo/dk erNEjIwuoP0VhmcQz4+x84hjWQQQj/dCttANyZl0BlQTNZRVmAkAI2IFOG4LSDhde6DU IsN94oamdyI18K+FmYxkuTo7a/oOBqnlbJY2moRXxbj73hTrPizZlaG0q+c1oqUfS/re lGvBcBqJvFcTlSzmW48zOMVSeeQEWXDDvu5YY4+se6A5nZSqnfMD02cfIgjzny5YtEYh TXK/8OMkk2KiGzgpM76ctCkLXhSag3YqoQ/Wq/l4Dbnc2kFQf4rj66RNY055+PI/sYvJ PbYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Eg77pQQlLC4zBnjShq/Ox8hKnBoPA3tCVlP/vVaohvk=; b=rK+pZ+7EBrXFYNAULy6BWGPSWmxaHE+RdAPkCPprB6i7pNVrcFRokXY34jgUkN8GjH 9MadrDXPkHupYG+dCrLSiRWXrvaUYninJeALigfF5PP92Mhi77WdJRhPxAHyuAfMRsQX x400/viSNOTZDNQLSn4zz09WMvEEYoYNRQ/FFkEhF3/fItLjscQLA9oWfNZfchz1b87C Lj/uW4+JL/3QARjnF0hb4P637dvd1daBJbvRN3iEdziIbXtN0YXeQol886jmZKGeYnep LAzjrCLBtZIKnAMMBp8u7xGsOBS24oar3ZDg/IawxiHni7tVoCLJ2Ux9PM4ZwVnw6oC5 yIeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=In9u7mHM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v1si2957292ybo.42.2021.02.17.12.39.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Feb 2021 12:39:22 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=In9u7mHM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCTbW-00071R-34 for patch@linaro.org; Wed, 17 Feb 2021 15:39:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTKw-000785-DB for qemu-devel@nongnu.org; Wed, 17 Feb 2021 15:22:14 -0500 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:42713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCTKu-00079h-JX for qemu-devel@nongnu.org; Wed, 17 Feb 2021 15:22:14 -0500 Received: by mail-pg1-x529.google.com with SMTP id o38so9191486pgm.9 for ; Wed, 17 Feb 2021 12:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Eg77pQQlLC4zBnjShq/Ox8hKnBoPA3tCVlP/vVaohvk=; b=In9u7mHMyXe2EG6Fs88jIzDoIewGtcK4znuZW0Npwa5nUgTSut/SraMvIQbUGKXwjS M46sixawv8hymftWDP/9Ii+LkV4tH1hGbhrWeh+RKPlNKYu3uAOGfMxNXAmK0Mv7bUOa +c4B1Xx0OOive2v04RAVbJSthX40ZqvqlhxbuIMHRrQ10dxgIS0zmWFtCicK2M3+cM8F Kqw4vILGuNLoOcDcALo3r/iMylJuWp7ru+XPlJqy32uqcF1KFN5uWGCJopv5KdsgmC8H IJzdG8JvT1R5LAYa5lP2nC92HHuPirnhZMOkvfZrStaAVvFMXe7ntBKUXzNFzZ874W1Y uDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Eg77pQQlLC4zBnjShq/Ox8hKnBoPA3tCVlP/vVaohvk=; b=UfVBcupHNw93AejKIGaZc2KQqbHr3jl+Pfq/VwUZcXEyZiK2naHRlyvdxU6mNjZQ9s Z6BnbPIKs8uapsynQt0xeP4e3b9631erAhuWRZ+FwPQg4ZWoG3qKnXCh8AprIAGCQ+7u unpOfIcBpaKdaoLzQo6yDYLcMeNqUeELI0rNA5I+xQZriFyQSR2z6anVTacU3Tqj6zZB E2TPVoDHVSN0n/FMRbHB63NPW4o0OGK7JspcX61Z+EPgo4vT4wLXjUQnfF9/LrDer/tu KBer8KXEOzUllSKdWsmyOdwnyYY1ZuiPOhKTLOp1fIp0C8dxEHoJXeHq9udoIoFG5LYo ZjmQ== X-Gm-Message-State: AOAM532ksrfpoOF4adzQ0n2M6HpRRqX9hD26Ar8D2I6BbDnC6ixgQ9zq pNJHw2/dHBuZ8X4Zjs67wwm0xA31sRaIlw== X-Received: by 2002:a63:5f11:: with SMTP id t17mr946817pgb.391.1613593331356; Wed, 17 Feb 2021 12:22:11 -0800 (PST) Received: from localhost.localdomain (047-051-160-125.biz.spectrum.com. [47.51.160.125]) by smtp.gmail.com with ESMTPSA id 3sm3001576pjk.26.2021.02.17.12.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 12:22:10 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 10/71] tcg/tci: Remove tci_read_r32s Date: Wed, 17 Feb 2021 12:19:35 -0800 Message-Id: <20210217202036.1724901-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210217202036.1724901-1-richard.henderson@linaro.org> References: <20210217202036.1724901-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, alex.bennee@linaro.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use explicit casts for ext32s opcodes. Signed-off-by: Richard Henderson --- tcg/tci.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) -- 2.25.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/tcg/tci.c b/tcg/tci.c index a5aaa763f8..cef12f263d 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -57,13 +57,6 @@ static tcg_target_ulong tci_read_reg(const tcg_target_ulong *regs, TCGReg index) return regs[index]; } -#if TCG_TARGET_REG_BITS == 64 -static int32_t tci_read_reg32s(const tcg_target_ulong *regs, TCGReg index) -{ - return (int32_t)tci_read_reg(regs, index); -} -#endif - #if TCG_TARGET_REG_BITS == 64 static uint64_t tci_read_reg64(const tcg_target_ulong *regs, TCGReg index) { @@ -149,15 +142,6 @@ static uint64_t tci_read_r64(const tcg_target_ulong *regs, return tci_uint64(tci_read_r(regs, tb_ptr), low); } #elif TCG_TARGET_REG_BITS == 64 -/* Read indexed register (32 bit signed) from bytecode. */ -static int32_t tci_read_r32s(const tcg_target_ulong *regs, - const uint8_t **tb_ptr) -{ - int32_t value = tci_read_reg32s(regs, **tb_ptr); - *tb_ptr += 1; - return value; -} - /* Read indexed register (64 bit) from bytecode. */ static uint64_t tci_read_r64(const tcg_target_ulong *regs, const uint8_t **tb_ptr) @@ -870,8 +854,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, #endif case INDEX_op_ext_i32_i64: t0 = *tb_ptr++; - t1 = tci_read_r32s(regs, &tb_ptr); - tci_write_reg(regs, t0, t1); + t1 = tci_read_r(regs, &tb_ptr); + tci_write_reg(regs, t0, (int32_t)t1); break; #if TCG_TARGET_HAS_ext32u_i64 case INDEX_op_ext32u_i64: