From patchwork Mon Feb 8 02:37:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 378483 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp4330021jah; Sun, 7 Feb 2021 19:24:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFu/sx3RdFYPgT5kDW6+j45PtePtXJ+rboG2S12BN78wM/Kb3isU+Ob3wM+mOvtdSIsW6J X-Received: by 2002:a25:ada2:: with SMTP id z34mr23338546ybi.165.1612754684892; Sun, 07 Feb 2021 19:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612754684; cv=none; d=google.com; s=arc-20160816; b=SYc/IkGFjdAM+vIkXmTQPC2IqBjvryG2FBab8et/NcH9tFUDvVUTKMLoQWNsse9Faw tVSpdA04fKIOra2Fn8DTFLbodMamUyvVgQQ+1K8b7N+84HFwe3KACA44c61gvDwOht8s C+76j3EtnLbHkJuhy5F6JvcJ3lpUSwjFI+e0iPXl/SbvL5E2yXjk56+FvTH3IholWKf1 i+geL1INUuP3tZqMNePK3pkP+zzbPA40UbOBVefYKMGPVs0r8C6Ke/DxWfrA/sD4GaSx uw2r1Gy6/duacnMf3Qx06E4ptyMIx6SgE7ZORwhqko+Uk8jLtoyOEnNbS4A6L1iIqQ1y DZVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Kpfe6JZmwXM15Cw7O9Ulgnnkm0DVoqv1s4+DGCwKajc=; b=UXeLVb0nIii41oL3Jh4bpsMKj4CW9d1ynNZ0VtwJOHJC5vwhnrWewrBSk+MNsHCn3b DBjNpaJ4wvGIKbH2/jx9/EZbfdOiDocyq1y4IC7QDCIopvi9Ss6lklhFeSql2lYQF0Bj pjgU64Y6L/ERzfGb84kETLmfzbqm4CE5CSNmj7n2a3dKIFArflcrvQCm2ttONiuQf9mv KT/Eag8oWHi5R5TkG4HLH7moPUztmTm0j8mQN4aGVwB5JYXj/Yu5L6vAO5KhFJNyGkPk pusS3qn61qUf7YkBDTXKODGOyiE/z2/G8iZQO1ELWVd9GA5yxs/0c1238nFHpo2rHF6K W3nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CHCg94PK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j133si15675815ybb.145.2021.02.07.19.24.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Feb 2021 19:24:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CHCg94PK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8xAK-0004Bv-DF for patch@linaro.org; Sun, 07 Feb 2021 22:24:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8wSS-0002Tl-5S for qemu-devel@nongnu.org; Sun, 07 Feb 2021 21:39:24 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:36484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8wSQ-00067h-77 for qemu-devel@nongnu.org; Sun, 07 Feb 2021 21:39:23 -0500 Received: by mail-pj1-x1035.google.com with SMTP id gx20so7943040pjb.1 for ; Sun, 07 Feb 2021 18:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kpfe6JZmwXM15Cw7O9Ulgnnkm0DVoqv1s4+DGCwKajc=; b=CHCg94PKYsAHOhHjvVNKvl9AEgIOuie4U17Vx2j1Q0mXW+daJtzBHL870wV52I/1Jk wP7qGCipx7ORUnIfFMz01mJAX7qTqWSRcAHYFSauUxUyyMWXm8+BGOOLoVjCtKcNs3W1 y1rMhh/Z/tYpsdV3cbfeXG/hB8jynlm79B0gXRfIzatk/VSUjbPCbZRljz7JrhenC4ja v8TNSyAEez60lpQVyUfQ4kIT7zFhzOEt0Xnr5o5Mb+gL2yWSIJBYPTbUX0qI3MU//9EY PUCtKq3AWsGmP5UF+LsD68eN0BEWayRy0MMt0TGtxr/qe2eJ+dU07dxdhn3kHQZI7jVU /lVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kpfe6JZmwXM15Cw7O9Ulgnnkm0DVoqv1s4+DGCwKajc=; b=A9Q7OAl6JPzTNIrnY8FKHCfEVYnbx+E/AfQKNN/P3roYg9DSIQohcT6RMfLKwYr1kM XdxpBL/Ku3rYNQ4aA6bAHrs2T6QfayI/5wamXUUpWfHfXQrb8uIfVxPMHgZF3+dsGJGY 5WedijyAlDU09gUOdXe+zFWOxpRHGIktQY0WarxP8J0SNqAfR/QmBeHMPaloQpZoAf1K 2DxvR2lqiqAoADiiPJLWZB6G8f/B3OQA/hKQSnUC4nosC6BkAKqAF9U8evBsoI4DoN87 x81ZposmJwlzVZDMgBo7Wz5YGHos1XCM1k0zBZiBcgej3G+fDdvtufR0rEZhMjNYNUzE P2uQ== X-Gm-Message-State: AOAM530SpMsepchMUp8Y/6rYt1BZ2unb0T20pNP87OuleXVu1KR6cnSD SdSHTcsKuWGK+u/lKXtgpeJSOHxLPNGRUg== X-Received: by 2002:a17:902:724c:b029:e2:d560:30b6 with SMTP id c12-20020a170902724cb02900e2d56030b6mr3497583pll.60.1612751959257; Sun, 07 Feb 2021 18:39:19 -0800 (PST) Received: from localhost.localdomain (174-21-150-71.tukw.qwest.net. [174.21.150.71]) by smtp.gmail.com with ESMTPSA id 74sm650954pfw.53.2021.02.07.18.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 18:39:18 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 45/70] tcg/tci: Split out tcg_out_op_rr Date: Sun, 7 Feb 2021 18:37:27 -0800 Message-Id: <20210208023752.270606-46-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210208023752.270606-1-richard.henderson@linaro.org> References: <20210208023752.270606-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" At the same time, validate the type argument in tcg_out_mov. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 36 +++++++++++++++++++++++------------- 1 file changed, 23 insertions(+), 13 deletions(-) -- 2.25.1 diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index cb0cbbb8da..272e3ca70b 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -303,6 +303,17 @@ static void tcg_out_op_p(TCGContext *s, TCGOpcode op, void *p0) old_code_ptr[1] = s->code_ptr - old_code_ptr; } +static void tcg_out_op_rr(TCGContext *s, TCGOpcode op, TCGReg r0, TCGReg r1) +{ + uint8_t *old_code_ptr = s->code_ptr; + + tcg_out_op_t(s, op); + tcg_out_r(s, r0); + tcg_out_r(s, r1); + + old_code_ptr[1] = s->code_ptr - old_code_ptr; +} + static void tcg_out_op_rrs(TCGContext *s, TCGOpcode op, TCGReg r0, TCGReg r1, intptr_t i2) { @@ -337,16 +348,18 @@ static void tcg_out_ld(TCGContext *s, TCGType type, TCGReg val, TCGReg base, static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg) { - uint8_t *old_code_ptr = s->code_ptr; - tcg_debug_assert(ret != arg); -#if TCG_TARGET_REG_BITS == 32 - tcg_out_op_t(s, INDEX_op_mov_i32); -#else - tcg_out_op_t(s, INDEX_op_mov_i64); + switch (type) { + case TCG_TYPE_I32: + tcg_out_op_rr(s, INDEX_op_mov_i32, ret, arg); + break; +#if TCG_TARGET_REG_BITS == 64 + case TCG_TYPE_I64: + tcg_out_op_rr(s, INDEX_op_mov_i64, ret, arg); + break; #endif - tcg_out_r(s, ret); - tcg_out_r(s, arg); - old_code_ptr[1] = s->code_ptr - old_code_ptr; + default: + g_assert_not_reached(); + } return true; } @@ -534,10 +547,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args, CASE_32_64(bswap16) /* Optional (TCG_TARGET_HAS_bswap16_*). */ CASE_32_64(bswap32) /* Optional (TCG_TARGET_HAS_bswap32_*). */ CASE_64(bswap64) /* Optional (TCG_TARGET_HAS_bswap64_i64). */ - tcg_out_op_t(s, opc); - tcg_out_r(s, args[0]); - tcg_out_r(s, args[1]); - old_code_ptr[1] = s->code_ptr - old_code_ptr; + tcg_out_op_rr(s, opc, args[0], args[1]); break; #if TCG_TARGET_REG_BITS == 32