From patchwork Mon Feb 8 02:36:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 378432 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp4310120jah; Sun, 7 Feb 2021 18:44:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF+1j/IbLXotmgXXWrd9t0nLAIkHP7Xxmehck0UmmVnyoC/bgeOb6XLLuViw6tE/PB5IEB X-Received: by 2002:a25:83d0:: with SMTP id v16mr24423805ybm.40.1612752250167; Sun, 07 Feb 2021 18:44:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612752250; cv=none; d=google.com; s=arc-20160816; b=VyH0LVGoHvGplqu4BVYVdBIU+as5t0H4e+VC/tHkqQf8ZETY4WNIAvWwtKJ9mAka7r bkWSkxR7fmhjOvOFvcvjSydIocn0BCynH8vzOnc3YHb/vVgffJwAcBDZCVdaYZwNMXV9 dTYDAmfmzD2vibD/sDjmpfvzFmJQdgicjHrsRwqSMV82x0e0DL9OzgxV2NCiFFJNzgHd LuIOsZJfTF5EFo9oUtug2LiYfaUHXvkAr7RKdeR0x2bD2CZVH54+StnevQB6e8tplfN6 uSbjRXWW1U7KslGEkRgZHh0AeCe6Uh3CrVNv09v8vRjbqU+UdvJbsF8cMSRnRc8yUsL0 7LAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=pQkCV4u5j7YzXqXH4gWdLH4wSzT0D2ZHh4b1vkvHPmsd8K81o2Xs57wofXVLgq/id6 Mvl/ovbVCBmkVn0w4WzEqs/NxBGQzHOR0GhKjGxw0d9vcFrpVjbWuQcHhNrKdt3nsgH0 GBW9Qb/LLpEIsVTNoVTTutFJISDR0AFgFflgpg5ItRxt5F7U6W18mKiRvel3RuV+68lB IuoWhqye/Ziy0xA6ZqFdAZD42fLSB12QrLq2fA0ZhkQL1a8RzknFYhLr828Gufd5o6NS B/mjTx4198S0S1pdEG5JGAOe+5TUUayQVXpKy1aAVES/CFFbrmq1y34HX5oAPB18gzZ0 SrAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cAi50Qf8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b71si14726640yba.35.2021.02.07.18.44.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Feb 2021 18:44:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cAi50Qf8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8wX3-0008Mp-Kv for patch@linaro.org; Sun, 07 Feb 2021 21:44:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8wRG-0001Fp-Lx for qemu-devel@nongnu.org; Sun, 07 Feb 2021 21:38:10 -0500 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:40500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8wRE-0005jm-99 for qemu-devel@nongnu.org; Sun, 07 Feb 2021 21:38:10 -0500 Received: by mail-pf1-x42d.google.com with SMTP id u143so2536472pfc.7 for ; Sun, 07 Feb 2021 18:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=cAi50Qf84e7nSx599Ea0JBKI7RNk32ZqRh46M7ZyXA3wqsmCFgu7W+s4EQ5/9j3chI 650fY7eVAD0G2dYn9grBVIezjjJj7NroZCgYsnuoqBnlywodg6d67omJZ72dxtAKTPTa jL0fjCd5T/JzTMqE63NIbYu/RgWvr39Ui1zeQMX/V2kLb/hzJMh0OTgB2l6MRM1fIJqf DiuPVn47BRGnbld4ryLFImaLR5y2Af+268fcC3+RpukIoZ4cBg0FiT3wpjl7Oviplepy bzyqH/u1Yz2r+8F34T/HY76VUEB5qOOlb9F7k+rROL6FA9LF6vAbZW/KwG2NiTmLqTdh O88w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=T1vPfNVqfPN6E2YSVLB+PA2sezVxHiGRfDBN2zJ8oy4EIkjMMsXn9hkpzxwcDynd0Q njIKXFH5D3D3J0vslukbbtfjYXXdkdrAoTTdRjRBH8tY3lAs6twYiVova5vb0Wql8x7b vgkUCg9b1QlBCNctpKVBhWFKj8mOz2NJNayswQkAO/HXJINIYf9p+VsHBqWd+lGq5kA3 0HbCpyxwKfQX1ZDcjBd8xC0oxz51kp/H2UpmW8LchhOP1WouMLdqoxUJzbRGBohBEJjr Ewotqc6JFWIcsySSTjEaGjSYVxVKo1yiPfuBWbuLvFhqw3XkpnFMrS2O9m18h6mzfQqV /X8Q== X-Gm-Message-State: AOAM532tFn8Gr2WxllQm41os894/wlNrA5JjYDPufYKgZ7DL7Mucn8NB eOCQUkjvAGdOdxXvi+kVnmM91Fti8eat3g== X-Received: by 2002:a63:1f21:: with SMTP id f33mr15477808pgf.31.1612751887028; Sun, 07 Feb 2021 18:38:07 -0800 (PST) Received: from localhost.localdomain (174-21-150-71.tukw.qwest.net. [174.21.150.71]) by smtp.gmail.com with ESMTPSA id j17sm16158689pfh.183.2021.02.07.18.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 18:38:06 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 10/70] tcg/tci: Remove tci_read_r32s Date: Sun, 7 Feb 2021 18:36:52 -0800 Message-Id: <20210208023752.270606-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210208023752.270606-1-richard.henderson@linaro.org> References: <20210208023752.270606-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use explicit casts for ext32s opcodes. Signed-off-by: Richard Henderson --- tcg/tci.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) -- 2.25.1 diff --git a/tcg/tci.c b/tcg/tci.c index 72ec63e18e..9c8395397a 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -57,13 +57,6 @@ static tcg_target_ulong tci_read_reg(const tcg_target_ulong *regs, TCGReg index) return regs[index]; } -#if TCG_TARGET_REG_BITS == 64 -static int32_t tci_read_reg32s(const tcg_target_ulong *regs, TCGReg index) -{ - return (int32_t)tci_read_reg(regs, index); -} -#endif - #if TCG_TARGET_REG_BITS == 64 static uint64_t tci_read_reg64(const tcg_target_ulong *regs, TCGReg index) { @@ -149,15 +142,6 @@ static uint64_t tci_read_r64(const tcg_target_ulong *regs, return tci_uint64(tci_read_r(regs, tb_ptr), low); } #elif TCG_TARGET_REG_BITS == 64 -/* Read indexed register (32 bit signed) from bytecode. */ -static int32_t tci_read_r32s(const tcg_target_ulong *regs, - const uint8_t **tb_ptr) -{ - int32_t value = tci_read_reg32s(regs, **tb_ptr); - *tb_ptr += 1; - return value; -} - /* Read indexed register (64 bit) from bytecode. */ static uint64_t tci_read_r64(const tcg_target_ulong *regs, const uint8_t **tb_ptr) @@ -887,8 +871,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, #endif case INDEX_op_ext_i32_i64: t0 = *tb_ptr++; - t1 = tci_read_r32s(regs, &tb_ptr); - tci_write_reg(regs, t0, t1); + t1 = tci_read_r(regs, &tb_ptr); + tci_write_reg(regs, t0, (int32_t)t1); break; #if TCG_TARGET_HAS_ext32u_i64 case INDEX_op_ext32u_i64: