From patchwork Fri Feb 5 22:56:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 376988 Delivered-To: patch@linaro.org Received: by 2002:a17:906:48d2:0:0:0:0 with SMTP id d18csp2575444ejt; Fri, 5 Feb 2021 15:02:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOoSXyM+ZKl/UpJiHJkctLtD7A+R5G2Af9tPuEHqk3Icfd0aEJPZxKlgRJrfMo0qb1JiLV X-Received: by 2002:a25:5583:: with SMTP id j125mr8739350ybb.307.1612566174696; Fri, 05 Feb 2021 15:02:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612566174; cv=none; d=google.com; s=arc-20160816; b=GDuunCwcpsun1nUpbA1UpaRT0n1MXVkx9U0LXts7SzTPEcLOU4nU9uYfH4tyCRp2H1 VORhPl2ifuiBYgQvUio+G7Tq2pwLQcaLL/Qdeg5TqQZvgnjjGQXt4ksc1rtFFTk2Ouzq NiBuyfONJ4ETInj/wzkEJursyBbOglX1paYpvc/PISeTmThnFkVyuCA1QAuZazJQXHgt vWKpJLoeuRztuo3BCGl867xCMV9MdPXuXSmzT6eB4QTf9MchTWm+Ur/DHUgv0CDiM3nK QRAdAasg5b1sPDFs3nQ4GFH57Limc2rkixqRusTaDvkzpv7bHbSS32Zx9I5j/T6IiN7a kWHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=ozk7Pa5qLTZgdJctd+qEqPrPU3/SCkI0M9lIJ97iTIxPEj8bPnc8Qhlu35d3ajReQs 08zE1rguqDpQWzUl+p60KKm1lG3JQBefSgghDi5S8HuvK/g8RwH3qH1+5yQLCNVXZxBx UKYDcUTLbohkw4RWvNOlZANyK/tuqHsUxF0RO6mQdE8Cjz//9+PR+4TW/MESHIO8B5ze yCBeWB06XU8XakS/ICi6isiwoN+WWFfbzMyXDN+MCVFDQzHBvRRdRhydfyGgvglzxynx g0YpLHBLZbY3F12ML+3j58Oxd8LNupb72TtSFflyrfieoXG5G3EG5vMZZLbXZh9paxLz BHOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h78bA6SX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t1si9485966ybo.308.2021.02.05.15.02.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Feb 2021 15:02:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h78bA6SX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8A7q-00008F-1I for patch@linaro.org; Fri, 05 Feb 2021 18:02:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8A2V-0002Bb-VA for qemu-devel@nongnu.org; Fri, 05 Feb 2021 17:57:23 -0500 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:40544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8A2U-0003ME-6s for qemu-devel@nongnu.org; Fri, 05 Feb 2021 17:57:23 -0500 Received: by mail-pg1-x530.google.com with SMTP id b21so5565786pgk.7 for ; Fri, 05 Feb 2021 14:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=h78bA6SXlYmOsELiPucHg3RTgg0+WrgcB5+6LnNc9vqEyTibCJAEy+IQmcuPvHChHN UQnjoCAvpTopaGiU7b324qrLHHGin9Ki/gHZWQca1vUyztrmlhKYCUX9LKoAvMt2Z4mI cdVKQ8R6dGxUuzkv2/4L55rsjaWjsWk3ozPUZnHNvPpONO1BjqVi2ka71Vb/k6sZtMm+ ihpu4r2c4N+wmOvhQjQ7ZvFvNIB58yQY2i6rmWxXl/IY6dYcpixFsFwhipl2JA6N2Bp7 co3t6dSJ4OEVHE6nfNvY+ZlZC2NE11EOkCNzLLZtwA/aCeQqFdb4FLmNJWs5sWFR6rbh kx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=GzugvEiKeBIZ+WGCJsoVh3vdOODjnMRAXEqnlsef+U6SJZLeTKMEdhwTzsfXB4coYs jBkTrTXvJaxWmTXIf2pHhcpMw0kpPD4DcGyFS9CgTRdkh20kuhkurbTZIAyONO8abtAW twvLs0Bj0eNCJgDlwLocppeDUmSc0BsAJKZ7x0Y/RC1oGoJm42HxU3WRWdjF/ZLzAH+E Lpf1TPh2hw+xZd3vlj+f0kWSD48TcUuapHfBsm57f7Nz5/v+WXoTsO4DquCxguzl7YWR mhNt3YAKRnt3/ijEOQ0sSC81NPPmoF/LBdhUZ15iK66LhvueOmKEB0NHR9qsaJSXYwYu 4xxQ== X-Gm-Message-State: AOAM53239iaB3TWDfe467TK6R5t1FvZCQmQsMmJHvCYFS+Js+XY9QNAH ODrQtkDWQmtckePpYWe1hCn5XQzCWKUJxCLk X-Received: by 2002:a63:150b:: with SMTP id v11mr6840229pgl.183.1612565840003; Fri, 05 Feb 2021 14:57:20 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id c23sm12155149pgc.72.2021.02.05.14.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 14:57:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 14/46] tcg/tci: Merge INDEX_op_ld8s_{i32,i64} Date: Fri, 5 Feb 2021 12:56:18 -1000 Message-Id: <20210205225650.1330794-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210205225650.1330794-1-richard.henderson@linaro.org> References: <20210205225650.1330794-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Eliminating a TODO for ld8s_i32. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tci.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/tcg/tci.c b/tcg/tci.c index 7e108bcbb3..c31be1a1f4 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -587,8 +587,11 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, t2 = tci_read_s32(&tb_ptr); tci_write_reg(regs, t0, *(uint8_t *)(t1 + t2)); break; - case INDEX_op_ld8s_i32: - TODO(); + CASE_32_64(ld8s) + t0 = *tb_ptr++; + t1 = tci_read_r(regs, &tb_ptr); + t2 = tci_read_s32(&tb_ptr); + tci_write_reg(regs, t0, *(int8_t *)(t1 + t2)); break; case INDEX_op_ld16u_i32: TODO(); @@ -855,12 +858,6 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, /* Load/store operations (64 bit). */ - case INDEX_op_ld8s_i64: - t0 = *tb_ptr++; - t1 = tci_read_r(regs, &tb_ptr); - t2 = tci_read_s32(&tb_ptr); - tci_write_reg(regs, t0, *(int8_t *)(t1 + t2)); - break; case INDEX_op_ld16u_i64: t0 = *tb_ptr++; t1 = tci_read_r(regs, &tb_ptr);