From patchwork Thu Feb 4 01:44:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 376198 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp857351jah; Wed, 3 Feb 2021 18:32:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNVSpforoEk3ICVy/9IhdNKe0VdNfBzqojaySZSnoA/rAl8Xo2rpNUuALzdFCK868cjffG X-Received: by 2002:a25:e54:: with SMTP id 81mr8748289ybo.404.1612405925179; Wed, 03 Feb 2021 18:32:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612405925; cv=none; d=google.com; s=arc-20160816; b=Y4Yx2+3+ZBEtxLJwljmko0gwg/uaTzOrRSrb0b2AKqJDgRJPu48adn9yu3V4BWLedY 219zQqd6Wm9yAe7S9qEPxHEpyLUgqP4LmrLZn2dB3RaolK3/ockyhMf3wOyCQt4gIE+/ mQGvipmCs8Rg+zHizVQCANCKv0CFZGEaauvVTInG59VrrMA/N94aKLX15ztoNnCJf5b3 XtzcIcpGE5cU4Ss4zzgmiy7dfPGULaNLIEgjOGgu3yYYt2jXl6ooN1PdJ4Klc2F1LjmK pmjN8qANzqiSZwqiiB3QOE5KpNQdvl+XUzxOqdfSCjrDScyzRh7+gm3BnLmYCfJS/4hr wsiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=YQBNB7jLXwaZJSYBL0BvoU6n3wPE6zwxayv+Hpeg13U=; b=Aeiy90iSeTIQjGb+AF4ttl1muWTXFWt9FMHERKZqqGmo97yHqzRXtrSraCH7aEyYqh +6WzLl2OTIPtky9OTwQ0dOUhlCIM2fcmJsPa8cNraNFWtmLcyNgPeC1IBf1QQTAs7QQw +5VLi6Mg+sgYkf4b0q7jfWxurMB7hhNXSQyv1HxYog57fxxIqHT3+hejT2qQ7Z/fl+e5 0PJQgK5Tla3gRDz21RuIzSpX3GCht60h31T0UA85ewj4iGdGXG4W4yuHvqy3vXAxAnCy XVnCQx7groDBGaTmTjs1tgThQvfLojuw2gqDJ0XD1yh9BQiRxx6IgKdRU+rzfdkQ0XdR m/1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uXpTlARh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h15si4209711ybj.96.2021.02.03.18.32.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Feb 2021 18:32:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uXpTlARh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7URA-0007im-LV for patch@linaro.org; Wed, 03 Feb 2021 21:32:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Tjh-0006Cl-F2 for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:47:12 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:36058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7Tjd-00048r-DR for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:47:09 -0500 Received: by mail-pl1-x634.google.com with SMTP id e9so898042plh.3 for ; Wed, 03 Feb 2021 17:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YQBNB7jLXwaZJSYBL0BvoU6n3wPE6zwxayv+Hpeg13U=; b=uXpTlARhhPLGPSnuVDZU8sjiGNGdW5EXwqXne5QuPo2m5mq4baN+1dAVNZeyRC8ldl gwbfi/jhdkTsxiIPppl9gDL591Gr4BIOD9+EqsoHuxnHySXDo5KdFZvHU0uExJLDOOOb 0kTOH7fDtAkLYStcfaB3DvPYckJ9b00LKS4J6ytMQzwgH/UvGIv7fUWpTFhLkiPUxKMY hjRu4057ezcvufKh+gs0oId5SI9YErJR4jwz+cE6FLe89mWIpxfkuzXbYGid6rMD4M9/ IDVjLc6m6dwHmurHvrqbM+bqL2D8CfLixz60iMciKyWoAkKXhPRLFcCl8eBqT9BxktqO 972g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YQBNB7jLXwaZJSYBL0BvoU6n3wPE6zwxayv+Hpeg13U=; b=r9o0Jeau9sDbuYZLpO2MwG/c9rpkZkrzKtyvj5E7/FSYfgHk9CK2aT6KeeimjJldxM TKnMTcrEurEvu6UMRqhWiUYe1D72WQgBJcQwIVLvYeswb1BH+mEHcmdJHDfgMv1h1/lU JoS92c0HInOGlHBCcmzOYFl6HQFwHWaQsAg8kQ99eVYbwBzXCzLJxGUCxVF0+vghjI6o Tu/MtjwX8wsiHqbvkCbUTE91MT5lk2yMX9H4Di6ZT7jvjCR4UBxiZOz6E1Nj1GDBlj84 lm7v179hbbV2e5gE8iZxnnyfTsBLX7cy0HR5qp245HPCQMsbNGwu1+gsf725YQg41XCT Lqag== X-Gm-Message-State: AOAM531mn4Ew2O+MpbdOq8qZcBwqcUEYFC3QT7DX1sGVA7SXCrEcD9qG 8EcIDjtcppytcVy3eNePNJo1OggtymkNELrs X-Received: by 2002:a17:902:70c3:b029:de:af88:f17e with SMTP id l3-20020a17090270c3b02900deaf88f17emr5777031plt.3.1612403224131; Wed, 03 Feb 2021 17:47:04 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id q132sm3835462pfq.171.2021.02.03.17.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 17:47:03 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 64/93] tcg/tci: Improve tcg_target_call_clobber_regs Date: Wed, 3 Feb 2021 15:44:40 -1000 Message-Id: <20210204014509.882821-65-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204014509.882821-1-richard.henderson@linaro.org> References: <20210204014509.882821-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The current setting is much too pessimistic. Indicating only the one or two registers that are actually assigned after a call should avoid unnecessary movement between the register array and the stack array. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 8d75482546..4dae09deda 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -623,8 +623,14 @@ static void tcg_target_init(TCGContext *s) tcg_target_available_regs[TCG_TYPE_I32] = BIT(TCG_TARGET_NB_REGS) - 1; /* Registers available for 64 bit operations. */ tcg_target_available_regs[TCG_TYPE_I64] = BIT(TCG_TARGET_NB_REGS) - 1; - /* TODO: Which registers should be set here? */ - tcg_target_call_clobber_regs = BIT(TCG_TARGET_NB_REGS) - 1; + /* + * The interpreter "registers" are in the local stack frame and + * cannot be clobbered by the called helper functions. However, + * the interpreter assumes a 64-bit return value and assigns to + * the return value registers. + */ + tcg_target_call_clobber_regs = + MAKE_64BIT_MASK(TCG_REG_R0, 64 / TCG_TARGET_REG_BITS); s->reserved_regs = 0; tcg_regset_set_reg(s->reserved_regs, TCG_REG_CALL_STACK);