From patchwork Thu Feb 4 01:44:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 376162 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp839594jah; Wed, 3 Feb 2021 18:02:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFZYH7XULXqggTBHXAUzSUoF3V/4/5C5uAsYzXfOc77grn1TWyFoPtUQYLaiTfRkECKDoE X-Received: by 2002:a25:55d7:: with SMTP id j206mr7886167ybb.6.1612404153504; Wed, 03 Feb 2021 18:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612404153; cv=none; d=google.com; s=arc-20160816; b=e7Y1xzqWOXdN4nksbazfxpaHV429Np0DZRspsRz/913XlVlwrHqCuvkDeFvZ01gZsH jvnYFPcWqQRA63cr1cvouB6B3xtm14AJGjKn4s05aO1U+z5JUfR5xVt/95lPPnJUXX8Y r+9XTmEAYEXehpfcZSSoyn6rOHI0LgRzkEBP/thO8kJxys93iRklalPYeZ41nqB/VAaN uyaAgqvYnr2tv1QzNnDFMkFml0Wu55uqd1MsYNFsKo8f2nuHLPDfZUB99LzxxWxTXtw+ diGAYcV+BLJFYpDwINCn/rVh+t4rdiTmtPsnIa2jukCIrNRCQV1k2hY39UaPAmaOWEII wfjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=KDSNaMMmAK8yFpWyVcF60dXkZWnAqLwLhvKqtUqbbYRvHFTmSX630sZAmyDhG4ATl6 uIj5EenIjglDXXRbql3bEqAbYqz4SMKM/Kzzgzy/hB/P6Ad55bINOCFjlSZmeNJ62UO5 vEcgEArOwcUhwwMyxDwHSmtczu4GhdyuQDB2X989DBrUYWy4uyQe4V0GGX+F4cr/doNo 3eGp2LPWf/w9Xe5QDT12rFChehjywdM4lFLDNKraWK59Vlza8w46E/ct+lBWxrYVVmE5 MEKJWPbvirjJkHAsXW9TCUzkljiwqjbVj0HeNP/EQvoNku/AYld0mKh3WWF0XO0/BCut oWIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GHN3icFQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b6si3736289ybk.485.2021.02.03.18.02.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Feb 2021 18:02:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GHN3icFQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7Tya-0007jP-Uo for patch@linaro.org; Wed, 03 Feb 2021 21:02:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Tiz-0005Hr-Ew for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:46:25 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:34694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7Tis-0003vf-8p for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:46:25 -0500 Received: by mail-pj1-x1030.google.com with SMTP id my11so4244205pjb.1 for ; Wed, 03 Feb 2021 17:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=GHN3icFQ6n/hCBrkLU111p16ZGoNy4IkqtDhhAhxbQ4VUvo0h7i1xVaTA8/P1JFqgk TObgtqagdhV6fvK5mm7HVMAkm8y5Hc5d0vzIRSqYama9vfdgYT5ncAwJ9M2ynPj9gOrw PFGrdlQlJipd8fjw9et4Hzu/pUsB8ja+2HzuFms7OMco2NUJ15Eh6SfQLrr22Ofrd11d z/vpESOUsbdCGob9a8g/ndbJjlG9yj43m0kOG/CzRmLxGEaHDek6o27Bj6bmj3CSR62c /WP/KFnDIhO1Mbfm5QvBU0WW5vdowqu8jCr49cRn44AsZPAO88DId3tgAFxgvuWIJdj9 Ga/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ybRVe+0cbcMgdImiuixof8hM4eoxKsh03sT+tgpyyEY=; b=SZu24ANiQaNtaRDcZbu02FSuT2Z7MO7X5vDvVG7DiE115UUPTFIz43kBaOMtRr2j5/ zV3JwY2fFJGhWBR99PsvECSyePFuojFSOUbTZp1D1IGvKUYd1W264WD2Bih2l3qojSW6 MQGI2ks8PItbAmQd8PnN/eLEps5YP1RXYCiRn/O1DUIOuD+rehDhxgBl66mB2XK1zVnQ 7LyyaRt6s3wmMDj9IeE0CZI6mSRFQIkORBXbBPjk7uzowbhAFDeH8bo+rNvkmoORiwso s2P3/Jc4xfODY8G51Pqo/g9gADU7rSBEoj9csV4/5J5T5hGUi2p0Txl4Trn91kMdA9iw bHBQ== X-Gm-Message-State: AOAM530zx9ocM5GeWL0KG1j7hgwi6syCAOR3f2qh8Q2R41YIBG397hFg Uhgo+dYqlwWxoJaoaXYNbYp0+8opETyrXQh0 X-Received: by 2002:a17:90b:8d7:: with SMTP id ds23mr5790883pjb.116.1612403175863; Wed, 03 Feb 2021 17:46:15 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id q132sm3835462pfq.171.2021.02.03.17.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 17:46:14 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 35/93] tcg/tci: Remove tci_read_r32s Date: Wed, 3 Feb 2021 15:44:11 -1000 Message-Id: <20210204014509.882821-36-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204014509.882821-1-richard.henderson@linaro.org> References: <20210204014509.882821-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use explicit casts for ext32s opcodes. Signed-off-by: Richard Henderson --- tcg/tci.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) -- 2.25.1 diff --git a/tcg/tci.c b/tcg/tci.c index 72ec63e18e..9c8395397a 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -57,13 +57,6 @@ static tcg_target_ulong tci_read_reg(const tcg_target_ulong *regs, TCGReg index) return regs[index]; } -#if TCG_TARGET_REG_BITS == 64 -static int32_t tci_read_reg32s(const tcg_target_ulong *regs, TCGReg index) -{ - return (int32_t)tci_read_reg(regs, index); -} -#endif - #if TCG_TARGET_REG_BITS == 64 static uint64_t tci_read_reg64(const tcg_target_ulong *regs, TCGReg index) { @@ -149,15 +142,6 @@ static uint64_t tci_read_r64(const tcg_target_ulong *regs, return tci_uint64(tci_read_r(regs, tb_ptr), low); } #elif TCG_TARGET_REG_BITS == 64 -/* Read indexed register (32 bit signed) from bytecode. */ -static int32_t tci_read_r32s(const tcg_target_ulong *regs, - const uint8_t **tb_ptr) -{ - int32_t value = tci_read_reg32s(regs, **tb_ptr); - *tb_ptr += 1; - return value; -} - /* Read indexed register (64 bit) from bytecode. */ static uint64_t tci_read_r64(const tcg_target_ulong *regs, const uint8_t **tb_ptr) @@ -887,8 +871,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, #endif case INDEX_op_ext_i32_i64: t0 = *tb_ptr++; - t1 = tci_read_r32s(regs, &tb_ptr); - tci_write_reg(regs, t0, t1); + t1 = tci_read_r(regs, &tb_ptr); + tci_write_reg(regs, t0, (int32_t)t1); break; #if TCG_TARGET_HAS_ext32u_i64 case INDEX_op_ext32u_i64: