From patchwork Thu Feb 4 01:43:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 376161 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp839310jah; Wed, 3 Feb 2021 18:02:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4bhh0jXAWijIxG572hmWhXrr3MFUaM4hLfiiMfHZt6CrWwTP/oJtdAgh64XUN0g+TOQV4 X-Received: by 2002:a25:ca55:: with SMTP id a82mr8357199ybg.235.1612404129364; Wed, 03 Feb 2021 18:02:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612404129; cv=none; d=google.com; s=arc-20160816; b=PSQXyjesh5K3xe59hwAY5tv/5CZ50h0laeL7xYrKli2BhBcGK4s0O1SQHWo9AceIgr CwR+gH6fskyb1VIp2yGyfZ/VXl4eZv84ndf7G30Z4IREoddrEyUZhSPydDb11YUuIBdC 4CTBYFzXuBZFVwBTk1x/pfKkJ8+o0pC59GBdvI5rMsqNf0JDQ7hxQLhjFITKcGoZdN9U M+m2TJnlKHoGFb5c9qLbMYltEJYCxKjV0zWtjnVnXnFpYOZ//xGQFuw6iDmZZ3ETOOVc VQOlVQ9IJhrEEU6s/th2vh4geiB2lfsihmdUnaxhqyYmqUg5ld869JjWA7LFRtJcRK8f 9qUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=s9l+n2kT58S3e1V1MwSMWe4z+8Ol/Hhm1UwYyrtS8lURJHKtiDUiQpm/CXMBg/MUDF eAH1IQxvxFBRUfsfVhTQFzAAdJDZTothRrwDlRK6vVOmdSoBoAtMZXsk3n1Qdaz4mlmo 2DHi+9lSd4MJc6+x9Ezm55oclmSp6/7mu6dg7gEmbtnbCv79iaqDjl1aFcurzyJ9n9Hr LCaJzcZGVyN8W3GS+GubaQX9dVisT/Xk4zYCL8kKp3mSlO7mMc9R169jUoh0e5Er/LF5 72qv1khdF9DnrQ5ZyefY0bvVP7aF0d3Sdn3/300ThZEMi6/FA0XJ2XLSip7fK8rRZQye PO9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UfBjul+b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f95si4519697ybi.236.2021.02.03.18.02.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Feb 2021 18:02:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UfBjul+b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7TyC-0007F4-R0 for patch@linaro.org; Wed, 03 Feb 2021 21:02:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7TiO-0004lf-Be for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:45:49 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:55433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7TiJ-0003ie-2P for qemu-devel@nongnu.org; Wed, 03 Feb 2021 20:45:47 -0500 Received: by mail-pj1-x102f.google.com with SMTP id s24so767280pjp.5 for ; Wed, 03 Feb 2021 17:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=UfBjul+bPBIcX1icEoskim/EySeIf6QRnYqdF0wZkPkYOsYrd/H5PrhNdAeDC9QwBH +/cDEenkgymVPJPn1S31zK/tMJBMALlkMCnEfQPEyMips5daxoNNOKR+lDgU5wNJCXyE TnJkWexxAB2xALsASLcDM87TbhGEqsqQXndP9OpEu8JM1RHlV2Ln9BzXZdGoMpzuR12R 0G5s7P3SIXFjLn8V35gpsOnEypZ5Zvcsl08Ltt/JZuIUB8IoV3yyz1UolqIMbWQl/FPe WK9y5UYMrx1L+xk6dAF0A8tRYuVr0OlrzObEVt4uYx2/AZ6DGIQhmHvzt0Pe50UVWsff xeOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ivQ6CdRm/OXUCJL48bE6dU1klkzWgC1aTXX7CV1kiyA=; b=bdrKMm2mMjN3+dPh+Opup97yh4qS0dssEZ3lk+LLHBQF14K/HeLaVCDEHTy0+NXOGI agTCRL1fKigltLk+E7Z1DW+w9DdFopUDlY1ffBCVkMytl3KgPw7UO8l7YRo2jYE/VlTn oPXG3hwGnHbzBYd/3/S3Ojq39HiFbbSNkxgTtgcsz+GNDQf2uh6zvj0qWqJBBJOtv1uR 4OttojLYPshAomlCx7ncLSk2RRmYzHZ/IE71Pc9VqPHpesoq+SnCYn2AJcQypw25NIl7 PZ58zvlS2lUQuk9yWmpknIO/nJCePaOvzxI861w3dvObTsGPEr/W7nWCTPWdDUF0mebk hZ2g== X-Gm-Message-State: AOAM5317nAOXMtH5QdrT3LZC5twYs/Cs336fOPQzKsFTo2mvyLV+BlJ0 sr4HpUSN/CpS+qyDni0hZrrP9SCC6uzqMAZe X-Received: by 2002:a17:902:724c:b029:e1:4aae:c72 with SMTP id c12-20020a170902724cb02900e14aae0c72mr5743828pll.81.1612403140657; Wed, 03 Feb 2021 17:45:40 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id q132sm3835462pfq.171.2021.02.03.17.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 17:45:40 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 14/93] tcg/tci: Merge INDEX_op_ld8s_{i32,i64} Date: Wed, 3 Feb 2021 15:43:50 -1000 Message-Id: <20210204014509.882821-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204014509.882821-1-richard.henderson@linaro.org> References: <20210204014509.882821-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Eliminating a TODO for ld8s_i32. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tci.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/tcg/tci.c b/tcg/tci.c index 7e108bcbb3..c31be1a1f4 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -587,8 +587,11 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, t2 = tci_read_s32(&tb_ptr); tci_write_reg(regs, t0, *(uint8_t *)(t1 + t2)); break; - case INDEX_op_ld8s_i32: - TODO(); + CASE_32_64(ld8s) + t0 = *tb_ptr++; + t1 = tci_read_r(regs, &tb_ptr); + t2 = tci_read_s32(&tb_ptr); + tci_write_reg(regs, t0, *(int8_t *)(t1 + t2)); break; case INDEX_op_ld16u_i32: TODO(); @@ -855,12 +858,6 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env, /* Load/store operations (64 bit). */ - case INDEX_op_ld8s_i64: - t0 = *tb_ptr++; - t1 = tci_read_r(regs, &tb_ptr); - t2 = tci_read_s32(&tb_ptr); - tci_write_reg(regs, t0, *(int8_t *)(t1 + t2)); - break; case INDEX_op_ld16u_i64: t0 = *tb_ptr++; t1 = tci_read_r(regs, &tb_ptr);