From patchwork Mon Jan 11 19:00:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 360578 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp3142646jai; Mon, 11 Jan 2021 11:24:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtkdOoTOGR8g12d2s2HoQPGFQoe4vr35rkkXWj8zVh5icKViT0JlCsKqGrQIiIrrXmgbjC X-Received: by 2002:a25:e694:: with SMTP id d142mr1811052ybh.494.1610393096265; Mon, 11 Jan 2021 11:24:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610393096; cv=none; d=google.com; s=arc-20160816; b=O1qNkeGIA3a0Ed/YPQD9aCIjeHfz8uor1POjjt1B74BUZ89LRcGOmlp/XIWYd3DAif PJD04y8zsYg7VVxvksxlqHSoLHbR0ef2gQy0tEyEwyJiyjA9QWg/gQS+FPbkRhTDk9un 0Cg6319FTGQIlyLL6FG3lybSo8XQFzyKx/VglP8NE976aQ236d8gnGbW4hqP8TLTurN3 KHO8n/+5GOZdziaGXyVEfE4lHupNlSwU8f4FM3F6nFfkNttsIHK2pwvMEtaIn+J7Cu1H XiN7opqOQrZ10d7hKQLR+Q9PwVPfd5df4ADgsRfg9rpa1y86hKyZLl42SX+QuIPaEBvZ D0cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=SwH2WDpQXh+eCC+rwEcKb2gXwbMlbSUNldc2fkveHPU=; b=aOFHyPa/fxVYzKk4wojXr+hlc+AuDPt+JtplE3l3LQ4lAi3miXN7YO3H3CvZPOm6DZ 9iIz/2kyWRZuxreh+dw4dhL/1UazTQAsA7R9eAruTDSsZw0FEP5GplXJ93aY0COvVr20 f00vzjQtw8SxTxevjWL3dhhPJR7/3/la1Tvv+fuZHPdFKC5hxzNDsTvyRcezTk27YMM5 TfL4SOMYT7gB+zyaGtxkoVq3qDUb0C3Aj8t8a2L/43MeALaW3qgBBG7Xj01CbIu2RAzz fllLJToHtcS1e8z5IpzOsdAI6HucwFr5nzUeps+NdEsJyZFPetx/4esTkyZU+rTei3D5 jl/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=qW+gDlLY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d36si696904ybe.394.2021.01.11.11.24.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jan 2021 11:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=qW+gDlLY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz2oB-0000xN-Nd for patch@linaro.org; Mon, 11 Jan 2021 14:24:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2Rx-0006BF-V5 for qemu-devel@nongnu.org; Mon, 11 Jan 2021 14:01:57 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:40063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz2Rp-0006Sr-5T for qemu-devel@nongnu.org; Mon, 11 Jan 2021 14:01:57 -0500 Received: by mail-pl1-x62a.google.com with SMTP id q4so333558plr.7 for ; Mon, 11 Jan 2021 11:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SwH2WDpQXh+eCC+rwEcKb2gXwbMlbSUNldc2fkveHPU=; b=qW+gDlLYDqnGsyqsPA4A9Bp3DQWWdCWBxOieyOV2N5jkvMlz52Se2tGd+sp4NwAV7v yKoLEJDcRMWTsK0A/XTkj3D0IDAHKnzSXuY/PHDVKwWGJouwKnrS/n9c8t3rQCT440JN J1lf7eogwmL+qUaFujvvqskTiKGDaP5GKiCdYJzje7TrS7ioWNpEoe0t4vjN8jEi+3u8 XyaJGMFODeC0qBr/fXFBlmjQF31s1IUCDpo8XQmBgz4uxHlFQj1EXUsswGbOWTMMAmGg NOzu7TgQDsfq7cN2ySix73rEeKlUneZbd3svPbd3M7AHVv+p/obZ3Az5sqjg0hDCpJ5G 5AdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SwH2WDpQXh+eCC+rwEcKb2gXwbMlbSUNldc2fkveHPU=; b=etr+BClKLxBEMrxCIPHZ1eNptDJ+NJv7KvKHDpZaseOETmBpy/JfK6dXusT/inCF0H gRrG+iVwVNA9AR+uWFRKen/6z/jNivOsfCd4GhpMNp/SpbXfR0gnSHXt8Di6GybUxVhD v1g7R9Nw2hr0t8COXEXqFHiSMwFY24u72ua7+4SkBSPHmVeYMJLLmmlT6nv5uGOPrNuR GkY9DRFgtPV5C3Fcvuc1yZiumBFBP9gM4CPY+ITmJj6N9hyI+wzAHwCiqrMOz5lmjsXp dXDoGQazCTtWZDdN/MPGBRZgqL7/aIXmSMuv7VGlBepNjUOuNm8TR3MBx+L93iFv8ZzF KHrQ== X-Gm-Message-State: AOAM532N91KTxtAB1ZzJNa9AhCcbgWCA2g6z8bl7vJZIo2Ga/pmlAAw3 h31TI1w+zSoGRbOkjZU5vSc0xTQ9HDsYnA== X-Received: by 2002:a17:90a:ead1:: with SMTP id ev17mr286171pjb.51.1610391704374; Mon, 11 Jan 2021 11:01:44 -0800 (PST) Received: from localhost.localdomain (rrcs-173-197-107-21.west.biz.rr.com. [173.197.107.21]) by smtp.gmail.com with ESMTPSA id n195sm350395pfd.169.2021.01.11.11.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 11:01:43 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 16/30] target/arm: Enforce alignment for LDM/STM Date: Mon, 11 Jan 2021 09:00:59 -1000 Message-Id: <20210111190113.303726-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210111190113.303726-1-richard.henderson@linaro.org> References: <20210111190113.303726-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index ba68d4d7f4..dbe74e2c34 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7831,7 +7831,7 @@ static bool op_stm(DisasContext *s, arg_ldst_block *a, int min_n) } else { tmp = load_reg(s, i); } - gen_aa32_st32(s, tmp, addr, mem_idx); + gen_aa32_st_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN); tcg_temp_free_i32(tmp); /* No need to add after the last transfer. */ @@ -7906,7 +7906,7 @@ static bool do_ldm(DisasContext *s, arg_ldst_block *a, int min_n) } tmp = tcg_temp_new_i32(); - gen_aa32_ld32u(s, tmp, addr, mem_idx); + gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN); if (user) { tmp2 = tcg_const_i32(i); gen_helper_set_user_reg(cpu_env, tmp2, tmp);