From patchwork Sun Jan 3 20:50:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 356156 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp14472067jai; Sun, 3 Jan 2021 13:06:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYSZzsbw6E29qHvdr7EIl39fM9jKEX52/mtkq/dr2TEa5gaA5XyaA2I/KoJkt8Pe2F8Y2S X-Received: by 2002:a25:383:: with SMTP id 125mr97489519ybd.120.1609707983308; Sun, 03 Jan 2021 13:06:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609707983; cv=none; d=google.com; s=arc-20160816; b=Gj/pc7ohK+UIQvxDHkHWsg83do8XcA1+9gTkUKvT8oqRwjRSpzQ1SNzUN/4FihWwXq GLLmWal+TAkZ+T9FnxbBG2aQJqFtvw9t//Eiei9xbXsaeIIRGw/of0H7ho6G52IJXWQb cvIVMzF2CfuQEh3srHnRyfqx4CwOwCPAZ2L/V5f8ULfgGsMDrmPM3VM2PF+k3v9pPG2F KA9kSYiy6VP/DDcSyFXs+F4GEPovgcHwL/UPmeWF6wiRdf7wdn25DP/tXiwaMemAdbti 7au6Zk1UwXo8j3Ni/fmj+sYsRgsEFPRstwQgkWZ2h9CtkuI6F5dAtRtcFYtfRs3hs3bC 0uWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ONmR7DvST/KHwvIMlpQESaWh+hvboxmRkL03nu+T/uM=; b=mgOAZEWZj2LlyUG22RBlt9q4bECulmjTe/JGcEhzNiP89aZrX6pGl4VThg6seD42At +lGpOy+CJ4h8mskuE7qiUcH4Wk5q1/NWeJWLeLxPyOrrj+ZRkvZpwx2GHbSHJ7KxNrMR Ap0Gqd7WNZ0L11KwrrV/C+v4DtQ86mWPTiZb1eBReuAX4D+iP3dXeHVKxB7PhvxllVY2 w4YGcuKMGjh0tDuYuO2G2ZWLjyIJRv1IlUKUr1oJvoWVvlKtpCQ61K4XEtDA6HMdB5+w MRFe5bBr4Owtu593avgX8kYQHj9E832Vhk9HJloBxaZYt3m+rJcInOgE1gJ9/ibGKpZm MrUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HEzjlMV5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=amsat.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k65si33531888ybf.156.2021.01.03.13.06.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jan 2021 13:06:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=HEzjlMV5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=amsat.org Received: from localhost ([::1]:51782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwAZy-00043c-RC for patch@linaro.org; Sun, 03 Jan 2021 16:06:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwAM7-0003qm-GC for qemu-devel@nongnu.org; Sun, 03 Jan 2021 15:52:03 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:54898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwAM6-0006Av-0k for qemu-devel@nongnu.org; Sun, 03 Jan 2021 15:52:03 -0500 Received: by mail-wm1-x334.google.com with SMTP id c133so15945104wme.4 for ; Sun, 03 Jan 2021 12:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ONmR7DvST/KHwvIMlpQESaWh+hvboxmRkL03nu+T/uM=; b=HEzjlMV5Y+TSG3Oz+s7DHMSoie7zxoE+rmiD6vVzX8Sjr/g2KwEUVjmXFLtt3JWG5Y H/HCUC7sRl7fkS05Rpt/aYf5sWridbt/Y3Ddqfln5eYvVTLYDfh2jGAi5LwH2nt53thq 6LfSkwIKUC5Ze1sSQ63zY9+9+fXlBwlX2l/123ad1Vy9mWW1xdnHR6CG2o0AIoAxVHNN r44p7HuA+UQnIEw1qtwhjeIFziqoko/2w8S9cDXQAhOvqLgTiUHtbvRDLMZx4DckrQYF LqPL/ljscRyBcibzVx20bGEkDLj4GQ82RPJU6kWZj6Ad7y9dhn4/7KEQ0ksGf9/ri7Hn gAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ONmR7DvST/KHwvIMlpQESaWh+hvboxmRkL03nu+T/uM=; b=PwhOSOzqmB/S7H9eJffp//NiEANf/mJCGJ/3Jv4XErnsY43TS0HYluoNLXIS3fk+5H Bx55xDcPKYeK2Q1F3xht5RiE/P/xfNC+uHQG9MRxVcqaMKh27ejDcaPXFDmFC91U66ob 4+eSNmPN4ATbysBLUUOq9sg+WWrrVAeUdHh3DsoXCkQukP6E103v6Q3nlbil9Eko8gJM 1FBBqz84abnnqaKhyl9DpyeEXyd70RfVthcwwO0lX+tiaVkRIHpIpIclAugBC9iEH1Sn 1ldBz1/P4/af9xzxZF2o3+uUDzGqBOPVhvrvfkJxxOXi9QPkGPuBYOlgrhKudAwGcVoB qEoQ== X-Gm-Message-State: AOAM533txzc0uv3yjOtSxYoVoVW1uHid7kRYa++MROtpJT6jWNdTb7ey ZSxLXoo0t1RlcdhNHiyIPpTQ7Dbuoc0= X-Received: by 2002:a1c:9949:: with SMTP id b70mr23702785wme.72.1609707120644; Sun, 03 Jan 2021 12:52:00 -0800 (PST) Received: from localhost.localdomain (194.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.194]) by smtp.gmail.com with ESMTPSA id r1sm90034783wrl.95.2021.01.03.12.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jan 2021 12:52:00 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/35] target/mips: Don't use clock_get_ns() in clock period calculation Date: Sun, 3 Jan 2021 21:50:06 +0100 Message-Id: <20210103205021.2837760-21-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210103205021.2837760-1-f4bug@amsat.org> References: <20210103205021.2837760-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Luc Michel , Huacai Chen , Richard Henderson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Currently the MIPS code uses the old clock_get_ns() API to calculate a time length in nanoseconds: cpu->cp0_count_rate * clock_get_ns(MIPS_CPU(cpu)->clock) This relies on the clock having a period which is an exact number of nanoseconds. Switch to the new clock_ticks_to_ns() function, which does the multiplication internally at a higher precision. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201215150929.30311-3-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.26.2 diff --git a/target/mips/cpu.c b/target/mips/cpu.c index b2cd69ff7f9..2283214c879 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -380,8 +380,8 @@ static void mips_cp0_period_set(MIPSCPU *cpu) { CPUMIPSState *env = &cpu->env; - env->cp0_count_ns = cpu->cp0_count_rate - * clock_get_ns(MIPS_CPU(cpu)->clock); + env->cp0_count_ns = clock_ticks_to_ns(MIPS_CPU(cpu)->clock, + cpu->cp0_count_rate); assert(env->cp0_count_ns); }