diff mbox series

[v3,2/2] plugins: Fix two resource leaks in setup_socket()

Message ID 20201109082829.87496-3-alex.chen@huawei.com
State Accepted
Commit 9cd7dde0730ed823b545910c0d5a676142015e3b
Headers show
Series plugins: Fix some resource leaks | expand

Commit Message

Alex Chen Nov. 9, 2020, 8:28 a.m. UTC 
Either accept() fails or exits normally, we need to close the fd.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
---
 contrib/plugins/lockstep.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@  static bool setup_socket(const char *path)
     socket_fd = accept(fd, NULL, NULL);
     if (socket_fd < 0 && errno != EINTR) {
         perror("accept socket");
+        close(fd);
         return false;
     }
 
     qemu_plugin_outs("setup_socket::ready\n");
 
+    close(fd);
     return true;
 }