| Message ID | 20201027182144.3315885-24-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | cleanup qemu_init and make sense of command line processing | expand |
On Tue, 27 Oct 2020 14:21:38 -0400 Paolo Bonzini <pbonzini@redhat.com> wrote: > The check has no effect after both builtin and user-specified devices > have been created. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > softmmu/vl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index a46f1b9164..ae2854d8af 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -3489,6 +3489,8 @@ static void qemu_machine_creation_done(void) > net_check_clients(); > } > > + qdev_prop_check_globals(); > + > if (boot_once) { > qemu_boot_set(boot_once, &error_fatal); > qemu_register_reset(restore_boot_order, g_strdup(boot_order)); > @@ -4548,7 +4550,6 @@ void qemu_init(int argc, char **argv, char **envp) > replay_vmstate_init(); > } > > - qdev_prop_check_globals(); > if (vmstate_dump_file) { > /* dump and exit */ > dump_vmstate_json_to_file(vmstate_dump_file);
diff --git a/softmmu/vl.c b/softmmu/vl.c index a46f1b9164..ae2854d8af 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3489,6 +3489,8 @@ static void qemu_machine_creation_done(void) net_check_clients(); } + qdev_prop_check_globals(); + if (boot_once) { qemu_boot_set(boot_once, &error_fatal); qemu_register_reset(restore_boot_order, g_strdup(boot_order)); @@ -4548,7 +4550,6 @@ void qemu_init(int argc, char **argv, char **envp) replay_vmstate_init(); } - qdev_prop_check_globals(); if (vmstate_dump_file) { /* dump and exit */ dump_vmstate_json_to_file(vmstate_dump_file);
The check has no effect after both builtin and user-specified devices have been created. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)