diff mbox series

[1/4] hw/pci-host/prep: Update coding style to make checkpatch.pl happy

Message ID 20201012071906.3301481-2-f4bug@amsat.org
State New
Headers show
Series hw/pci-host/prep: Fix PCI swizzling in map_irq() | expand

Commit Message

Philippe Mathieu-Daudé Oct. 12, 2020, 7:19 a.m. UTC 
To make the next commit easier to review, clean this code first.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/pci-host/prep.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Mark Cave-Ayland Oct. 12, 2020, 9:37 a.m. UTC | #1 
On 12/10/2020 08:19, Philippe Mathieu-Daudé wrote:

> To make the next commit easier to review, clean this code first.

> 

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---

>  hw/pci-host/prep.c | 6 ++++--

>  1 file changed, 4 insertions(+), 2 deletions(-)

> 

> diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c

> index d0323fefb10..80dfb67da43 100644

> --- a/hw/pci-host/prep.c

> +++ b/hw/pci-host/prep.c

> @@ -234,8 +234,10 @@ static void raven_pcihost_realizefn(DeviceState *d, Error **errp)

>              sysbus_init_irq(dev, &s->pci_irqs[i]);

>          }

>      } else {

> -        /* According to PReP specification section 6.1.6 "System Interrupt

> -         * Assignments", all PCI interrupts are routed via IRQ 15 */

> +        /*

> +         * According to PReP specification section 6.1.6 "System Interrupt

> +         * Assignments", all PCI interrupts are routed via IRQ 15

> +         */

>          s->or_irq = OR_IRQ(object_new(TYPE_OR_IRQ));

>          object_property_set_int(OBJECT(s->or_irq), "num-lines", PCI_NUM_PINS,

>                                  &error_fatal);


Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>



ATB,

Mark.
David Gibson Nov. 2, 2020, 1:51 a.m. UTC | #2 
On Mon, Oct 12, 2020 at 09:19:03AM +0200, Philippe Mathieu-Daudé wrote:
> To make the next commit easier to review, clean this code first.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/pci-host/prep.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
> index d0323fefb10..80dfb67da43 100644
> --- a/hw/pci-host/prep.c
> +++ b/hw/pci-host/prep.c
> @@ -234,8 +234,10 @@ static void raven_pcihost_realizefn(DeviceState *d, Error **errp)
>              sysbus_init_irq(dev, &s->pci_irqs[i]);
>          }
>      } else {
> -        /* According to PReP specification section 6.1.6 "System Interrupt
> -         * Assignments", all PCI interrupts are routed via IRQ 15 */
> +        /*
> +         * According to PReP specification section 6.1.6 "System Interrupt
> +         * Assignments", all PCI interrupts are routed via IRQ 15
> +         */
>          s->or_irq = OR_IRQ(object_new(TYPE_OR_IRQ));
>          object_property_set_int(OBJECT(s->or_irq), "num-lines", PCI_NUM_PINS,
>                                  &error_fatal);
diff mbox series

Patch

diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index d0323fefb10..80dfb67da43 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -234,8 +234,10 @@  static void raven_pcihost_realizefn(DeviceState *d, Error **errp)
             sysbus_init_irq(dev, &s->pci_irqs[i]);
         }
     } else {
-        /* According to PReP specification section 6.1.6 "System Interrupt
-         * Assignments", all PCI interrupts are routed via IRQ 15 */
+        /*
+         * According to PReP specification section 6.1.6 "System Interrupt
+         * Assignments", all PCI interrupts are routed via IRQ 15
+         */
         s->or_irq = OR_IRQ(object_new(TYPE_OR_IRQ));
         object_property_set_int(OBJECT(s->or_irq), "num-lines", PCI_NUM_PINS,
                                 &error_fatal);