diff mbox series

[2/3] colo-compare: fix missing compare_seq initialization

Message ID 20200922095525.4081603-3-lizhijian@cn.fujitsu.com
State Accepted
Commit 862ee1e07e9d4dc97263fc919cb76364a2b6d193
Headers show
Series colo-compare: minor fixes | expand

Commit Message

Li Zhijian Sept. 22, 2020, 9:55 a.m. UTC
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 net/colo.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Zhang, Chen Sept. 23, 2020, 1:42 a.m. UTC | #1
> -----Original Message-----

> From: Li Zhijian <lizhijian@cn.fujitsu.com>

> Sent: Tuesday, September 22, 2020 5:55 PM

> To: Zhang, Chen <chen.zhang@intel.com>; jasowang@redhat.com

> Cc: qemu-devel@nongnu.org; Li Zhijian <lizhijian@cn.fujitsu.com>

> Subject: [PATCH 2/3] colo-compare: fix missing compare_seq initialization

> 

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>


Reviewed-by: Zhang Chen <chen.zhang@intel.com>


Thanks
Zhang Chen

> ---

>  net/colo.c | 5 +----

>  1 file changed, 1 insertion(+), 4 deletions(-)

> 

> diff --git a/net/colo.c b/net/colo.c

> index a6c66d829a..ef00609848 100644

> --- a/net/colo.c

> +++ b/net/colo.c

> @@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key)

> 

>  Connection *connection_new(ConnectionKey *key)  {

> -    Connection *conn = g_slice_new(Connection);

> +    Connection *conn = g_slice_new0(Connection);

> 

>      conn->ip_proto = key->ip_proto;

>      conn->processing = false;

> -    conn->offset = 0;

>      conn->tcp_state = TCPS_CLOSED;

> -    conn->pack = 0;

> -    conn->sack = 0;

>      g_queue_init(&conn->primary_list);

>      g_queue_init(&conn->secondary_list);

> 

> --

> 2.28.0

> 

>
diff mbox series

Patch

diff --git a/net/colo.c b/net/colo.c
index a6c66d829a..ef00609848 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -133,14 +133,11 @@  void reverse_connection_key(ConnectionKey *key)
 
 Connection *connection_new(ConnectionKey *key)
 {
-    Connection *conn = g_slice_new(Connection);
+    Connection *conn = g_slice_new0(Connection);
 
     conn->ip_proto = key->ip_proto;
     conn->processing = false;
-    conn->offset = 0;
     conn->tcp_state = TCPS_CLOSED;
-    conn->pack = 0;
-    conn->sack = 0;
     g_queue_init(&conn->primary_list);
     g_queue_init(&conn->secondary_list);