From patchwork Wed Sep 9 00:16:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 249393 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp5014781ilg; Tue, 8 Sep 2020 17:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9rfC8CDYNWpk496u93a4ajRoM52Fe25ltHwxev1T0EWQq8OeZKomY7WlzCFOBzR1yZ+mp X-Received: by 2002:a25:dc13:: with SMTP id y19mr2109528ybe.247.1599610897307; Tue, 08 Sep 2020 17:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599610897; cv=none; d=google.com; s=arc-20160816; b=QQAB32vNjo+wRzgGMUiS8UdghwGuW94B5VwZHz7Jin3qocPI3j63KOxU9h/QzOA7A4 Ys5bCuHzaIQtX75QPO6ZbadQUVTKmK9Im3u2QF//u3iHVIbCR7H40HSGs7H0fQO4cu18 nM4lkgzsfgPkZ2gTiS1RAEFO/co1Pg5AJKt4xb4QrMQO72zK+Sttd6NYYPEqePW8BBmA fg1oZrnO6LqKOs2CLStC1iTbdavt8r02+V66zh+RCoRkgvT8mvYQO23ATbYb0igyLSAk f4t90GqPehGbssC3Pc7VCbUetlbgku2dnND8jGfItHzXkLwQTO2IbCznB3a8aBaxpTOz EXjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=gnZVZh1VIOx2Bn7nb5JDBu+SrUOXUk1VIW8AryTGMI0=; b=PDZTQDWkgybI0moZaiyp8KjPrJhz7Bh1lJWbVRGFINy9lswzRTNAKM/Y7N8Ew0miLF FWZd7Ml5kjR/6XM8dNDRb768UO9byX8FfYMYDMWGHU5Ei7EfEdXewCszE+Q8JxMfsEZA hWTRlw1DbBEt8xhf40RRNusmh3eA/BXLu7VCPAsaSd817VBJW+qkIOQDsJuE14ZvHcki YU631xFdqCL50vfxr7yH5xk2pHDByfvQdVseWAbR9iOiBzq8MQYbh8eO33i3SqpirtcU SpWe0OBPnzmlFsCgwMcdCy2/zfgBsZxbTo9Gg26Z/3zUufih85jqQNO7hthsz1B9S8rW D5MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XGYUHYqA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p12si1114347ybl.42.2020.09.08.17.21.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Sep 2020 17:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XGYUHYqA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFnrk-0000xh-Lg for patch@linaro.org; Tue, 08 Sep 2020 20:21:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFnnJ-0007kO-Uj for qemu-devel@nongnu.org; Tue, 08 Sep 2020 20:17:01 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:39648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFnnH-0002C0-Vr for qemu-devel@nongnu.org; Tue, 08 Sep 2020 20:17:01 -0400 Received: by mail-pf1-x444.google.com with SMTP id n14so556664pff.6 for ; Tue, 08 Sep 2020 17:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gnZVZh1VIOx2Bn7nb5JDBu+SrUOXUk1VIW8AryTGMI0=; b=XGYUHYqAUUq/8y4Cz0ZjWF+WnH66TRjbnO1jZNAA915M5s6p3iTE8QiYOpsH7+nz/M Jse2yzQo38sh9ppjA2KcJnNgjN8QF6ckYUe0JcTvcvafmpJL6qCyHP8ZqGeaycVCL0VG r3tNyiJFqZhieSINao9WmbcmKO/wZv/48xXJ9ZZpzLD+6pglNhRkpWFGjVBFi1/gvh7/ lBRtJgcRVb1M3QTa8LDm9Z7jmYwkKqlWRAYEChI0sRM2kkR/dvimFVPWYa4bFkAeo6My xEwLbPDJnaDDn7QdeEsQrohg3I19/upMbY3TMUQEWCJFv2tsU1bldGCNMWGLRoDDjqLx CvJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gnZVZh1VIOx2Bn7nb5JDBu+SrUOXUk1VIW8AryTGMI0=; b=QYx5hI5u2DfSgl22Qe0NpeK4ieBNwVqMPIA1b+3G+GPG+A6aLLBR7+j3KVE9fLDyZE szgH40mdGoFjZwzV5z35TRWuCkMzT+qw0JwheKGQGyO9iBw6BxPxXnJch7WC7bWf8aLk QVcI2pM4+KgpIgsXpUAti+aD0eNCh8vzuL6476kQD5g84Cdoak6LZWSGohmnFntRLlff YtZEJIpkr8Wy4WGLPRZ71G8hLUqJKJm9MNlDdTwc1i+GsBcFH46C/6Je8KwZTSp85CPi snh2USOoaS3A6rPuIwriiQmoD5FMKlQrrhukIStPCDhA5df+7gJWB3ipW27WgpBacGEr AYCg== X-Gm-Message-State: AOAM532Ohreuagge2Bs2TytyYoQGLXF1+1/bOPk7LwkgP/VJn+IRITVM GIq5ZeMStfE6+I4jSm/ARPHkmyXNAY6Bkw== X-Received: by 2002:a62:3812:0:b029:13e:d13d:a062 with SMTP id f18-20020a6238120000b029013ed13da062mr1343542pfa.40.1599610618435; Tue, 08 Sep 2020 17:16:58 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id 137sm505437pfu.149.2020.09.08.17.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 17:16:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 07/43] tcg/i386: Fix dupi for avx2 32-bit hosts Date: Tue, 8 Sep 2020 17:16:11 -0700 Message-Id: <20200909001647.532249-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200909001647.532249-1-richard.henderson@linaro.org> References: <20200909001647.532249-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The previous change wrongly stated that 32-bit avx2 should have used VPBROADCASTW. But that's a 16-bit broadcast and we want a 32-bit broadcast. Fixes: 7b60ef3264e Cc: qemu-stable@nongnu.org Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc index 2f696074ab..d8797ed398 100644 --- a/tcg/i386/tcg-target.c.inc +++ b/tcg/i386/tcg-target.c.inc @@ -958,7 +958,7 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType type, new_pool_label(s, arg, R_386_PC32, s->code_ptr - 4, -4); } else { if (have_avx2) { - tcg_out_vex_modrm_pool(s, OPC_VPBROADCASTW + vex_l, ret); + tcg_out_vex_modrm_pool(s, OPC_VPBROADCASTD + vex_l, ret); } else { tcg_out_vex_modrm_pool(s, OPC_VBROADCASTSS, ret); }