From patchwork Mon Sep 7 18:04:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 249250 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp3890324ilg; Mon, 7 Sep 2020 11:05:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye/lPa2O2DaF3GT31PpaxaACUFazrixgDmvUw/FU3vo3Rwuemm730v/VUg8KWp9OyNxXJV X-Received: by 2002:a25:d846:: with SMTP id p67mr13677054ybg.250.1599501929017; Mon, 07 Sep 2020 11:05:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599501929; cv=none; d=google.com; s=arc-20160816; b=D4NRSDeCImTFCNTD8w9pMCsnEh37BlK2tI4B02EZeDKarcSFNRlhR7nU8EOPPtr36K q+M3MVSBaAsmAPZEQES4Uk9I/d2X5y0Soh8M7X1aSig4G7yo9MEFweEtGqPwaoHtlp+x hKb0hb3YbcVVc/8hvu64QSEi8RpNWj2xn5XX7b+SZ3fJDGG7WtkzIiVNIBLs7/dDdDMZ qW45fHK54t/E+m0NdZMoP/E+DE5huntLeDDU63nSlIMV44UZetgXJr39nOviDWjEouAj 991jE9YiQoHpz/DGpS8Cnt4Lquj8pajzwJktFh/hEBgZizs2mDPal5hqsDiQNQqe1aBP tE0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=lPpTfq2djWv2KtE9u88NEsXW+rPg4wV1NrdmvmqhTMc=; b=F9oq7GmB9xZ6ubp99YRk3PkSqXPGCJ4k3XI/oTIOc0WBgqvPmBBzkmSx+od+ftpYow IYLeBplQUmyax1eiNmuaCzr6opEsCCgXgBV0FgwBqPW+nO7tJTM0XOQ1IfLQ1ig6AU1f zeHvCXZ2om3fRVJ/qUymYKzWpBxcw/pAPFLTekVkzxYhJy8pfkHJ+soOoE1Qv7mZUkRH Pr9XDrzhQU06oQ+RUJXXBmALxhJ18iH/iQqKzymrMmya1wqUjRv6jkh9ytO1jZqShMy9 cd3PZQft/ld+/kVCQ0ucm8XYWMgafHeTceJ6rUbaIxL7ZvOVpizhlaDkZ3xBqy82vgeB G2RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=BQB1Zif9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e125si15480087ybh.253.2020.09.07.11.05.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Sep 2020 11:05:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=BQB1Zif9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFLWC-0003tj-GX for patch@linaro.org; Mon, 07 Sep 2020 14:05:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLVw-0003pl-Pr for qemu-devel@nongnu.org; Mon, 07 Sep 2020 14:05:12 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:33943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFLVu-0002Nb-0r for qemu-devel@nongnu.org; Mon, 07 Sep 2020 14:05:12 -0400 Received: by mail-pj1-x1036.google.com with SMTP id n3so7668781pjq.1 for ; Mon, 07 Sep 2020 11:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lPpTfq2djWv2KtE9u88NEsXW+rPg4wV1NrdmvmqhTMc=; b=BQB1Zif9FmmzTXKs59VNVu1nTiedajD+cffLaACTdrZ0H86wsjIHTg4esL2/7q5SBG r7UhPVBzsSyq6WY9FqhuHTEaDo11Ab0mwiK0nawE5VUSdCaWQeUqZT2d3dS4zJHQPmCV JD5pj7ZxaMZwMBoib3Qc2QeJUr7iTaxTG3Adu80I7sx16kRJMGHfgAz5DMMML7PKtZkD u/u1gWHof39GAMQX56RCb15o/fkbtKqxE/38OCMmhkpjfh5+PPHLHBfpER3ZFc8yxJnJ 96UgODrpcKJYk8Zu8qDlEYeuKQ3SlQi3QMjg336m2GpioonIRl3+es46jdTQw96wnnzN xLSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lPpTfq2djWv2KtE9u88NEsXW+rPg4wV1NrdmvmqhTMc=; b=eXL7yeqB3v1sTyanvfVHA9aNy7urNm7cFPgnngYjPWUfyccuGiIJWrmOdqLkbpP1en SaP0NBn7o/h8QoKpziNCIebeAUJdKb5m6EtIA7ZFUsjz0JYv3Hp+5PXHh8focHPvrEJH Kat09FB2P6unIxIhuxkFSSNsgoL29kJlOH/FJnBg/y2uO/tvhH3EbCg98BIA7OlHx/tK 6qIeRNuthGnYgs7RjptWRm9jA7sgLCFkpar3k+Z2Wjt9tUOf7OjsRpxTbZq77KbzmUzD guosHNeTjsp3O90Vvz+GYfZJLm2hlQvdZWoaZ0RTvW7v2QhzGgjjbDRNVsoQTDGk+qWq QS1g== X-Gm-Message-State: AOAM532doL+tnPONdt9LCxy22z7NA57Fm2uUjRCqqDYbQakh/eJ/qzCt SYkpvDr4js0Xu/cFmVuzDu+BoiZALyRKrw== X-Received: by 2002:a17:90a:e64e:: with SMTP id ep14mr413620pjb.173.1599501905234; Mon, 07 Sep 2020 11:05:05 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id v6sm11367768pfi.38.2020.09.07.11.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:05:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes Date: Mon, 7 Sep 2020 11:04:53 -0700 Message-Id: <20200907180459.29025-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200907180459.29025-1-richard.henderson@linaro.org> References: <20200907175102.28027-1-richard.henderson@linaro.org> <20200907180459.29025-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Sort the elements by type and size, removing a number of holes and reducing the size of the entire struct. Tested-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 59d2a079c4..4d53345f23 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -293,13 +293,22 @@ struct CPUMBState { /* * Microblaze Configuration Settings + * + * Note that the structure is sorted by type and size to minimize holes. */ typedef struct { - bool stackprot; + char *version; + uint32_t base_vectors; + uint32_t pvr_user2; + uint8_t addr_size; uint8_t use_fpu; uint8_t use_hw_mul; + uint8_t pvr_user1; + uint8_t pvr; + + bool stackprot; bool use_barrel; bool use_div; bool use_msr_instr; @@ -313,10 +322,6 @@ typedef struct { bool opcode_0_illegal; bool div_zero_exception; bool unaligned_exceptions; - uint8_t pvr_user1; - uint32_t pvr_user2; - char *version; - uint8_t pvr; } MicroBlazeCPUConfig; /**