From patchwork Mon Sep 7 17:50:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 249240 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp3881113ilg; Mon, 7 Sep 2020 10:51:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi1v6RetIOtkdA3GCuIsLW/F4+2K24xbZrOAhCL2ZeIpGTlqcl/sPsxBUHsjoBUx8YPDbL X-Received: by 2002:a25:4904:: with SMTP id w4mr31792271yba.63.1599501087250; Mon, 07 Sep 2020 10:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599501087; cv=none; d=google.com; s=arc-20160816; b=AzyYFx34TXCXco9z4gP5mRaezwjTzuXIbafEr54sJ7YGIDw/6d4YScnPho2oyD6mr9 +Chq8Fb2SrXcnSIPKBPVumwBoLXzQb/Prfz9tp5+277mqHnya/cjIzI3d4xY8GNPc2ZL fUGW50HdozN5UiNhFfU1ckn39zZLRUM0ZZ6DoHYjo1F1Jm9duteIUNHqYQm6sTXnN/r9 Hebw9Ntrn2j1BaViaHGE3OJY3cYuxuMh4fJ/kKNGBYZbZHs9bL1TUSFXhYJ5QJGhzucW CTFF9/B0Jko0zS8kvzstWW/CO8XGgWsxzonKfa+rw1F80My6akonuy8dhYfFKQeUiJtY Th8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=5SlIcFIM68w880BR4Kxx0NdCPJqMQrugFoEKlxU3Dhc=; b=ZKkXlM6dC72xK0R5BimqPivZfZKMsFImzYHj2mdGh0pJrFux1AaesUB2lXk/2YYIIU oQjeCm6CyIXjti5bOVkOmjB0F+/o+F+wr06qbq8aN/1bFXXB/N16Fj4fNlUbZX+XLdmC gsbdU/13iYUMn1HBMHQEQJDcfOJ6Kk+qPBETf4XFdNv5HQbeGAbzBQEYc4vZ/aJ6SC7l 8yWYcMa2eGIcHu1SdlrNh+AaG2zl4ILB3tyx4zbny2IU7dr6ENBuLxTwTd5eTuyMfZKB HT3x0tXXVY6vS8GyaFDBYyTKH/hq+b/1rg7+0byLP1YYX0cr68ar3BPx+wzaHbSlhUYq MXyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bjX4YVFr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r201si19855018ybc.92.2020.09.07.10.51.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Sep 2020 10:51:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bjX4YVFr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFLIc-0004v5-L4 for patch@linaro.org; Mon, 07 Sep 2020 13:51:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLIR-0004q2-0b for qemu-devel@nongnu.org; Mon, 07 Sep 2020 13:51:15 -0400 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:46822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFLIP-0000lB-Bo for qemu-devel@nongnu.org; Mon, 07 Sep 2020 13:51:14 -0400 Received: by mail-pg1-x531.google.com with SMTP id 31so8298240pgy.13 for ; Mon, 07 Sep 2020 10:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5SlIcFIM68w880BR4Kxx0NdCPJqMQrugFoEKlxU3Dhc=; b=bjX4YVFrxtUbjnPvtOS2WCIhlHxp8FEjfy6BP+O28pqXDqtnCZcQ2Yp7goNnSKP3r0 VYiWgplKRHJ4L5jXZxLGBpZwem8MXhLzrXR62ePbUy8xuJoyLKPMhCNpkVnyBhx/Ydgj s+paOadB50oSOrO5Rcqh3zRKiQO7kHMUA28NKhNDjf6VD7jQrk1qKxTrEqKjiYaTH7FW esD/QfvPbXspq1H36p7u9Pb0XyEWKMHdkWbaSCama2nHjfU20j948WOQVbskEJjtRV2a eWnM0ecLZ3Piyo1MOj1z3nFVe/PySX/DtMFnAn6trzf1muj63jkRfQB5K3YF38NoE3Pi Jn9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5SlIcFIM68w880BR4Kxx0NdCPJqMQrugFoEKlxU3Dhc=; b=X/LEJDV88TaRo9fHGob6o9lhS9BxtOVc4Q78lS17EtOOJBZ8yyKps+NMnYGBybPygH AlHrUYAmAhyjMBhHV02l1BGLZKVkfKgXKCkB/RvOhcrgQ3dy/p6gnHmplN5Zmn4bZ7un PcZM1SZcBBZtylXASbQcdPnddY2QFKLyfdWDqrhpQQkmzgrv5nBULBeGVc5eTt3XFu/I cHNMwXXbDT9URr32fY6HKZFrF5ssGXi/YzDBt87ieLsIQGQP9wzechx1O0HZ32jXLSXt u6HcxHzza80bTDgWuqbptaj3jxSCiDpk2Dgs5sWfXJ18N6o66Bv7o7HS/kdgO7FAZzxX 8ACg== X-Gm-Message-State: AOAM533ODfPCcDGdMBdG6EzGRJkT8mFotO2qj1qvQz+kCeG5nBD3sDNZ 12J2wINlfZoWmhFfwRyrsjKzWcs24kNkqg== X-Received: by 2002:a62:e108:: with SMTP id q8mr3975683pfh.214.1599501071683; Mon, 07 Sep 2020 10:51:11 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id ga3sm1651496pjb.18.2020.09.07.10.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 10:51:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 05/19] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT Date: Mon, 7 Sep 2020 10:50:48 -0700 Message-Id: <20200907175102.28027-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200907175102.28027-1-richard.henderson@linaro.org> References: <20200907175102.28027-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The name "update" suggests that something needs updating, but this is not the case. Use "exit" to emphasize that nothing needs doing except to exit. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a8a3249185..8ceb04f4f0 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -37,7 +37,7 @@ /* is_jmp field values */ #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ -#define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */ +#define DISAS_EXIT DISAS_TARGET_1 /* all cpu state modified dynamically */ static TCGv_i32 cpu_R[32]; static TCGv_i32 cpu_pc; @@ -1161,7 +1161,7 @@ static bool trans_brk(DisasContext *dc, arg_typea_br *arg) tcg_gen_ori_i32(cpu_msr, cpu_msr, MSR_BIP); tcg_gen_movi_tl(cpu_res_addr, -1); - dc->base.is_jmp = DISAS_UPDATE; + dc->base.is_jmp = DISAS_EXIT; return true; } @@ -1202,7 +1202,7 @@ static bool trans_brki(DisasContext *dc, arg_typeb_br *arg) ~(MSR_VMS | MSR_UMS | MSR_VM | MSR_UM)); } tcg_gen_ori_i32(cpu_msr, cpu_msr, msr_to_set); - dc->base.is_jmp = DISAS_UPDATE; + dc->base.is_jmp = DISAS_EXIT; #endif return true; @@ -1712,7 +1712,7 @@ static void mb_tr_translate_insn(DisasContextBase *dcb, CPUState *cs) /* Force an exit if the per-tb cpu state has changed. */ if (dc->base.is_jmp == DISAS_NEXT && dc->cpustate_changed) { - dc->base.is_jmp = DISAS_UPDATE; + dc->base.is_jmp = DISAS_EXIT; tcg_gen_movi_i32(cpu_pc, dc->base.pc_next); } } @@ -1733,7 +1733,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUState *cs) gen_goto_tb(dc, 0, dc->base.pc_next); return; - case DISAS_UPDATE: + case DISAS_EXIT: if (unlikely(cs->singlestep_enabled)) { gen_raise_exception(dc, EXCP_DEBUG); } else {