From patchwork Thu Sep 3 11:21:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 248996 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp351580ilg; Thu, 3 Sep 2020 04:25:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4izIXvXZ3M2EZMh3RFwdFkLQ4HEy8oKC8/1OSyWC1Z70hMbj5EWRELjSqMq7odq+u+lfs X-Received: by 2002:a5b:f4e:: with SMTP id y14mr2217158ybr.71.1599132312527; Thu, 03 Sep 2020 04:25:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599132312; cv=none; d=google.com; s=arc-20160816; b=j9Di8Gdnu797USebr2I2RNwch+lMRUQI3QgjT5mxlLWlvu3F3uf3duedAjh6U/Dawf LmzpKQlD3E7lbFejkHvMi4TINT7NxgMlYCGcq0LD2TcYxAfJ7vdMydqQgaRRQaQytK6J KLXAZYi4q+8mAN+dHoGGZ3OkvjNDO6t5kUKDIEf0AvnodnDtYHQpOiU8udXXmW0/Hmeb sWdfvJzGbvEX356D1zClpaUxZthj5ymuCmiel3TbgO2oLcbxJEA5K8ONXEKLRB4AQusC WsT07HwZRarlfCXcXD0hqORgiRgr7YWbVAfAV5Nn2RxYbxIWmsywuT8MLy0q4uVGyKq5 yeWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=mJNKp9y1F6rLirIyiQ2tKjhVz1svga6dJmHJIZK3pwc=; b=y0+ebZSjLUTNWDqrgytCYr4XehruvDVffMcCcetSbqIhEcBsK91R41om01FH2Tbs+l J/JenZ6sX8aX3ukyx9zUofuh5pyUTajW6TwBu3YHo19ykzIKlytuvJ8522i3wu/hhrFH bczYhvhxsWgHiiom8qJ0nYFgk14MPwO9UFfPJOqGB5hthv7o34jN3VG7afz6hW58LQaf kRzOFYL2tOnoZMeJ7VQ7uIBm261Gsnc+sUDT784Y5hhPa9DgC8qSCpFrtHxxwtzGWcbk cJUmhuLsirfdxZXcjJCu5lFlpJndYrTI1V5rZaIfs65xBKcj3Fb5RXSjAuGIg6E6PC3Q YeVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=t1aDoHg3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c186si3008183yba.330.2020.09.03.04.25.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Sep 2020 04:25:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=t1aDoHg3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDnMe-0007zv-1I for patch@linaro.org; Thu, 03 Sep 2020 07:25:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDnIw-0002dT-Af for qemu-devel@nongnu.org; Thu, 03 Sep 2020 07:21:22 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:50352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDnIt-0007a1-Td for qemu-devel@nongnu.org; Thu, 03 Sep 2020 07:21:21 -0400 Received: by mail-wm1-x342.google.com with SMTP id e17so2494405wme.0 for ; Thu, 03 Sep 2020 04:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mJNKp9y1F6rLirIyiQ2tKjhVz1svga6dJmHJIZK3pwc=; b=t1aDoHg3niacDPuDcWpr7qRaEPmYyH/SKmum2XKpJ/TVFZW7TZiEOphvFg7PiN0gni l8OfPZWnmnwCYb0jMIjLl8ouGm5y2QHldXvsPQkgHVdDyIYWVNlEyq0fInDIAJcvfErO B4HRS08UC3NvxxwRYuFiIt5bafDPrjoZrPfbwOZVmFP8/m0GGc2ptQdAjpon2cm6Jy3L 4/vWW+muyQh+FeK0iJTuEgFjvKw28DwEn/Iy662h+6jYWqRUh0jOwIw3TCOD1u0Zlwmh zTSUwtnZzOu2kCezKdsNqmPWcYBT1QHXU65ArJNtlZYU/BTPbGWTWI/EuIyxwi13BiAo m8Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mJNKp9y1F6rLirIyiQ2tKjhVz1svga6dJmHJIZK3pwc=; b=Lr631Tjekk4OPM/XWh+RA43INRebIKef7YkxNE9rmk9uJvNGFZ7BzMpjmN4lXt/WWT G9BohilfYyX/zgP5nZ4ZEOslK/wfWyLpXuJqFcLgXafPuFECAHUc7ac0VcGcj2sgRmnY f5sPkJ5GzkHy5ulv5xW7xbHCzB6mzkLz7zBUO6DPLf4Y97Yvtw6z7XpR6gG6+U1mtY2L rzJdrFVo27F0H/dHIWrb0KO3wgQyy0fq9UknGQf5EjdER393NToWmmY7ijHo9qP2PeCw ChSWiGrd+gESMK4kRwGlcmUfS3vTWu158eGNs0N0sA1djiprIY7EnVjwgaMAWzBoQQzm iBcQ== X-Gm-Message-State: AOAM530u409+jTg/BP2Tk7/TvGkpTL5Rwfl9ZDjoajbknFHWytueCOyL aII0wLqmpjlw6+EcDMHlwQhSqw== X-Received: by 2002:a1c:6a08:: with SMTP id f8mr156661wmc.151.1599132078701; Thu, 03 Sep 2020 04:21:18 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z203sm4057517wmc.31.2020.09.03.04.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 04:21:12 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 88E721FF96; Thu, 3 Sep 2020 12:21:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 8/8] migration: use pstrcpy to copy run state Date: Thu, 3 Sep 2020 12:21:07 +0100 Message-Id: <20200903112107.27367-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200903112107.27367-1-alex.bennee@linaro.org> References: <20200903112107.27367-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Juan Quintela , richard.henderson@linaro.org, f4bug@amsat.org, "Dr. David Alan Gilbert" , cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The gcov build triggered: ../../migration/global_state.c:47:5: error: ‘strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation] strncpy((char *)global_state.runstate As we shouldn't be using strncpy anyway lets use the suggested pstrcpy. Signed-off-by: Alex Bennée --- migration/global_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/migration/global_state.c b/migration/global_state.c index 25311479a4b..5fbe6d1ff07 100644 --- a/migration/global_state.c +++ b/migration/global_state.c @@ -44,8 +44,8 @@ void global_state_store_running(void) { const char *state = RunState_str(RUN_STATE_RUNNING); assert(strlen(state) < sizeof(global_state.runstate)); - strncpy((char *)global_state.runstate, - state, sizeof(global_state.runstate)); + pstrcpy((char *)global_state.runstate, sizeof(global_state.runstate), + state); } bool global_state_received(void)