From patchwork Mon Aug 31 16:05:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 248796 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp3455605ilg; Mon, 31 Aug 2020 09:25:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyREdtPrKnT7Ul6Vp1EMWEbW2cRXmfAyJTqgj+Mn4br2yk4UNno6zlpPwVNGKH7/NlKFAZ1 X-Received: by 2002:a25:5755:: with SMTP id l82mr3457399ybb.175.1598891158946; Mon, 31 Aug 2020 09:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598891158; cv=none; d=google.com; s=arc-20160816; b=fp4MFd9amlzcu3+JLdKzQaczYcDpjCa9yfFfTRlFvWT2IdvPY41v+9JGzPJKnlF0Nz A7G9e8ijTIhELaKeK0kYxHJ3OvukMVINnWU9pwa1qiMtjy66wlPObAXmScM7/P0Pf7z1 20WtOYQ98OEf1m5lWjeFcoe5VaYcOS6DSBjBrXRpqpOnURTHyryeX2/bpqrtWxnmKI8R p6BEgzajpluocFCQC/D6ITzHU8qmaPt/PskmF6PjwgPcy32+dLWdfJJKH0Oar1natzyi fzM4CF9xIT54vXsFXP9JaZkfT0a9As6Ypb0FLSmVxJkERMo+nOr9o8F5RNPd0LbB6Nif 5/Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Jni1aHgtz1xoXSckuiw7DlpTrv9tJ1hfnOPizu6DAmk=; b=lD/CzdL928elt9e5gJyYfcjk5YvLBcm+Lme1RBV2Cz2uZshysQc1ZxFZio9DePFs9f 9Qjc28/rSo3gNVqJkrGBp6+CMGJxsPm3NKZEJsp7u2WT6rkcDQBzctOygYb/R1BbPl4R QOo05ciquXSJmKx0s8/u1x0EGmWsqPB4jzAlctSIa4iJq6YcOaQKZaUMLRKszM8ny6qN kkvYFkg9A10R0nmwgAyeSbGL5QaoeOtxu4PMAu0h48ExmbHnglNYHzBCeOjYGHEHcdt3 D2QXJ/YVcVoPg4tF34p1NAqyfvqsefvPzUhI6aoSAt8ZVN8jo7TVC82pR7MBHhpOq+TW pz+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ckY9sN+W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n128si9636881ybn.175.2020.08.31.09.25.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Aug 2020 09:25:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ckY9sN+W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCmd4-0001cK-CA for patch@linaro.org; Mon, 31 Aug 2020 12:25:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCmKr-0005Vo-Tj for qemu-devel@nongnu.org; Mon, 31 Aug 2020 12:07:09 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:52760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCmKq-00064n-3N for qemu-devel@nongnu.org; Mon, 31 Aug 2020 12:07:09 -0400 Received: by mail-pj1-x1029.google.com with SMTP id o16so29089pjr.2 for ; Mon, 31 Aug 2020 09:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jni1aHgtz1xoXSckuiw7DlpTrv9tJ1hfnOPizu6DAmk=; b=ckY9sN+WUn7AlY2+rkuto/4pq/OVmB/rjI0nPhU7+NDoyvJGcyGv2ufNF+xR6v0WiW 6Oda1WzW+a8y9059m1EAw6CgMPYYg9+42YqPMMdtLd8BU41+DfOHNLSQAT3JLJDPXdF3 BbbhEzW7HWe5Djwn5s0F9ueA7aZO3GLDNiXjiegfxRH7BQmI7SJMqgUbuvikf6B7MgIS zrgNhOgKqs92wqNDE5Wvc33NVAN8F6ZnCd2xWqAqutwIjCBxIvVSc+L0N0V4TIs/ZHCn 7CfNCL+YhvQhwjrRHkfrwZiRR2TyRaVGU4oK45dURI4fR/x/dV8pgyoALsVa9xvGiaa4 OP6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jni1aHgtz1xoXSckuiw7DlpTrv9tJ1hfnOPizu6DAmk=; b=DJ8EPwjLL6q9S/HWtDg6j4eUYCbjnx5HNTrzM+qSaObFE0FTogzkSyX+XRbI0LU7W2 VIpwWM513yUWVtpjnzgj8FhDn90je2ocp8J8sH3Jnv3kXINO/18z98AT/SEKuNaxZW6S s/jjcH8TITSEXFA8KaZPhBeYPQK8dYrkYw1ggZ1pdYjZJUkYT8HyranrEJVPoulAfHBB 7uUOGXFjdvMpy0f81e09HKGSnIoUpiFBjFMKX2kLamfbvcjbefBh/FpJjkGvsWPXFOr3 2qcKBzw78koTNCmPF8RZBo5LDbCfI8tFM2u5w3Z07aXFabP29SwAW+0p5eNQpe8kEEnK xWdw== X-Gm-Message-State: AOAM531i3gm3WkpGBcpZkrMLepjn7AoO6t5Q3md9Hr6zmZ2yqskSVhZT 11lhxiMBL+iAAqHIMJgAf+k61dpmtP0g8w== X-Received: by 2002:a17:90a:5a48:: with SMTP id m8mr64011pji.181.1598890026338; Mon, 31 Aug 2020 09:07:06 -0700 (PDT) Received: from localhost.localdomain ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id gt13sm17218pjb.43.2020.08.31.09.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 09:07:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 46/76] target/microblaze: Convert dec_imm to decodetree Date: Mon, 31 Aug 2020 09:05:31 -0700 Message-Id: <20200831160601.833692-47-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200831160601.833692-1-richard.henderson@linaro.org> References: <20200831160601.833692-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Tested-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/insns.decode | 2 ++ target/microblaze/translate.c | 18 +++++++++--------- 2 files changed, 11 insertions(+), 9 deletions(-) -- 2.25.1 diff --git a/target/microblaze/insns.decode b/target/microblaze/insns.decode index 4644defbfe..ad15c16f9b 100644 --- a/target/microblaze/insns.decode +++ b/target/microblaze/insns.decode @@ -79,6 +79,8 @@ cmpu 000101 ..... ..... ..... 000 0000 0011 @typea idiv 010010 ..... ..... ..... 000 0000 0000 @typea idivu 010010 ..... ..... ..... 000 0000 0010 @typea +imm 101100 00000 00000 imm:16 + mul 010000 ..... ..... ..... 000 0000 0000 @typea mulh 010000 ..... ..... ..... 000 0000 0001 @typea mulhu 010000 ..... ..... ..... 000 0000 0011 @typea diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 964525f75e..54de136a16 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -477,6 +477,15 @@ static void gen_idivu(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) DO_TYPEA_CFG(idiv, use_div, true, gen_idiv) DO_TYPEA_CFG(idivu, use_div, true, gen_idivu) +static bool trans_imm(DisasContext *dc, arg_imm *arg) +{ + dc->ext_imm = arg->imm << 16; + tcg_gen_movi_i32(cpu_imm, dc->ext_imm); + dc->tb_flags |= IMM_FLAG; + dc->clear_imm = 0; + return true; +} + static void gen_mulh(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) { TCGv_i32 tmp = tcg_temp_new_i32(); @@ -848,14 +857,6 @@ static inline void sync_jmpstate(DisasContext *dc) } } -static void dec_imm(DisasContext *dc) -{ - dc->ext_imm = dc->imm << 16; - tcg_gen_movi_i32(cpu_imm, dc->ext_imm); - dc->tb_flags |= IMM_FLAG; - dc->clear_imm = 0; -} - static inline void compute_ldst_addr(DisasContext *dc, bool ea, TCGv t) { /* Should be set to true if r1 is used by loadstores. */ @@ -1561,7 +1562,6 @@ static struct decoder_info { } decinfo[] = { {DEC_LD, dec_load}, {DEC_ST, dec_store}, - {DEC_IMM, dec_imm}, {DEC_BR, dec_br}, {DEC_BCC, dec_bcc}, {DEC_RTS, dec_rts},