From patchwork Fri Jul 17 18:16:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 235746 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1939311ilg; Fri, 17 Jul 2020 11:17:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpX74t1SMtVbsKwX5OyGVehABKSlgeThSEQAgpZTaxLb2PJhK84i91zp+rISP+d6T3Phy+ X-Received: by 2002:a5b:3c9:: with SMTP id t9mr16763714ybp.55.1595009841676; Fri, 17 Jul 2020 11:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595009841; cv=none; d=google.com; s=arc-20160816; b=tDyBstpy+Hop6luvI4Kq4vyBK7kJWjjlT8mvsPZzMi/lpBgXtscvqj8Jei+Hb3gbIe iUxwf6LLjB7DvwAmC1vTCIhxxY5rIV30F7PhoaCGjZ36hVxPG/Vdzv7IeXguE/3KJ5Cd FQF67ZiayCtVs6cssCzIs/uXTznXp01WyvALVANzhaD0ADfjPh2aPG814Qz1i/H/KAO+ 4Mbu8Qc0VdHUoUD2iZn8JrATDLdcs0L8oQQBsmNO+wIGIAiN0/HfTR4spVNvJHzRTZV3 banboRV+m3tq20IHylnbmM5Fg6BMupZbwoXT9xb6EJufoNotu7/2OjRYJcajT8vYRHMH P8GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=MC1Zg27I6aW9OtHoxcadk7VqY6IKeakD0JIwGoHx6C3XyMtBiNXi2VyE0LxFezzvgO ZUYhX0FYft7bLVY793Ye9nNcNqzOXAB7AEbx4ppbfLWaAbauo0Q+7pzDxj8IX9PxmLI3 biJl+tXxIincJH/U2DL5h6kqHpMmlo5aYwOu4obJd88NIztLV5ocsz3Mv/3qM77z2k1+ E1usX4K5iemoKNVtdYa5HAaKhs53AkfxEzmrEcJyBeRKFX7C/3wKWVtKEQRiSKxHp4KQ tIlkEPNKd+GBRqEYiWuhSQEFCO0bX3W9jVSm/C5w5Uzq/27VrQd4rMgRpr4NuxRy7gOh fUzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QiNeEiMG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p203si9452637ybb.263.2020.07.17.11.17.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Jul 2020 11:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QiNeEiMG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwUvA-0008V5-21 for patch@linaro.org; Fri, 17 Jul 2020 14:17:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwUuO-0008T4-Ap for qemu-devel@nongnu.org; Fri, 17 Jul 2020 14:16:32 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:52907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwUuL-0003Gj-2s for qemu-devel@nongnu.org; Fri, 17 Jul 2020 14:16:30 -0400 Received: by mail-pj1-x102b.google.com with SMTP id gc9so6924495pjb.2 for ; Fri, 17 Jul 2020 11:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=QiNeEiMGpGrZ6xkpRErjKyWf1u+hT0g/Ix+B3362CKVmQqfSAzX4t+JoSwiK7rt1GI PnQ/pVwJrurcQkw7qE6YUYJxkPGuYq6jUSOTO7BHN97KKsXLG6wtcvNtLIcOoEpUlpkD om1dg+givkjG5/F1y/pt/J5o+J0VF/7hi3JnGjAx335eNbKMo1BFWmXo7b+sDEy3TfBB 03o05AQQsvklldqX5+hYmzYFkiJ2OlfP/3CiGnx6SWivmH3lYErloUydfvVUXGVoXUED oTliO4CGviN7kb0c0f92ZrxS0UzLzVph29PWK71gsYo+H1XLk3rxKOEYiUboQ3CUnbZw vT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=Wot4jBr8gf0t4Sg+4a7Xa8Qxil0/Yc1Gv7XHSSsxa5zlplL24bQMViT+9+6Yn4XBkg 8pnrAGWHp+Jnz52EMY3RgWTcvS9/DYt405s0Tf8OLLcNlLO8o2or5TjJJObR4af+gDLm 3eOZn36/Fsgxi0FMu0rjYPzMRlpKnGjO+TTc5kWA/FiT0VOd0BXw44ncbhXjyZnO/BpF rDrAfs4M1LwsjCsF6LMosremSgqUio9HKr4f8lGfKjCXqaW3zfVYHZdunUuqCPVgJtAd eCNWYvyD/Iny2vUVj5TSujJKPFGv5x7e49dKcFFBoJRmoRyMTAjUj3a4Kv/PGBEaxoQQ JYgw== X-Gm-Message-State: AOAM5327674h/nyZ8YUQ9IptIj3wziiOguWu8aBwmE+dU2UOtKb/i1dS 2ZtvgBCENi5J6DcX7Px8tjq9XJIGg/k= X-Received: by 2002:a17:902:d392:: with SMTP id e18mr8347442pld.139.1595009786311; Fri, 17 Jul 2020 11:16:26 -0700 (PDT) Received: from localhost.localdomain (216-160-65-90.tukw.qwest.net. [216.160.65.90]) by smtp.gmail.com with ESMTPSA id r7sm8698578pgu.51.2020.07.17.11.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 11:16:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-5.1 1/3] tcg: Save/restore vecop_list around minmax fallback Date: Fri, 17 Jul 2020 11:16:21 -0700 Message-Id: <20200717181623.2742758-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717181623.2742758-1-richard.henderson@linaro.org> References: <20200717181623.2742758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Forgetting this asserts when tcg_gen_cmp_vec is called from within tcg_gen_cmpsel_vec. Fixes: 72b4c792c7a Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index f784517d84..ed6fb55fe1 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -657,7 +657,9 @@ static void do_minmax(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b, TCGOpcode opc, TCGCond cond) { if (!do_op3(vece, r, a, b, opc)) { + const TCGOpcode *hold_list = tcg_swap_vecop_list(NULL); tcg_gen_cmpsel_vec(cond, vece, r, a, b, a, b); + tcg_swap_vecop_list(hold_list); } }