From patchwork Fri Jun 19 12:00:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 280003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DB6C433E0 for ; Fri, 19 Jun 2020 12:02:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 108ED2083B for ; Fri, 19 Jun 2020 12:02:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lx4KVXW4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 108ED2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmFjE-0006Fa-7e for qemu-devel@archiver.kernel.org; Fri, 19 Jun 2020 08:02:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmFhv-0004gv-S9 for qemu-devel@nongnu.org; Fri, 19 Jun 2020 08:01:19 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37495 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmFht-0006bl-VI for qemu-devel@nongnu.org; Fri, 19 Jun 2020 08:01:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592568075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2og2OIyjHIRuCRdAmqyFENbqMqlgU8vgLl7XV+/RAo=; b=Lx4KVXW4FwsxiXVFJvYhl5K+J1hc3NOjnhN9uu+fSgB8YDIfnPUuyxGjJAkUJQwdRmKkWu NG8Ccrh4qrRguSj1xhrDqZi4hkR0Xl8BM54zLyJHLUuj2tZcFvjwtApd+efeujRfvfMBb0 JiWGRjR1SeG2mKoC+ZTBw7DbTyyRkjg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-obAmtjI3PrCmhvNpkA8sSg-1; Fri, 19 Jun 2020 08:01:13 -0400 X-MC-Unique: obAmtjI3PrCmhvNpkA8sSg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24206464; Fri, 19 Jun 2020 12:01:12 +0000 (UTC) Received: from localhost (ovpn-113-212.ams2.redhat.com [10.36.113.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id A71E819D61; Fri, 19 Jun 2020 12:01:11 +0000 (UTC) From: Stefan Hajnoczi To: Coiby Xu Subject: [PATCH 3/6] vhost-user-server: adjust vhost_user_server_set_aio_context() arguments Date: Fri, 19 Jun 2020 13:00:43 +0100 Message-Id: <20200619120046.2422205-3-stefanha@redhat.com> In-Reply-To: <20200619120046.2422205-1-stefanha@redhat.com> References: <20200614183907.514282-3-coiby.xu@gmail.com> <20200619120046.2422205-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 01:50:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, bharatlkmlkvm@gmail.com, qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" vhost_user_server_set_aio_context() operates on a VuServer object. Make that the first argument of the function since it is conventional to define functions with the object they act on as the first argument. In other words, obj_action(obj, args...) is commonly used and not obj_action(arg1, ..., obj, ...). Signed-off-by: Stefan Hajnoczi --- util/vhost-user-server.h | 2 +- util/vhost-user-server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/util/vhost-user-server.h b/util/vhost-user-server.h index 5baf58f96a..584aab3da5 100644 --- a/util/vhost-user-server.h +++ b/util/vhost-user-server.h @@ -56,6 +56,6 @@ bool vhost_user_server_start(VuServer *server, void vhost_user_server_stop(VuServer *server); -void vhost_user_server_set_aio_context(AioContext *ctx, VuServer *server); +void vhost_user_server_set_aio_context(VuServer *server, AioContext *ctx); #endif /* VHOST_USER_SERVER_H */ diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index 49ada8bc78..5230ba3883 100644 --- a/util/vhost-user-server.c +++ b/util/vhost-user-server.c @@ -356,7 +356,7 @@ static void attach_context(VuServer *server, AioContext *ctx) } } -void vhost_user_server_set_aio_context(AioContext *ctx, VuServer *server) +void vhost_user_server_set_aio_context(VuServer *server, AioContext *ctx) { server->ctx = ctx ? ctx : qemu_get_aio_context(); if (!server->sioc) {