From patchwork Thu Jun 18 04:25:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 190976 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp1059861ilo; Wed, 17 Jun 2020 21:27:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzF4SMYb7aErMQE3L5s2EZi1za5UyVQh+bYpIq50xtnSxShdslEUXqlIKGKP2p4y1HiMg// X-Received: by 2002:a25:dcb:: with SMTP id 194mr3858542ybn.226.1592454475767; Wed, 17 Jun 2020 21:27:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592454475; cv=none; d=google.com; s=arc-20160816; b=dl9u7ntuSpWDnp1KCM5uUzMSmMzmfUOQUy3UssPcOBn65D693FHx8+u/fs/MeRdPSf JYGFEpLhD+q4+BO8VLIk1nWPSXizQrP/7DmgaLHH7/j/bt9WqwTZ29MJBckJKpyQn+sQ 0jp2RmbtAcf2csZTuLhnc8ZD/RpKhpMqSPx+rnqmzf+XyTTy1i8S82CEHJgsHzOzDgtF GpZFWfBHpYzVPYqo2slntcNcf3T2GHgiYVrpeHWfxuWWvt9lDsOJCXel9PoCRYUbEtLY HwWaRIZsFI4pv6gusxKLWseSrJW3r3fAo5hN1Xu+BZJU8Uy2tRDJKxWrxO+zkziHEcBn mDfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=LrAzJDXh1YjMdnSgX8aRIsN0KCc0ppLo8zaQf9vq2FO6yF0aRkx0JTpnwVhnqW+n6G KcN/PB/pSr8q3FdCB1lxZS1OyoyEMne7E8VxhpqfTYx0LYfJQJRnM0lNJ9ZoFqZloug4 y5bR523sme5m3HhK56h5kvTdetvl920mHIyKoCMji1MNi+MYZ8fkLNYkOXERnMq9LPjL J3wxQMnU8j9y2qJ+xqSQPAOLhNlfg5ea6Ex99g3ueFAxYpuH6gmYdPAdwebGV7iM5rYh a96ujtOsE9wCtfLgS7YhgmRByatHQGZccH1YLpWLnH56qhH5G5KsSNlrniNPiDv+zNir BsDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=b0FdUzGe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c6si1420784ybq.112.2020.06.17.21.27.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jun 2020 21:27:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=b0FdUzGe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlm9b-00021m-8F for patch@linaro.org; Thu, 18 Jun 2020 00:27:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlm8a-0001cU-I5 for qemu-devel@nongnu.org; Thu, 18 Jun 2020 00:26:52 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:46953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlm8X-0002F3-Jo for qemu-devel@nongnu.org; Thu, 18 Jun 2020 00:26:52 -0400 Received: by mail-pl1-x641.google.com with SMTP id n2so1892935pld.13 for ; Wed, 17 Jun 2020 21:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=b0FdUzGe3BXPetK/2aEAhuhSvJmeQUfXAHvM09IBE+4BhJZn4isVbicceHZHl7oNqj O38RBvu2d6sPxO1h7i57ia6rBHmsbCGa2XLLn9hfCrQ5jNUoW0SsmpcEojqciM4qxl1d lgOYK605ojAcIINS+KA2dDAacXZHTXCtRJvtk0L3+xI1v0Srffw9S6FOMraM6aAFNFXa D/VXjDtp1EWWyVlzIDWpen7pVrhdr4v/UG4EKa36kLM3PdOP33C4djVtum3dC2DvR0RT GAypi1tvyeVhnMBntTAypQkKrBAKeHCXYPxSJOP54YLSsDpBuGED92FYWsVBcSSjd1Lj mSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1xo/F7/aAE6h7nPyZHFzXrWII41wbW4AOQQ3nfWZDVk=; b=jw5c64AStKl7GVr22RQMzti/Ysa4Mflc1xe2hNZuB2Xm815NnpG7a3ZRwgFYFdNqpx FG/ijw1gV3xQJBcDmKRNSB67oHSrGusNmCZyDLPVBAUJn+bR/thjysrOcXFDLsdFH0Xl GtA8OHqxGZ2iy3cQ1u+w/jXxH1J51wQXnTYUkdDYCbnvFAKj/UT4ibTmdsKMrbl558dM s/EjGH/ZiOcTgs6zWmZrs9MhsSQvJWDh77iRN8LiComtVA3JH+UzNMSnzEg3FsgVAhtw fW6pZcwIXZ5f7RuzUS44lAJGBchZGmkJibTPWbrYtVDfZp3CkB2kSU77bRVFkm4zq0gp /mdw== X-Gm-Message-State: AOAM5322wYBYpgx6SA35ivuDnomWBFUXXweSNP3rjns1mIb1tj/N/rsP xWXKZvNuklAMWHxOqL9ILBgDtglZ0iY= X-Received: by 2002:a17:902:8544:: with SMTP id d4mr2187704plo.234.1592454408092; Wed, 17 Jun 2020 21:26:48 -0700 (PDT) Received: from localhost.localdomain (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id o16sm1162035pgg.57.2020.06.17.21.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 21:26:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 001/100] tcg: Save/restore vecop_list around minmax fallback Date: Wed, 17 Jun 2020 21:25:05 -0700 Message-Id: <20200618042644.1685561-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618042644.1685561-1-richard.henderson@linaro.org> References: <20200618042644.1685561-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, steplong@quicinc.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Forgetting this asserts when tcg_gen_cmp_vec is called from within tcg_gen_cmpsel_vec. Fixes: 72b4c792c7a Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index f784517d84..ed6fb55fe1 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -657,7 +657,9 @@ static void do_minmax(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b, TCGOpcode opc, TCGCond cond) { if (!do_op3(vece, r, a, b, opc)) { + const TCGOpcode *hold_list = tcg_swap_vecop_list(NULL); tcg_gen_cmpsel_vec(cond, vece, r, a, b, a, b); + tcg_swap_vecop_list(hold_list); } }