From patchwork Mon Jun 8 16:38:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281144 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C888C433E0 for ; Mon, 8 Jun 2020 16:45:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5748E204EF for ; Mon, 8 Jun 2020 16:45:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="glE71eTa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5748E204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiKtg-0004E7-Hf for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 12:45:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiKny-0003es-7r for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:39:22 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34490 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiKnx-000668-9a for qemu-devel@nongnu.org; Mon, 08 Jun 2020 12:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591634360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZewXF1iU0hhE4zzyWMCauxBy0zDRARovOReABXzSsI=; b=glE71eTaJ5qvbc53yHTWonMx46/hVw0dsKQXdl1pBrtJ88+8xY4Hn7md1KKEIFVWn1k02q gRRbim3yXe6AFHXFA68yLTsvvmQ++7I3yGC3K83kpxEi1gEZe7XldLhTS/mcyBgJsU9nQW FBOHPZw8YclZC+I/VWF9ocLFCMqX1Bw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-3b9GCuffOiGLLU5qEFUejA-1; Mon, 08 Jun 2020 12:39:14 -0400 X-MC-Unique: 3b9GCuffOiGLLU5qEFUejA-1 Received: by mail-wm1-f70.google.com with SMTP id k185so24587wme.8 for ; Mon, 08 Jun 2020 09:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LZewXF1iU0hhE4zzyWMCauxBy0zDRARovOReABXzSsI=; b=c7tZ0pfPNLrwdCZhP6r1n62bdIj/56kPrJiY8tW92QgYevBDUSY8DhUC4GEjgNsBvC b38LNtHCtG9Zn/2ERV+Epv+TpfizjHiJeBunwJ+jVmRiU460PENtxp/NnHzgJH9cpZEs jAOsP4gDT6zyP+L1RPpd7EtaPwHOpqI4UBqQfbHoHC6s3F6ungcq/NmvjjTgDbhIB5S7 AzgHjdZ7JIPBKGUGd1XRYRuwZVNa0isfJRrGhqXrnsZSpt3flc1wvfr530v+HDGJFnzF m7nc+x3ks2ShWK8a3PQbITfUy5onpK841BGr9GenMHn2pe/GlzvCsdFAgY+RyfXXGatT iEgw== X-Gm-Message-State: AOAM532R8qiF+E8kk2aGkx0ONF2Dq8CH2LwXR4wvMzf8aBfGg539FoSz GY9t/J6d7sX7dWUPsd+Ti2S5Kcl3n1TgF9WlsrN/eDE47HR9PhI4wNXPJtxcYZoxcQbLBKBMynd BE4rYYfzh3cfFfLQ= X-Received: by 2002:a1c:f003:: with SMTP id a3mr174347wmb.119.1591634352846; Mon, 08 Jun 2020 09:39:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbG1h6iWbcMBRhnrPmAzYSd8xD4FLurVE0tLUFzGMSiTZrT8R05kLYa2YmKvk30sVb6EBHxQ== X-Received: by 2002:a1c:f003:: with SMTP id a3mr174333wmb.119.1591634352686; Mon, 08 Jun 2020 09:39:12 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id s8sm250494wrm.96.2020.06.08.09.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:39:12 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v8 10/10] accel/tcg: Add stub for probe_access() Date: Mon, 8 Jun 2020 18:38:23 +0200 Message-Id: <20200608163823.8890-11-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608163823.8890-1-philmd@redhat.com> References: <20200608163823.8890-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 01:05:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Richard Henderson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a stub to avoid failures when building without TCG, such: target/arm/helper.o: In function `probe_read': include/exec/exec-all.h:362: undefined reference to `probe_access' Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- accel/stubs/tcg-stub.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index 677191a69c..e4bbf997aa 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -22,3 +22,10 @@ void tb_flush(CPUState *cpu) void tlb_set_dirty(CPUState *cpu, target_ulong vaddr) { } + +void *probe_access(CPUArchState *env, target_ulong addr, int size, + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) +{ + /* Handled by hardware accelerator. */ + g_assert_not_reached(); +}