From patchwork Thu May 28 10:10:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 187291 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp462569ilb; Thu, 28 May 2020 03:12:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOFvWSVGbf6kcBHTqMbGkakJeiFI9K37EXXXvVZOD189TmZwTkm3zL412vILZhlAO5y0bC X-Received: by 2002:aed:2291:: with SMTP id p17mr2308424qtc.295.1590660712587; Thu, 28 May 2020 03:11:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590660712; cv=none; d=google.com; s=arc-20160816; b=b8VPIy6i6V04BcXgj9BX5/g4DnIKsdxQGdoVKCwP4hijPZZt8Qz82LvnplAXQM/DBH i3yWivPlLtZ7HrrTsUUsChjwYLVOJbjVDLvyjBWVOmjKao1T3S19bkrJC5X4NOCT2gDs Ru4dQwnwmzELVDb7Nx+8wE+KfOWjhJ2fh7KvGLRxGQnmGxTr++ttmrRYmarHBrohMUQv PN8LPA7MhVw+ltv39SeHTEP/ljClBtISciaZz7U6ZMEJ+3lyGwBEloCj6Hae3Iz19vdt 6pHlpGVNXJYIdfnBrUTL9sXU65eAu2VML34bsiLVX5qeVY4Flj6pW7T0hvYqSpCEmPKV VH4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=lEOQ4vi5S+qm1E29zpIuPRDpL8RvcOrUm1/ou/Z4rkc=; b=c0/uI1vHc+ORse6AwrMOX9f+9KQXkeQJ44gkEj4Gx38tU2+eR0sOx2yfjOncOvaNyk ldJtjopgKIC3JdINSEKKQgar56EGP0fcPWpidW9M4+9UerPuM4OVR8XJfzsblXQIJWr1 iVORJiR+IlF36FJefYmlQd4UoOqv2q3Upga52snC8F0ie/0W3zGp+9LJ4Ce+9oPL274y z2D4SIwmUWtOEtWS+B7ra1JNraii50B7yuKLpuD+ylk+wBuxJqxpmgmS39vNzhMG/FBJ JbpZcbmERMNQzibsER2Ujtl7yMd/qgaeoXXMa9nZanBLEWRJNgPKSD3sbb/QwJ7e6NKn abnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=GvPHzjjO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d11si328098qtp.233.2020.05.28.03.11.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 May 2020 03:11:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=GvPHzjjO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:50998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeFVw-0000Ws-3Q for patch@linaro.org; Thu, 28 May 2020 06:11:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeFV1-0007RL-HN for qemu-devel@nongnu.org; Thu, 28 May 2020 06:10:55 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27130 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeFV0-0003H9-Jx for qemu-devel@nongnu.org; Thu, 28 May 2020 06:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590660653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lEOQ4vi5S+qm1E29zpIuPRDpL8RvcOrUm1/ou/Z4rkc=; b=GvPHzjjOZoFwHwHQXCqjPSWcZ3vmK9Y7V1uVqiorshJqz7HJmGPM+ZJ1oqmV4ifaouBQab nwlJgtH4Rke8KFh3YDq6Cn09+8cktXHi3gIfZIWQyrq+fFQ2EW8wpine+x+xR9vKEK0vvX wLT4FsPv1K6axWygVoL7DpouK/uNNYI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-e4Ih1KpEPSWZWrCr4KQvhQ-1; Thu, 28 May 2020 06:10:51 -0400 X-MC-Unique: e4Ih1KpEPSWZWrCr4KQvhQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B17F835B40; Thu, 28 May 2020 10:10:50 +0000 (UTC) Received: from thuth.com (ovpn-112-213.ams2.redhat.com [10.36.112.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31CE05D9EF; Thu, 28 May 2020 10:10:47 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 1/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS Date: Thu, 28 May 2020 12:10:33 +0200 Message-Id: <20200528101039.24600-2-thuth@redhat.com> In-Reply-To: <20200528101039.24600-1-thuth@redhat.com> References: <20200528101039.24600-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 03:11:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée Newer clangs rightly spot that you can never exceed the full address space of 64 bit hosts with: linux-user/elfload.c:2076:41: error: result of comparison 'unsigned long' > 18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare] 4685 if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { 4686 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ 4687 1 error generated. So lets limit the check to 32 bit hosts only. Fixes: ee94743034bf Reported-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20200525131823.715-8-thuth@redhat.com> [thuth: Use HOST_LONG_BITS < TARGET_ABI_BITS instead of HOST_LONG_BITS == 32] Signed-off-by: Thomas Huth --- linux-user/elfload.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.18.1 diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 01a9323a63..ebc663ea0b 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2073,12 +2073,14 @@ static void pgb_have_guest_base(const char *image_name, abi_ulong guest_loaddr, exit(EXIT_FAILURE); } } else { +#if HOST_LONG_BITS < TARGET_ABI_BITS if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { error_report("%s: requires more virtual address space " "than the host can provide (0x%" PRIx64 ")", image_name, (uint64_t)guest_hiaddr - guest_base); exit(EXIT_FAILURE); } +#endif } /*