From patchwork Wed May 27 14:54:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 187277 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp1193076ilb; Wed, 27 May 2020 07:57:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpl0U64eGYFURYcqi4tJY52g+TU0MhD473OvW1m/61RMs61KIEbcURwKJQDJ6NbfpfqWgZ X-Received: by 2002:ac8:bc4:: with SMTP id p4mr4684923qti.72.1590591449691; Wed, 27 May 2020 07:57:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590591449; cv=none; d=google.com; s=arc-20160816; b=Sc096ykzjBLcFk9ty8cch3xrJ/iQmJBwjDkiZz0TE8tS/nwa371Bxuu0CCFGUv4GLd zAY0taCfYE/prrb+tqQn27CcR/61210reE3ckyqbGYDm3RnaN29by0Yl9JhfIjFg5zZT iYgvybkm4/SwZznFCMRndmMFOujH8UpkzcTD3EWHnwKTnjTVo44gTBpvm1A4fQcgDASJ JWK2gV1JsOFhtWiE/FeVpuhT/TLRLA0vfDm3WuxRJHAP9mSlQFsomlog/7e2NH0SN2+r d9UYXhv2GfA8zUqsHO8gEj8lSh5oXWmnQUAwbx0c5XyTeiIyj6ccVunMsWJNhVaEXbj8 RGiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=QvhGNTeRA8q78PxbK23cSE9XvqC4pZ+Nj6yuRj0xIqM=; b=voNlKJegXRwx8gjOxTxPsTWHO+Dki7qmbO6/L1nJtY6oA9/iXtXEWyrTsvrmBPXet1 C6A9ZWwdfUvUKmaB0kUGO0kkXrn85BtzYJ98rGIXF475YZT4pHyQQpmDv+7lU5K3fZFw R6XE4oleTIovlpnoGYLVSVqCkcmCU4tSUd+N7f+G2HUKoc+OLyRi4wmfsFQMBlNSqji6 e237gdYnFMKtssA+xmDdo/9dtvUMMBsN/swGMWGfYFYMv3gCliMRpfj7ehZHNoeCmVcd 0iF1AI1uvPTHGFWI/Q4ba2Rt3dqvo/Jk0ugTcVLRFCMb5qrJGMrV31y+qv86Uli6ls2d vFQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=c0rAkQ25; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y5si22501qvj.146.2020.05.27.07.57.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 May 2020 07:57:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=c0rAkQ25; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdxUn-0005wL-6K for patch@linaro.org; Wed, 27 May 2020 10:57:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdxSV-0001oo-Dq for qemu-devel@nongnu.org; Wed, 27 May 2020 10:55:07 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:37084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdxSU-000899-1p for qemu-devel@nongnu.org; Wed, 27 May 2020 10:55:07 -0400 Received: by mail-wm1-x334.google.com with SMTP id f5so3334963wmh.2 for ; Wed, 27 May 2020 07:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QvhGNTeRA8q78PxbK23cSE9XvqC4pZ+Nj6yuRj0xIqM=; b=c0rAkQ25bQMBk/E31Bg12O8rDqZwfBdYiMvt4incWMn/iOIhs7+cRub9+gW9Gezl+T OEheBLqKRZZK+b8q+/ZQTdglYAZ1hn11YlcGPp0FcF1iIBEqSvx2J9GOrhfJljVfxB22 WBInBC91cJG4y4n78mbpOMCm4QMFGebEM7wEZBYiUtQXxv01Ch/tZVA8WGv9WkASxo6e 8YdI/mdHv0HXDTHMAh7I8/a+XFyiCS6jsitVJVZU+xg97fogPjWXAKl7SLl1IQYbPvzk DEcgl9Gn2hQ77QW60c2bvV3Hg8ZgDNf00xkS/i67FDs2s1zS1Ct9cX4+7Q8vhepIGCAS Wfkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QvhGNTeRA8q78PxbK23cSE9XvqC4pZ+Nj6yuRj0xIqM=; b=KFTM2U25KSBWmUlbMdiRRmrm1iaiUh31tCGhk9oUTL/flDYKuhGleuY5umPYEnEIqK wYdSP5wR+d57M8jEqVeG1O9Xsaojx1BsBRaUeiSXBKwoaQqE14cTB3TxNm7uHsn8JHcB vPRIocxXxJ0fw4ZasHBe1dLST6aMn907pKMCwt4kVj3QJSSNi5JpwBOZy6AsIz/rNcSM ZEdKRdCFUxnrCm97Z4oB2PB5e4Kx6h2lzQ5Cu0LoyYNuyXDy2llhblmIlRRSFzX1Htnp 7lHFY6GE730fIoYAxJqP9YkaP0klvbBHQqy9DbJDEbAX2+tq4xA8iafnb250s7sFdBLK PxAA== X-Gm-Message-State: AOAM532eTqsvwx/madQtdYrFHSBv/MFD2oXnreh2xSXXHD3BSmU/AjLY SResbL4AIfY1D8ljjnW8+H2pfLympkA= X-Received: by 2002:a7b:c7d8:: with SMTP id z24mr4456676wmk.28.1590591304616; Wed, 27 May 2020 07:55:04 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 23sm2862954wmg.10.2020.05.27.07.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 07:54:58 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9743D1FF92; Wed, 27 May 2020 15:54:56 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 06/12] tests/fp: split and audit the conversion tests Date: Wed, 27 May 2020 15:54:49 +0100 Message-Id: <20200527145455.2550-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200527145455.2550-1-alex.bennee@linaro.org> References: <20200527145455.2550-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Split the float conversion tests into separate groups and audit the tests to check what is still broken. I was able to enable a bunch of tests that had been missed before: all the float to float conversions ui32_to_extF80 ui64_to_extF80 extF80_to_ui32 extF80_to_ui32_r_minMag extF80_to_ui64 extF80_to_ui64_r_minMag Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200520140541.30256-7-alex.bennee@linaro.org> -- 2.20.1 diff --git a/tests/Makefile.include b/tests/Makefile.include index e6d87fcbf0e..a00ccc94b8b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -687,11 +687,26 @@ test-softfloat = $(call quiet-command, \ (cat $2.out && exit 1;), \ "FLOAT TEST", $2) -# Conversion Routines: +# Conversion Routines: Float to Float +# FIXME: f32_to_f128 (broken), f64_to_f128 (broken) +# FIXME: f128_to_f32(broken), f128_to_f64 (broken) +# FIXME: f128_to_extF80 (broken) +check-softfloat-conv-f2f: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_to_f32 f16_to_f64 \ + f16_to_extF80 f16_to_f128 \ + f32_to_f16 f32_to_f64 \ + f32_to_extF80 \ + f64_to_f16 f64_to_f32 \ + extF80_to_f16 extF80_to_f32 \ + extF80_to_f64 extF80_to_f128 \ + f128_to_f16, \ + float-to-float) + +# Conversion Routines: Int and Uint to Float # FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken) -# ui32_to_f128 (not implemented), extF80_roundToInt (broken) -# -check-softfloat-conv: $(FP_TEST_BIN) +# ui32_to_f128 (not implemented) +check-softfloat-conv-to-float: $(FP_TEST_BIN) $(call test-softfloat, \ i32_to_f16 i64_to_f16 \ i32_to_f32 i64_to_f32 \ @@ -701,7 +716,12 @@ check-softfloat-conv: $(FP_TEST_BIN) ui32_to_f16 ui64_to_f16 \ ui32_to_f32 ui64_to_f32 \ ui32_to_f64 ui64_to_f64 \ + ui32_to_extF80 ui64_to_extF80 \ ui64_to_f128, uint-to-float) + +# Conversion Routines: Float to integers +# FIXME: extF80_roundToInt (broken) +check-softfloat-conv-to-int: $(FP_TEST_BIN) $(call test-softfloat, \ f16_to_i32 f16_to_i32_r_minMag \ f32_to_i32 f32_to_i32_r_minMag \ @@ -718,10 +738,12 @@ check-softfloat-conv: $(FP_TEST_BIN) f16_to_ui32 f16_to_ui32_r_minMag \ f32_to_ui32 f32_to_ui32_r_minMag \ f64_to_ui32 f64_to_ui32_r_minMag \ + extF80_to_ui32 extF80_to_ui32_r_minMag \ f128_to_ui32 f128_to_ui32_r_minMag \ f16_to_ui64 f16_to_ui64_r_minMag \ f32_to_ui64 f32_to_ui64_r_minMag \ f64_to_ui64 f64_to_ui64_r_minMag \ + extF80_to_ui64 extF80_to_ui64_r_minMag \ f128_to_ui64 f128_to_ui64_r_minMag, \ float-to-uint) $(call test-softfloat, \ @@ -729,9 +751,14 @@ check-softfloat-conv: $(FP_TEST_BIN) f64_roundToInt f128_roundToInt, \ round-to-integer) +.PHONY: check-softfloat-conv +check-softfloat-conv: check-softfloat-conv-f2f +check-softfloat-conv: check-softfloat-conv-to-float +check-softfloat-conv: check-softfloat-conv-to-int + # Generic rule for all float operations # -# Some patterns are overidden due to broken or missing tests. +# Some patterns are overridden due to broken or missing tests. # Hopefully these can be removed over time. check-softfloat-%: $(FP_TEST_BIN)