From patchwork Mon May 25 13:18:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 187192 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp4934736ilb; Mon, 25 May 2020 06:22:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxydr9gpKD2nLxT1qSaYwi+IvbTxahFSQEvyyGJQb/vcSU3PjzJxhdqPZ6AGV38TztIqo0M X-Received: by 2002:ac8:710f:: with SMTP id z15mr27685533qto.71.1590412954005; Mon, 25 May 2020 06:22:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590412954; cv=none; d=google.com; s=arc-20160816; b=TY/9P4wgrciPSnFDS+DXncQUcZIfIzaeqQzE9EV3lenwiuCYoEC1xo458Zu8FFo3af eJ1Ye4HO6PSUiOF2XwMRPMIGnc9HtiedCbcvyFwzhyxc/J5hiLek3qjPsmiAKGPo2MJU SGo2kPN7VmXOCDZEGhTMlFWNTyHDUuMhyd3O7uEUsBmTh3oOhBV1Z9TDv6Z0vqGlfb8/ dUIG7fvwWl3ifJIco6WWBsWi7+ouDNbmiDdSyJGIsQYG4hudcL/nUWPW0+nVoZS9NNui tIQekUPLGWqfhgEh1MDO1tGb1ebgbK6GkLCBsKohE9Ojr6YdvqUpEo6H8WWQCWcAswe7 vOhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=DCBU4j2MIhZhR5KcbCBBG5w3YJzLpA2F7BOou67Bf0k=; b=f8QZ2IJxhOMDo4UX4DEpo/I5u2tjqPTHfgeoCSbOeFsZyTNYvaBxi1jxfH3VtaD9Ev TTpWKvE1uKIc8CVZirQ537kLD5XHdQnD/3/KK7mSyjLdU/5FMEH/vHdxbGCSjDtxgONl D0tZdDUAx3mcBvPXm3P9wkivIcAqMm6WreK2POr90cVZmpA6gNOFB1vh0a+NNLPH02nT hCD1Ns3En+sl9S5+m+CLYUhHS77QfNySq1UW2tstP8+IH3ozddzmlln86f4wbmh7Hba+ WtcohNwvQtf0ku68kLu86JNzJlHN3iB276uS3ouskjUbap9t9J0Ofo0sgs/OqcDpuOTZ ZVxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=VYtTmsun; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n133si6435741qke.69.2020.05.25.06.22.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 May 2020 06:22:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=VYtTmsun; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:47392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdD3p-0001WT-IU for patch@linaro.org; Mon, 25 May 2020 09:22:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdD0m-0004gN-0K for qemu-devel@nongnu.org; Mon, 25 May 2020 09:19:24 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50156 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdD0l-0004EP-5F for qemu-devel@nongnu.org; Mon, 25 May 2020 09:19:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590412762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCBU4j2MIhZhR5KcbCBBG5w3YJzLpA2F7BOou67Bf0k=; b=VYtTmsunbVTrMYazH1iWi6XGmWU7Glo1aXuXhyjYV5Uo5q463wNFQvzwwX5rQgvsuirkFX wWAlKTYp+MObZ7CxH6yCq2xIrLTDSTqtkyFW7Ffd+RVt9BMNhrLxxkzM2Ugb1njWV2QyRs nOJOtTilg1RNR/Bj6R75LRzL73FnwzE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-ZkIzW4LHPSeHvr8vwjDqlQ-1; Mon, 25 May 2020 09:19:20 -0400 X-MC-Unique: ZkIzW4LHPSeHvr8vwjDqlQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67B65107ACCA; Mon, 25 May 2020 13:19:19 +0000 (UTC) Received: from thuth.com (ovpn-113-78.ams2.redhat.com [10.36.113.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53E105C1BB; Mon, 25 May 2020 13:19:09 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Subject: [PATCH 7/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS Date: Mon, 25 May 2020 15:18:23 +0200 Message-Id: <20200525131823.715-8-thuth@redhat.com> In-Reply-To: <20200525131823.715-1-thuth@redhat.com> References: <20200525131823.715-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/25 06:55:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée Newer clangs rightly spot that you can never exceed the full address space of 64 bit hosts with: linux-user/elfload.c:2076:41: error: result of comparison 'unsigned long' > 18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare] 4685 if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { 4686 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ 4687 1 error generated. So lets limit the check to 32 bit hosts only. Fixes: ee94743034bf Reported-by: Thomas Huth Signed-off-by: Alex Bennée [thuth: Use HOST_LONG_BITS < TARGET_ABI_BITS instead of HOST_LONG_BITS == 32] Signed-off-by: Thomas Huth --- linux-user/elfload.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.18.1 diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 01a9323a63..ebc663ea0b 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2073,12 +2073,14 @@ static void pgb_have_guest_base(const char *image_name, abi_ulong guest_loaddr, exit(EXIT_FAILURE); } } else { +#if HOST_LONG_BITS < TARGET_ABI_BITS if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { error_report("%s: requires more virtual address space " "than the host can provide (0x%" PRIx64 ")", image_name, (uint64_t)guest_hiaddr - guest_base); exit(EXIT_FAILURE); } +#endif } /*