From patchwork Wed May 13 16:32:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 186649 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp614749ilb; Wed, 13 May 2020 09:35:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkNkKcMNtmTmRZ9jX44+dxspQlrpiTQ/38ff/k03jzuh2xvtUOAW8N8ByDvcUt9clQ8zqb X-Received: by 2002:a05:6214:8e9:: with SMTP id dr9mr532496qvb.84.1589387731212; Wed, 13 May 2020 09:35:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589387731; cv=none; d=google.com; s=arc-20160816; b=RvL4d5BCfCH276MUf3iFQNPWccwLZSuvtYnZ9Nz9SgW7iyOboLJp5Y61L0OoXDKUnk byIOMUyYfXKF19FZkIeaOubBCMcGR/CBPEfLubHBgjy6NRpsyH/VyypgpNaW/v0Xm/dS fq0EE1z2X9hdpgBm4QYxVia/qWHdYD8SXa4dumSGsGyGYgbdI9Z7iAKeiV1RROdDQvnw FCn2KWbHB3ksuOrnLDH97bjgEOx4M18k48IUFfjXp7h70tsEximGJfqn+Fg4B1IPXToU w746VoCJ6mrtpjTEBM6zr6TFEtE7osIiWFxrU1hU4BUZxansSApnDFOSZsxKZ8W4qXMB kqrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=NLb4rJjMwiMsLgfx7HOV1muKPW0Fe0mWL0pQOnLqixs=; b=oG2vG2fYFc4BTerv8DasvAcHqe/p4ys9GWG9zLsGyAA7hnkwfFWYMG3KxOUCGWv4DU C6JQnvumUNeT/NoZvFLQHP+/scn4uJpUoli9r2L2lFc48+H6rxDj0mtP3+vX3wOp1KEM Qy6BwixzLaL8ZVzoCXCDYW5/scabazZzb/ikYtmqLkBYpgsJfGnu5i71L7yxckm2jHAS 26Y2Vd3KHwjp6/CNiJarkzMeRxncI9L5aJCRqaRxAZw6RqOQYQphe++ibdabn1P2CyHr PCBHifX4plao9os/8Qb8PFF4ub2KwcNnIJiF5UpEwcK13j+CZBGdzwPPtlcK8Ju9eRAm EWdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NkNaAgio; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v8si151294qtp.311.2020.05.13.09.35.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 May 2020 09:35:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NkNaAgio; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYuLy-0004mP-KO for patch@linaro.org; Wed, 13 May 2020 12:35:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYuJd-0003kz-H4 for qemu-devel@nongnu.org; Wed, 13 May 2020 12:33:05 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:39570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYuJb-00022u-Pz for qemu-devel@nongnu.org; Wed, 13 May 2020 12:33:05 -0400 Received: by mail-pj1-x1033.google.com with SMTP id e6so11215716pjt.4 for ; Wed, 13 May 2020 09:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NLb4rJjMwiMsLgfx7HOV1muKPW0Fe0mWL0pQOnLqixs=; b=NkNaAgio82eDYKGidh/r6DIupdurwkx5r0sGeI4ArSShWcmRGwUn+Dwggugz0zm3ll Cd/OwvEARRuDLGIk+ECRooxJdqYp773SvmSf8IJm+7STjs7EE6D8NDDIRg/7RUBNfe5q MVz+rdMyRwyh1UU0uzqEKDphrFRw0TGFpaH2PxFoAj3gsTTspLPthpr2Jj9dAsowdHuK dTE1miExlgD0gI1nJaE2Of2qk6K1zUAl8ikiaFEcqWiBciLTlYLj2JxfxyDwChSThirX y/QwkSu5s5DXW2wcC5TgDYL+pDapC3+mz5LKryzTAmnYDOUxnguqMKK+LpBQIuTHgMc8 Cp1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NLb4rJjMwiMsLgfx7HOV1muKPW0Fe0mWL0pQOnLqixs=; b=sgveRowXBzsGP17IMN6JZ52qkv/vhNR2okY4TNmnrZWp+HjfLwAHEaFP9FqModiAU3 TMSwzQzNjjovy+KyPatCyw9ithU6VrbaZTB4tInG+oCi4hPlWTVJgOb7DmzNbgtpxngF CU9yJy976HqZlOzw51OFSYoF9F92IAcp7Lz02FqyvDkNtxRLbs3CQLp4wlzlHggKil1a CCCKlBcFRKxBEWXWUEQdzFwhEKMmXaCmwyDklkxPL2mBpMqen5HGFsOLi+C2SCu9fEgW WewH6zwfUp4UnEqMbF4ltqgANtH7q8A0fUmlQhZPIxGXmlExMpSB5+BXa1gIilgp/gs0 eiWw== X-Gm-Message-State: AGi0PuZZdOqXgf8f3XTawrSkLVtjzahzolOLJs+PZ9QaPny9n3fXtKyN AzHa6fB9hP3NPHhFBqWlj1myZ+OqZnM= X-Received: by 2002:a17:90a:154e:: with SMTP id y14mr36596197pja.180.1589387581810; Wed, 13 May 2020 09:33:01 -0700 (PDT) Received: from localhost.localdomain (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id b11sm158025pgq.50.2020.05.13.09.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2020 09:33:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 11/16] target/arm: Remove fp_status from helper_{recpe, rsqrte}_u32 Date: Wed, 13 May 2020 09:32:40 -0700 Message-Id: <20200513163245.17915-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200513163245.17915-1-richard.henderson@linaro.org> References: <20200513163245.17915-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These operations do not touch fp_status. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.h | 4 ++-- target/arm/translate-a64.c | 5 ++--- target/arm/translate.c | 12 ++---------- target/arm/vfp_helper.c | 5 ++--- 4 files changed, 8 insertions(+), 18 deletions(-) -- 2.20.1 diff --git a/target/arm/helper.h b/target/arm/helper.h index 33c76192d2..aed3050965 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -211,8 +211,8 @@ DEF_HELPER_FLAGS_2(recpe_f64, TCG_CALL_NO_RWG, f64, f64, ptr) DEF_HELPER_FLAGS_2(rsqrte_f16, TCG_CALL_NO_RWG, f16, f16, ptr) DEF_HELPER_FLAGS_2(rsqrte_f32, TCG_CALL_NO_RWG, f32, f32, ptr) DEF_HELPER_FLAGS_2(rsqrte_f64, TCG_CALL_NO_RWG, f64, f64, ptr) -DEF_HELPER_2(recpe_u32, i32, i32, ptr) -DEF_HELPER_FLAGS_2(rsqrte_u32, TCG_CALL_NO_RWG, i32, i32, ptr) +DEF_HELPER_FLAGS_1(recpe_u32, TCG_CALL_NO_RWG, i32, i32) +DEF_HELPER_FLAGS_1(rsqrte_u32, TCG_CALL_NO_RWG, i32, i32) DEF_HELPER_FLAGS_4(neon_tbl, TCG_CALL_NO_RWG, i32, i32, i32, ptr, i32) DEF_HELPER_3(shl_cc, i32, env, i32, i32) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ea5f6ceadc..367fa403ae 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -9699,7 +9699,7 @@ static void handle_2misc_reciprocal(DisasContext *s, int opcode, switch (opcode) { case 0x3c: /* URECPE */ - gen_helper_recpe_u32(tcg_res, tcg_op, fpst); + gen_helper_recpe_u32(tcg_res, tcg_op); break; case 0x3d: /* FRECPE */ gen_helper_recpe_f32(tcg_res, tcg_op, fpst); @@ -12244,7 +12244,6 @@ static void disas_simd_two_reg_misc(DisasContext *s, uint32_t insn) unallocated_encoding(s); return; } - need_fpstatus = true; break; case 0x1e: /* FRINT32Z */ case 0x1f: /* FRINT64Z */ @@ -12412,7 +12411,7 @@ static void disas_simd_two_reg_misc(DisasContext *s, uint32_t insn) gen_helper_rints_exact(tcg_res, tcg_op, tcg_fpstatus); break; case 0x7c: /* URSQRTE */ - gen_helper_rsqrte_u32(tcg_res, tcg_op, tcg_fpstatus); + gen_helper_rsqrte_u32(tcg_res, tcg_op); break; case 0x1e: /* FRINT32Z */ case 0x5e: /* FRINT32X */ diff --git a/target/arm/translate.c b/target/arm/translate.c index 7eb30cde60..391a09b439 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6875,19 +6875,11 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) break; } case NEON_2RM_VRECPE: - { - TCGv_ptr fpstatus = get_fpstatus_ptr(1); - gen_helper_recpe_u32(tmp, tmp, fpstatus); - tcg_temp_free_ptr(fpstatus); + gen_helper_recpe_u32(tmp, tmp); break; - } case NEON_2RM_VRSQRTE: - { - TCGv_ptr fpstatus = get_fpstatus_ptr(1); - gen_helper_rsqrte_u32(tmp, tmp, fpstatus); - tcg_temp_free_ptr(fpstatus); + gen_helper_rsqrte_u32(tmp, tmp); break; - } case NEON_2RM_VRECPE_F: { TCGv_ptr fpstatus = get_fpstatus_ptr(1); diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index 930d6e747f..ec007fce25 100644 --- a/target/arm/vfp_helper.c +++ b/target/arm/vfp_helper.c @@ -1023,9 +1023,8 @@ float64 HELPER(rsqrte_f64)(float64 input, void *fpstp) return make_float64(val); } -uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp) +uint32_t HELPER(recpe_u32)(uint32_t a) { - /* float_status *s = fpstp; */ int input, estimate; if ((a & 0x80000000) == 0) { @@ -1038,7 +1037,7 @@ uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp) return deposit32(0, (32 - 9), 9, estimate); } -uint32_t HELPER(rsqrte_u32)(uint32_t a, void *fpstp) +uint32_t HELPER(rsqrte_u32)(uint32_t a) { int estimate;