From patchwork Sat May 2 22:44:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 186074 Delivered-To: patch@linaro.org Received: by 2002:a92:3d9a:0:0:0:0:0 with SMTP id k26csp2288304ilf; Sat, 2 May 2020 15:52:44 -0700 (PDT) X-Google-Smtp-Source: APiQypJfSjy54s6IGL4ne94O+Z+V9/OSugOn+Tv2zKkfohMf8iPhaibIGvdGEnqMbQc9EmlTLdT3 X-Received: by 2002:a37:9645:: with SMTP id y66mr9730503qkd.278.1588459964311; Sat, 02 May 2020 15:52:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588459964; cv=none; d=google.com; s=arc-20160816; b=yVhukGUR2PJ4lUp73L6cRUtKnhW54JaGYdl2QUAoV+57qsBEL7ySSiew+v8hlmbeVT hHSNK4JHUXkoK/1r/pJ0y7Z3zwC5IJCBjtBfbL3Dosq4oyU+u/u5KQojjjhemX5OkmVM z5I7LXz2pRJbFbIz/B6l+R2V8XeS7nxTjP6Uj+PEjfrSTWuucN5vzfvoTsixR5XNdxXU TJA3DfqCGNpSPeaC1bT9f9T3vUl+TR1chY3SFigk6cdEoT/zy0oS0DcqNLlBPq+zx6Jj OZnqIGSAh6mM3MEF/0ia8cfN5++uYMT5ViRrDYjmtOQ/HvhgFc876QsRFwv+MAOX+Ihk 0EDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=VEa8/NpiWarpCAFc/pG+GmiGCs6Kk+JgIooeJUPrPpQ=; b=sOnHuKW6cqDY7j7Ti/TGMidRlb0XmnUh98BQeeiGxskIqg2sDU7sA5Tnh2BdfXCpJN awu/fNRw8J9QG/BFMxuYUdiGH9U0fWFLMfdXrzaiwFvBxph4ZHiysbkqYn5y5GoWAQ8U Bn/OyHMA6rdmD/0a0D8XbaVH2DsPd+S3FBLDADTeSLKwxKv7P9BL6jcCV5JAt19H6ZY9 QrME8A8uG/X5LS89P55njQnMiIWVUQB1Qcdh/d7wyEkSflgrNdoA2OJbJOZD+Vrzjjjy ygeZ4cYGgxeN+oE4KCUBpdroMsbBmDV9ZUoEAFtndPfxhplifWxfW7AJMmIzJv0ahES8 6BAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=q3nZdk4j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:470:142::17]) by mx.google.com with ESMTPS id 192si419778qkm.40.2020.05.02.15.52.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 May 2020 15:52:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:470:142::17 as permitted sender) client-ip=2001:470:142::17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=q3nZdk4j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jV0zz-0008Nh-Sj for patch@linaro.org; Sat, 02 May 2020 18:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jV0ss-0003GS-85 for qemu-devel@nongnu.org; Sat, 02 May 2020 18:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jV0sr-0004k5-4w for qemu-devel@nongnu.org; Sat, 02 May 2020 18:45:21 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:43074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jV0sq-0004jn-Dz for qemu-devel@nongnu.org; Sat, 02 May 2020 18:45:20 -0400 Received: by mail-pf1-x42a.google.com with SMTP id v63so3530532pfb.10 for ; Sat, 02 May 2020 15:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VEa8/NpiWarpCAFc/pG+GmiGCs6Kk+JgIooeJUPrPpQ=; b=q3nZdk4jfh59jQCCFRlwN4SYs/oRjr5cSufqk8QzQhppB271N1pQ52/YgKuuqa4HP7 aYBVPMQwIo9TdjHyRjEq39r3GkdIEJQdx3Rf9drAD/V9W08MdL0Eh8ddAeu8ZQX14AzA o/MDAzAOdHeOGtuR8mA+RGHK/dkysPlV4XZ8gek8JZed2DyTuVhiGZJh5LCC7Bk6RdBk uUAJDpdFZXiVO6zT5ATdER+DSOEKH2YTFGQBDhA5Z6D7qSZyT6ITrEycCWAr88Ln71bz z3qeaHoti5GQd0S3zGrxX0JJpmlkyoXU7rQwxtYxkMqG8NuJ5rCopcaVPc8b1Y/oJ9sv dHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VEa8/NpiWarpCAFc/pG+GmiGCs6Kk+JgIooeJUPrPpQ=; b=A74PT6yxJZf3SDQbOmIBHKCu6OrL+7YPjjT7vigitvAVuoBIodVrPZHGTyMc2nlufP F54PaMpgzS6McRb6Ep+UnTayfSiBehj+yN8wLs8qO3y8XgwK3RCslBC6FzV6nxoFswVK 1DhfaqTpQAus8F7E1Vh6lbYvqlaRCDNkV+iNjtbk3CyiEkcRpov5My3ZzmyLpyd+2Ds1 pT8imJDA0q97JoaoLd3adL36/v3jkJHK18b6MHhTbsj4h2oyaVNHG+tjfLdvoqy1jmD3 84qROKkxbA8wkMjGxmZFfqrmFbuUn9qkfinkrdyo/8yLq4McC29rDcEhXff2q4B+B40k vqvA== X-Gm-Message-State: AGi0PuZOTM4rYqOOvuM+tDA9ftbGn1+1cfiPq4cl40JfVYDd5H0j5312 8KxxlzDdr9vMX7bYydzQLp1TKuiTmJc= X-Received: by 2002:aa7:8eca:: with SMTP id b10mr10573920pfr.4.1588459518699; Sat, 02 May 2020 15:45:18 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id h5sm2956182pjv.4.2020.05.02.15.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2020 15:45:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 10/15] target/arm: Remove fp_status from helper_{recpe, rsqrte}_u32 Date: Sat, 2 May 2020 15:44:58 -0700 Message-Id: <20200502224503.2282-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200502224503.2282-1-richard.henderson@linaro.org> References: <20200502224503.2282-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::42a X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These operations do not touch fp_status. Signed-off-by: Richard Henderson --- target/arm/helper.h | 4 ++-- target/arm/translate-a64.c | 5 ++--- target/arm/translate.c | 12 ++---------- target/arm/vfp_helper.c | 4 ++-- 4 files changed, 8 insertions(+), 17 deletions(-) -- 2.20.1 diff --git a/target/arm/helper.h b/target/arm/helper.h index 33c76192d2..aed3050965 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -211,8 +211,8 @@ DEF_HELPER_FLAGS_2(recpe_f64, TCG_CALL_NO_RWG, f64, f64, ptr) DEF_HELPER_FLAGS_2(rsqrte_f16, TCG_CALL_NO_RWG, f16, f16, ptr) DEF_HELPER_FLAGS_2(rsqrte_f32, TCG_CALL_NO_RWG, f32, f32, ptr) DEF_HELPER_FLAGS_2(rsqrte_f64, TCG_CALL_NO_RWG, f64, f64, ptr) -DEF_HELPER_2(recpe_u32, i32, i32, ptr) -DEF_HELPER_FLAGS_2(rsqrte_u32, TCG_CALL_NO_RWG, i32, i32, ptr) +DEF_HELPER_FLAGS_1(recpe_u32, TCG_CALL_NO_RWG, i32, i32) +DEF_HELPER_FLAGS_1(rsqrte_u32, TCG_CALL_NO_RWG, i32, i32) DEF_HELPER_FLAGS_4(neon_tbl, TCG_CALL_NO_RWG, i32, i32, i32, ptr, i32) DEF_HELPER_3(shl_cc, i32, env, i32, i32) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index eeaa92b9f1..4d5cdcef2f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -9716,7 +9716,7 @@ static void handle_2misc_reciprocal(DisasContext *s, int opcode, switch (opcode) { case 0x3c: /* URECPE */ - gen_helper_recpe_u32(tcg_res, tcg_op, fpst); + gen_helper_recpe_u32(tcg_res, tcg_op); break; case 0x3d: /* FRECPE */ gen_helper_recpe_f32(tcg_res, tcg_op, fpst); @@ -12261,7 +12261,6 @@ static void disas_simd_two_reg_misc(DisasContext *s, uint32_t insn) unallocated_encoding(s); return; } - need_fpstatus = true; break; case 0x1e: /* FRINT32Z */ case 0x1f: /* FRINT64Z */ @@ -12429,7 +12428,7 @@ static void disas_simd_two_reg_misc(DisasContext *s, uint32_t insn) gen_helper_rints_exact(tcg_res, tcg_op, tcg_fpstatus); break; case 0x7c: /* URSQRTE */ - gen_helper_rsqrte_u32(tcg_res, tcg_op, tcg_fpstatus); + gen_helper_rsqrte_u32(tcg_res, tcg_op); break; case 0x1e: /* FRINT32Z */ case 0x5e: /* FRINT32X */ diff --git a/target/arm/translate.c b/target/arm/translate.c index 8e6c6f7b00..a5bb4b0040 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7265,19 +7265,11 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) break; } case NEON_2RM_VRECPE: - { - TCGv_ptr fpstatus = get_fpstatus_ptr(1); - gen_helper_recpe_u32(tmp, tmp, fpstatus); - tcg_temp_free_ptr(fpstatus); + gen_helper_recpe_u32(tmp, tmp); break; - } case NEON_2RM_VRSQRTE: - { - TCGv_ptr fpstatus = get_fpstatus_ptr(1); - gen_helper_rsqrte_u32(tmp, tmp, fpstatus); - tcg_temp_free_ptr(fpstatus); + gen_helper_rsqrte_u32(tmp, tmp); break; - } case NEON_2RM_VRECPE_F: { TCGv_ptr fpstatus = get_fpstatus_ptr(1); diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index 930d6e747f..a792661166 100644 --- a/target/arm/vfp_helper.c +++ b/target/arm/vfp_helper.c @@ -1023,7 +1023,7 @@ float64 HELPER(rsqrte_f64)(float64 input, void *fpstp) return make_float64(val); } -uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp) +uint32_t HELPER(recpe_u32)(uint32_t a) { /* float_status *s = fpstp; */ int input, estimate; @@ -1038,7 +1038,7 @@ uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp) return deposit32(0, (32 - 9), 9, estimate); } -uint32_t HELPER(rsqrte_u32)(uint32_t a, void *fpstp) +uint32_t HELPER(rsqrte_u32)(uint32_t a) { int estimate;