From patchwork Tue Apr 14 16:38:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 284381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E20EC2BA19 for ; Tue, 14 Apr 2020 16:47:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AFFD20678 for ; Tue, 14 Apr 2020 16:47:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V9Wsvw+0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AFFD20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOic-00017A-13 for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 12:47:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56008) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOad-0002VZ-G9 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:39:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOOab-00051x-KY for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:39:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55333 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOOaa-00050z-K7 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586882348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wLPOsT0G9YgHpWjxZdatLGrUy6tREQ/Zz1zlQsaY33Y=; b=V9Wsvw+0tqbAilmXnpoXkVN9Ih1VkOuy+K9y/5sVEPaHNuGQEiLX8LHFAhNE+tLg/AJH9/ hh8+UhzWmL3N2JRh8AYHX1A4ydq3dX8wfPWAUdIVpbHPeh43mSx4PyxfTMmYLEar54BhDe dsGIiTfgwtx8hfEESgyofn6EUifazWE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-OLcvDoOGMVuEoXLqDnm-MQ-1; Tue, 14 Apr 2020 12:39:06 -0400 X-MC-Unique: OLcvDoOGMVuEoXLqDnm-MQ-1 Received: by mail-wr1-f71.google.com with SMTP id q10so2465099wrv.10 for ; Tue, 14 Apr 2020 09:39:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fgRMUlDSYeLU1J9t9ILaCd5LaYgUOns3F9y47+OL018=; b=sy/TOC/0OzgIwNNzsbMA6/i+emTZxcl0WtnFSTUkGuG+EGVeCYvv9C92H08g4a0/fV hge+2AFN/ZOS0kyQJtqP75BksMjYTN4fJL02ccmnO3Mpylao9og+hNccgC4KWr7HxGU8 /pNoNXWQO/I6t1WwmFfQbPgWMCVb3Q6sq7QJ+9voF5lzlQ/UW9grmhPsjIjmfqC2JEoo sPU/j0wRl4uJz2D5IYz/Cq4F6MXsXxftmX5DAnBxQtyEWcfGUM3UhRUCU998eV3Ny1Qg uVdRMQFQ/V0cwaazfUm+LwVPCPk89rgLLAyATlw5j6PTVkJti/cqfSHX7JkJ3lOyZl76 ksbw== X-Gm-Message-State: AGi0PubmzS/ySif40wYRmFwyYSFjes3dyrxD23iE7V5rBUQfnd8im/x7 7mloRIBsL1Abf8vgfiEQwbhRmycKCn6d/Pb//mboUkPEx6SnyhB7S59fzisCQ/OEOgzYiE6cmPX ONVeotbIl/3a7CbQ= X-Received: by 2002:a05:600c:11:: with SMTP id g17mr682195wmc.142.1586882345459; Tue, 14 Apr 2020 09:39:05 -0700 (PDT) X-Google-Smtp-Source: APiQypJv0HRPGl8oO/D/2OKdI8rHzW7AhMum3n/XMFlmrYYaBLnmH8uOR47/T8aI59uj8eNaWT55gg== X-Received: by 2002:a05:600c:11:: with SMTP id g17mr682181wmc.142.1586882345223; Tue, 14 Apr 2020 09:39:05 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id y16sm19742574wrp.78.2020.04.14.09.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 09:39:04 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 v3 2/2] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Date: Tue, 14 Apr 2020 18:38:53 +0200 Message-Id: <20200414163853.12164-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200414163853.12164-1-philmd@redhat.com> References: <20200414163853.12164-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-D?= =?utf-8?b?YXVkw6k=?= , Richard Henderson , Laurent Vivier , qemu-ppc@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" When converted to use GByteArray in commits 462474d760c and a010bdbe719, the call to stfq_p() was removed. This call serialize a float. Since we now use a GByteArray, we can not use stfq_p() directly. Introduce the gdb_get_float64() helper to load a float64 register. Fixes: 462474d760c ("target/m68k: use gdb_get_reg helpers") Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Signed-off-by: Philippe Mathieu-Daudé --- v3: Use buf[sizeof(CPU_DoubleU)] (rth) --- include/exec/gdbstub.h | 10 ++++++++++ target/m68k/helper.c | 3 ++- target/ppc/gdbstub.c | 4 ++-- target/ppc/translate_init.inc.c | 2 +- 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index 0891d93de2..262181d8d6 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -135,6 +135,16 @@ static inline int gdb_get_float32(GByteArray *array, float32 val) return sizeof(buf); } +static inline int gdb_get_float64(GByteArray *array, float64 val) +{ + uint8_t buf[sizeof(CPU_DoubleU)]; + + stfq_p(buf, val); + g_byte_array_append(array, buf, sizeof(buf)); + + return sizeof(buf); +} + static inline int gdb_get_zeroes(GByteArray *array, size_t len) { for (size_t i = 0; i < len; i++) { diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 014657c637..cc80b48dda 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -72,7 +72,8 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, GByteArray *mem_buf, int n) { if (n < 8) { float_status s; - return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s)); + return gdb_get_float64(mem_buf, + floatx80_to_float64(env->fregs[n].d, &s)); } switch (n) { case 8: /* fpcontrol */ diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index eb362dd9ae..5c11c88b2a 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -130,7 +130,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n) gdb_get_regl(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); } else { switch (n) { case 64: @@ -184,7 +184,7 @@ int ppc_cpu_gdb_read_register_apple(CPUState *cs, GByteArray *buf, int n) gdb_get_reg64(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); } else if (n < 96) { /* Altivec */ gdb_get_reg64(buf, n - 64); diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index e853164a86..d825cb5975 100644 --- a/target/ppc/translate_init.inc.c +++ b/target/ppc/translate_init.inc.c @@ -9881,7 +9881,7 @@ static int gdb_get_float_reg(CPUPPCState *env, GByteArray *buf, int n) { uint8_t *mem_buf; if (n < 32) { - gdb_get_reg64(buf, *cpu_fpr_ptr(env, n)); + gdb_get_float64(buf, *cpu_fpr_ptr(env, n)); mem_buf = gdb_get_reg_ptr(buf, 8); ppc_maybe_bswap_register(env, mem_buf, 8); return 8;