From patchwork Tue Mar 17 17:50:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 184657 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp4446064ile; Tue, 17 Mar 2020 11:05:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtnIuS6X8jyvn2niH7XSZw1UTrp5RxZwSLqqcs0Rb58as44czoDCdYhsbYwr9nZokttvnC/ X-Received: by 2002:ad4:436b:: with SMTP id u11mr353465qvt.117.1584468340561; Tue, 17 Mar 2020 11:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584468340; cv=none; d=google.com; s=arc-20160816; b=JiVy0T70H+ZBJPsqVNeHdGkChbZOwAikCcGhj3t8jjiwSNZKUq8qd/SfTy0BKzHiuU F2DPPgdZRceNBLb3HoIoGy5q9easDnxH7NomZ+1WjlBilRm/40/n7AbkiIskKLhlm57T K2TuSVbq2ZijS44OSMdGRU5E9+ygvbZdwNe84zqpJnPT1ELgOmrV8qrwYxgtP6EImfSm +G1eGvD5fU/riJ/kPCHfq1AkfYa3C9Oo5KRhzHELN7mD8eZ4MC50N9uNDCBbZCKE7mw9 xF+oejt7BjvAvy8Z47O3BuZpJB3yXi6FKMo+u/zcw7uuYZWX3KRbaqKTMSGlmn/iFkxO rn+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=y70yduvZnlJuuEmJKz38qFwzokDPfNTPIIUVc1ktav0=; b=OVz1h81bU1bHAQIvdF3qdoDny+p5GHFgm7Qwx84zrOeo3oaDgaiTR2B3j5uaCg0cgy NEU2yHdDasHIqcPJOW177ZLDzqQ74YxcCQ/YBp8ph4eoMQKujevC9Mp/z2agDcAAiXed Yvp7tzXukZITSdvZrGqwqG1sZfcDl4qTiQvotxDlDoYOS5mYPl/FEcCTIHuULhy5/Omd /F9SPN7AIydZL99qL+I8krdNsTZ+orbDzSe8zpY5TG4r7If7u+86Zly5Fh0wGlOIUY5f 31TiY5R/h28S+igLipACcAlrRV0ENxr7v8IlCAhFykJMKJQFe4TQqea0xIiJAYoOO6Hb 7VGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lix2ZnYO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p65si2514699qkd.49.2020.03.17.11.05.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Mar 2020 11:05:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lix2ZnYO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEGax-0004Lg-V0 for patch@linaro.org; Tue, 17 Mar 2020 14:05:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36616) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEGUS-0005WL-S6 for qemu-devel@nongnu.org; Tue, 17 Mar 2020 13:58:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEGUR-0008Vq-6t for qemu-devel@nongnu.org; Tue, 17 Mar 2020 13:58:56 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:55848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEGUQ-0008PM-Rl for qemu-devel@nongnu.org; Tue, 17 Mar 2020 13:58:55 -0400 Received: by mail-wm1-x331.google.com with SMTP id 6so256663wmi.5 for ; Tue, 17 Mar 2020 10:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y70yduvZnlJuuEmJKz38qFwzokDPfNTPIIUVc1ktav0=; b=lix2ZnYOEUi01Log7I7WE+5KIg5Kmcf+6HH7/k98xE8P01xhpa5r1NzfZCM8CyQ/sJ +alaisFp2redPti1cORSloAKExOCo19GkBsiFiwsf6X8BqPXuKwRqr6YWwhsIkdHfTho IWi9PlPXyRLEYr34PWk2KIlfrtSRR1Z/ljgD097cJalxl5d2MnpyanQ8XMDerHctI0Xy w02crGpMwsGen4Pk0lkj6CBPxXl7wyzCha5/qUP4hbFs1lcSpJG/siErFWUQewlK8moz jiJ3IuUsrXa63cCFlzuiV+5WjzIharnoNd0ry7dp+kEu6YscXW0mw9evS1z0v0ro8FEc /ZGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y70yduvZnlJuuEmJKz38qFwzokDPfNTPIIUVc1ktav0=; b=PmYIloyFqInzf5nR4veiQjXopvivtOAPek4dhZYVZm8wFA1gHzREbOvUc5Z5ReI1P3 les0eJpGddkN/6MCcTx0n0TljwfJSteC6WfgZP5Lue5O8O7GLI8qOHGYcx+HRlYGVex6 3id35cXFEavVpVO3ASwa49ymuHawCBHk0mTJO2NVELXDSVuFmO7X7sB/W9g5At2+xcjy c5/ChUvg2KfUkRNPtg71Dc5BvaSyDf8fId+/YFFgXLX0mkqPlcKIJA+WOyWgv7XJItBH mpQRjV2ax3R8K3EIu4QIZdxMMTyub4l5l203ExHAEdT7IBg+5pv7CstokGVaLVG8/P+a B8hw== X-Gm-Message-State: ANhLgQ3STxedag/5oVYo4IKvvaR7bcCX7ckFTQJfU9yFqpP7Fh4b3MXj dwlaw4SVlbHbu7b4I3SkUmirAw== X-Received: by 2002:a1c:b789:: with SMTP id h131mr171297wmf.141.1584467933564; Tue, 17 Mar 2020 10:58:53 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u8sm5236356wrn.69.2020.03.17.10.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 10:58:44 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0D16C1FFB3; Tue, 17 Mar 2020 17:50:56 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 27/28] gdbstub: do not split gdb_monitor_write payload Date: Tue, 17 Mar 2020 17:50:52 +0000 Message-Id: <20200317175053.5278-28-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200317175053.5278-1-alex.bennee@linaro.org> References: <20200317175053.5278-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?b?RGF1ZMOp?= , Richard Henderson , qemu-devel@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Luc Michel Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Damien Hedde Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. Suggested-by: Luc Michel Signed-off-by: Damien Hedde Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20191211160514.58373-3-damien.hedde@greensocs.com> Message-Id: <20200316172155.971-28-alex.bennee@linaro.org> -- 2.20.1 diff --git a/gdbstub.c b/gdbstub.c index a60ef5125eb..9ae148cd1ff 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent event) } } -static void gdb_monitor_output(const char *msg, int len) -{ - g_autoptr(GString) buf = g_string_new("O"); - memtohex(buf, (uint8_t *)msg, len); - put_packet(buf->str); -} - static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len) { - const char *p = (const char *)buf; - int max_sz; - - max_sz = (MAX_PACKET_LENGTH / 2) + 1; - for (;;) { - if (len <= max_sz) { - gdb_monitor_output(p, len); - break; - } - gdb_monitor_output(p, max_sz); - p += max_sz; - len -= max_sz; - } + g_autoptr(GString) hex_buf = g_string_new("O"); + memtohex(hex_buf, buf, len); + put_packet(hex_buf->str); return len; }