From patchwork Tue Mar 17 16:36:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 184632 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp4365952ile; Tue, 17 Mar 2020 09:48:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtQqKYfbRRSuYyNZVSuF9TwQwgv+P4gAiDU4Ud6PcLMbvMR1J+rZKaXA4vXZHqTYFXtm4/Y X-Received: by 2002:a05:620a:12f9:: with SMTP id f25mr6066345qkl.370.1584463732291; Tue, 17 Mar 2020 09:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584463732; cv=none; d=google.com; s=arc-20160816; b=iQ0E14Orvsp1TCQGwkbD8OqsNyNfvV/D4DulldysHHHeqCAl59Wy0YIYpYwR6tQU3z x1khI+rfnVso68iwhDdkLj/8p7+LHJxp9HJdNYiE5TngDK7mBa5V/a58cb6E8fOj7e8D YUzQdnJS9TjCCOXwUH/n2xSvkDNSrobDyHTuK88oW6H0h+mf40p5rXmKtFriInDC9/SQ bCs8NZfQ1Jz5oalfDW0oL18jvljgTjeEWZgiv+/B6G60NbPuD4Dy+c3/NxDrCoQucN2N NkDLN+ifx1mz5XikxGafxWQIu4WU4gtbmmzg/KbZVcWgZO2c7NOH1yDoIXrtCh12zjAC lEow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1enKsIBdEviq5nykP6LOEgZbSgk5slEBebWoM6e6JJM=; b=TpUL3z+Fc8XdJHR3wyPV2LLAOF19SZciWj2imB41itnXs/a9stSmjW5lsBfv/46b7s VrTYJsV7yRwmlByGMWt4NkoZlPxOaiUztD9CtBMlRA0XUEzD4bHlPKHpIo9w3tT30fW/ rPFrkWQNGmGe/1Q8X9AYJOK5GsQZJXUtySzk6NpdAuBOS3TbRvP6gnZjr+/TJOlzTz1h tClrOkjAiqhlmRDN3cmno0JFzRleQ8k95WFLnYfqL7FQWRKt8X24rbGQNomjMQw/0yMw 8ekdfP393/TotT4ZklS0iiZfGYIqrHnCAj2V+x1gEw/7AFkm5MZUMplzaU0KlAN5CuHd eXfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Lhu1xL46; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=amsat.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ep10si2081590qvb.115.2020.03.17.09.48.52 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Mar 2020 09:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Lhu1xL46; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=amsat.org Received: from localhost ([::1]:36822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEFOd-0005H2-OC for patch@linaro.org; Tue, 17 Mar 2020 12:48:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35922) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEFCj-0003tK-R2 for qemu-devel@nongnu.org; Tue, 17 Mar 2020 12:36:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEFCi-0003ml-HG for qemu-devel@nongnu.org; Tue, 17 Mar 2020 12:36:33 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:39201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEFCi-0003ge-9m for qemu-devel@nongnu.org; Tue, 17 Mar 2020 12:36:32 -0400 Received: by mail-wr1-x42d.google.com with SMTP id h6so6221560wrs.6 for ; Tue, 17 Mar 2020 09:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1enKsIBdEviq5nykP6LOEgZbSgk5slEBebWoM6e6JJM=; b=Lhu1xL46r5+epPlep0AEbOEjzP7r8OMGtrUbgA9duExYp/Nuc2R/sctwDj64FckOet 620FH2+fM1t/E6ctFqDaoZvhpQJ/r8+dWK8wbSv9q4fHNe1mnMsXZ4EeA9t+1b4yt+wb vwe2RqYpEmUJDOJp42eZ/8dK8I+vQaExsBPV7UMo+cSfTCIYtGpelxg43xNBaE2Mjs0A LHZn7YNpztvSIpx/B/KaWHKHq6Sb8KyPQyfMxRh27jZhFnmyNlsGLw7JEGUQ2LNuy+kR GTkceBV6C6ePaIJ45qOCF0wCwfjn8E72ntCruerJu9YcDduVexi2z8SOZz9V3cBVNSvo 4ejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1enKsIBdEviq5nykP6LOEgZbSgk5slEBebWoM6e6JJM=; b=XDe59++A6XIc181msWtarFyHbwC+C3OZGYvYZKpO4EVqwHiRVSUej7jFuOqgzde6Yt m6CKmCT5K5SBGCs5fgWbL/4DOegnBE5lt7R4PCNrkDeInf/oHX119SvP5sXdeF09LhOO oYkN4ihu3j3Jz+tuwc6+UXSflFSwoxXWh0u9R3jPibJuSJB61Jcilyy7feMboxwxBMFV CHjfZutaMr5Y2p7J6fbcfH4jh3aJNqRUfytTw1XHm2lDsnZojZ/rEISsx3aHNl1Wm+iV 6AUkhoJW3N60CdgpC9zj5pyXW31eq0+uc2Sfi3SIEwisio39F7g2uGmDoMSDrNjPL6qn O0mw== X-Gm-Message-State: ANhLgQ1eHNu1Q73vq5eEItKr8YLGhaWasz2L8WCIqf/7ogwoOJYcFAY6 STPKtMh1KNi5X6tISYRdaKAoeQ73 X-Received: by 2002:a5d:4a10:: with SMTP id m16mr6618622wrq.333.1584462990895; Tue, 17 Mar 2020 09:36:30 -0700 (PDT) Received: from x1w.redhat.com (96.red-83-59-163.dynamicip.rima-tde.net. [83.59.163.96]) by smtp.gmail.com with ESMTPSA id b202sm4618697wmd.15.2020.03.17.09.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 09:36:29 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/13] target/rx: Use prt_ldmi for XCHG_mr disassembly Date: Tue, 17 Mar 2020 17:36:12 +0100 Message-Id: <20200317163616.30027-10-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200317163616.30027-1-f4bug@amsat.org> References: <20200317163616.30027-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42d X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_?= =?utf-8?q?Mathieu-Daud=C3=A9?= , Yoshinori Sato , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20190531134315.4109-21-richard.henderson@linaro.org> Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/rx/disas.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.21.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 0c4115669d..a0c444020c 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a) /* xchg dsp[rs].,rd */ static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a) { - static const char msize[][4] = { - "b", "w", "l", "ub", "uw", - }; - char dsp[8]; - - rx_index_addr(ctx, dsp, a->ld, a->mi); - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd); + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd); return true; }