From patchwork Wed Feb 26 18:10:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 183919 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp3456118ile; Wed, 26 Feb 2020 10:13:01 -0800 (PST) X-Google-Smtp-Source: APXvYqw4SAZh0VI7bpSpHhNaIU89BcP7KESkdG60Z3TwuRrGpuFFiwfbPFrzsAooijENI7J/vHBl X-Received: by 2002:a05:620a:12f0:: with SMTP id f16mr364145qkl.311.1582740781787; Wed, 26 Feb 2020 10:13:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582740781; cv=none; d=google.com; s=arc-20160816; b=vgLkONOWfmqHZyotjfiSUj33DoAK7roWL3NT5iwHYqeu5AYLt6QTOl7WqnLS5w/zga lKxr/Ad5RaDqSaVXnCf9bM4gG/72JvD5cN2D9xuhHPGFe7SJlJJ/XDhNhuzIS5/AFacd 78fwqmtpq9VHvQRAYmhy8xFzXrtxO2GOXfWMS/O8R0lsWxKKfK9X0M+302VQl4qNHdkS Z6PvW+xRjjBejII2Ng5PNvKxLQFjkzGq6sCjXjARDecy3Sd+IIM3U8b3jJoWQ0zmegxy jkcP+chLva5lSWFl6su56Bq//oLG8Iauc7PMNZwDsxo4576ROrP/KN6tqym8BW9TGtjJ Dvmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=e60KOq+JHGiPYLG4KWg7uqrCxiXd8UnFiEYZk4AHw2tp/MqH3UKVkqAaUSMM/riRus Dxc+gHukXik8TiWpNDN5TRLg7oiF+wfiOD0pFleJLTO8K/OcbQmRWYOTtKR1FOgKruuS GGPooW5sLj1z3/a6CCfplj1ZfPdSjJXAqh6FBjCgmatmGWL37QozIApvj54mdwbtwWwC XDRZEN3cYqOuJ7NcHX+fPXWTX9dFwxWKaqxGZtWNeSwA6EdfVAjC23UGk7/CgHFcuzI7 gSUf1GkajoshTaSYG4M4rKkc8ASELr8UrU98Sp1paO15+DCUZuydoyCQ163zAxQWUMDU 22GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eQSzHAVF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o24si119635qki.330.2020.02.26.10.13.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Feb 2020 10:13:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eQSzHAVF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71B7-0003S2-A2 for patch@linaro.org; Wed, 26 Feb 2020 13:13:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40701) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j718g-0007DV-Ak for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j718f-00067T-9q for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:30 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:52080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j718f-00066o-3d for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:29 -0500 Received: by mail-wm1-x344.google.com with SMTP id t23so276429wmi.1 for ; Wed, 26 Feb 2020 10:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=eQSzHAVFumHhzYdBXmXaE+cLeTGQO0bIkGTK6aArG9UlqWjheMpZwpKL2FFgVCBK2A jrTISFiiSo7GVEZzZb5FDb5B10PDCEK94WFe8EA11eFdDJOjDVKNmt7Qjj/SQqpZtOTS naulW5shQLyMIwS/Sxe4vvJG1Jg03fulYxnAADa2iP7OMVL0l8A9VV302ePNKILWztuv tNfhuOBrR2YUAUidiH5j3D4e8QeGaYjxNb96U7k2pLCYi3foTMLgEVcWoyOfXUGlhibb WLQU+7ENJcHPPwKfrmyh7MfDZE+lGhk/Q1/QpCOfhCMGX6qJJoNyLwOz4pKCOe0QT/Y/ HcHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=XFaUy3J3bRx4pL/8RsNBeFafvuvcunxhJxFA6R8c9gksh5lLWm+9zLSOf019L0BS/1 yJPRM1BhQsMW8pY2yjNctX8hfvyQKzKX391V5mVHtxjWzFQMsGli0xyGrXARm3zSqaNx JZIkhXif3ppme0BvSG6lnnzQAZ2HAmOfPDoxFvwLHGSs+jhdv7GSQQy+IysgFK+5EH4g 9bkg0/yXkh97DHLicjXTIfn58vG4WVOQkKsE6m/HCVs/jfGqKtOrlkiBIuXu+KiWmUbQ a3eYjb79KCcqdoVP2Xxd3D43jEVMs3vEL1jk/KQvFGess+Z+krQNeSvHvVQ00jEVt4xl l8wA== X-Gm-Message-State: APjAAAWIa0OoF5RNBuD1ydb2iUnuc5WAqRmWcxWhgS7ODr85Bf1rQT/t UBEOtQWpaUhjmlMugg8lZZzkIw== X-Received: by 2002:a7b:c152:: with SMTP id z18mr132561wmi.70.1582740628019; Wed, 26 Feb 2020 10:10:28 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a3sm4411073wrq.63.2020.02.26.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 10:10:23 -0800 (PST) Received: from zen.home.arpa (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1EC1B1FF90; Wed, 26 Feb 2020 18:10:21 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 3/4] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts Date: Wed, 26 Feb 2020 18:10:19 +0000 Message-Id: <20200226181020.19592-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org> References: <20200226181020.19592-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm@nongnu.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is no particular reason to use a static codegen buffer on 64 bit hosts as we have address space to burn. Allow the common CONFIG_USER case to use the mmap'ed buffers like SoftMMU. Signed-off-by: Alex Bennée --- accel/tcg/translate-all.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 5b66af783b5..4ce5d1b3931 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -892,11 +892,12 @@ static void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1, } } -#if defined(CONFIG_USER_ONLY) -/* Currently it is not recommended to allocate big chunks of data in - user mode. It will change when a dedicated libc will be used. */ -/* ??? 64-bit hosts ought to have no problem mmaping data outside the - region in which the guest needs to run. Revisit this. */ +#if defined(CONFIG_USER_ONLY) && TCG_TARGET_REG_BITS == 32 +/* + * For user mode on smaller 32 bit systems we may run into trouble + * allocating big chunks of data in the right place. On these systems + * we utilise a static code generation buffer directly in the binary. + */ #define USE_STATIC_CODE_GEN_BUFFER #endif