From patchwork Mon Feb 24 14:19:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 183767 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp451781ile; Mon, 24 Feb 2020 06:22:21 -0800 (PST) X-Google-Smtp-Source: APXvYqxdGn+TO9mmjYZwli5IxxWkwovoon21VG4r9UMEqCAMudgoW8FFaPnyHekMQiVDaKA75hxU X-Received: by 2002:aed:2dc2:: with SMTP id i60mr45903934qtd.8.1582554141407; Mon, 24 Feb 2020 06:22:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582554141; cv=none; d=google.com; s=arc-20160816; b=afOxnzEkS/dGQaSPnEZjLxAt7MNAbUQyLZl45RBRyRYdQt8T/byFoW9+kBuki2j+7F OIe3V41G0cO9xIbZSMHZxEqBA8U7H+JMsioeQd94xmZjDMSbagT+P7XrY/UI+gqt4O2B WZ36nMJAKaq3av6URrg3JrodWYPYhG6q2Vzt+dVscQpb9k0cJmQI6ypgaFXppULldKsW ftEQDEEGiQN9QIqjzYhUCiacMWsHdbAXZjjdHrdPzMrO5aCAMOg7NVonv63JlAw2BpNt nnwcEROkQj/Gw4WiT9oNLYtmYrCKrCTm7BBzX/B50vvdoQrw2DXd82TkTuVXXL4FIxwN CE8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=FMOVX0XQN7LK1TtWxoTt3b9EkWjXDnW6ZJayXOMWuZUeXz8UrJoISecZnxm4DoKsOW kGMG478MHH7dBln70P1ELZTYOrqnQSoRAf5sbJbPHAL/rIWVqSP12zB9u4UqCD2AXgxt DIqt1VmfmrIS4OLlCRnQhlL5C93KOmqg93oFqyNfLOEKRBltpasZu5l5osJqmaxwaaIb 8IT8H+KRfdKtmOE+K9Kn0evg2Ti3JWCUlsYzC3xJTh4Qn911HhI8W4fW/XY/aCngQI89 lsF2nJH/oTeFp9fh7e8O6VhGVbaWoVwTFgce4m6JPRs3MODse1l1RMwAL9byH8gxPTLO VFxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y13si6119997qkl.309.2020.02.24.06.22.21 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Feb 2020 06:22:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:37034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Ecm-0002fu-UF for patch@linaro.org; Mon, 24 Feb 2020 09:22:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48324) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Ea5-0004Ix-Uf for qemu-devel@nongnu.org; Mon, 24 Feb 2020 09:19:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6Ea4-0005qL-NF for qemu-devel@nongnu.org; Mon, 24 Feb 2020 09:19:33 -0500 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:55158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j6Ea4-0005pJ-Eq for qemu-devel@nongnu.org; Mon, 24 Feb 2020 09:19:32 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id C4C3FE553D; Mon, 24 Feb 2020 23:19:31 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 8660D24008E; Mon, 24 Feb 2020 23:19:31 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v32 13/22] target/rx: Dump bytes for each insn during disassembly Date: Mon, 24 Feb 2020 23:19:14 +0900 Message-Id: <20200224141923.82118-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200224141923.82118-1-ysato@users.sourceforge.jp> References: <20200224141923.82118-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1