From patchwork Sun Feb 23 13:27:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 183757 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp4245439ile; Sun, 23 Feb 2020 05:35:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxUfHavfX+6YeacDHNV9MZT3kqllqehZAY5Oei0JvipA0teUALrJ893tO6GyTqmk1DJ5U4A X-Received: by 2002:ac8:5502:: with SMTP id j2mr43612513qtq.127.1582464937440; Sun, 23 Feb 2020 05:35:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582464937; cv=none; d=google.com; s=arc-20160816; b=aeOveW2TxngtSZ/PxpAQxBGixnuYVVjumUcVr44Lm2zw8J9+7JxPAr/ATvmzUd6282 uP8bMJuiQEtDWtQ8Nx76LRxD2fQm8VfndhWx1DWC06ZxYTaMqIkaoMIBfuucdUK135tS CaifpwKF+4ymlBuIc2gEb3MPadfmKQktCx+JZwHLtokRw8iPyWLIH1dgGtDDRNPPP8Li rRsfxmIlE/OF8UW6AVJn3Rk2/HvmgnNab05Xg2aobxozkjCiblOqRtCqX6WGS98O1YL5 hBuS+VscYR0+VZApbekKkZu+uWZPCGMlsBFV6lSJ975sbhuXyvw/Ajl1QViIE5b/TusQ xNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=ozVHJfwn2H0v8EHuAi4Np8UEuQuyMolKSDRPCDJfiwBYT5sGOjIOHzoWTOYYaQ6TqU pCgwORfuxZuLL/uCnAhrlg0lJvEiAdcx/bEobLib/ErMV2DyGxah+uFLCx54o56+v25I B0vVDjkXfULATMQ1dCCriSQY+z3ZsU1St2zpR15RKsYOp7bDKiOOUdnHeyD+oFuajFY8 Mm7a0PlFcxkOz5fDbw3d/xzOkb4WkNZWenCzPIyc2WIA7LPcPE2NJn1FzetCpG4rSnAC lW7Ta6265WwqxC4W34+0SU+NqaN9kKRLmp/MUevhGDFGNHNvE0kRCQXTk97dKU65kBW2 4FEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n59si3928777qva.59.2020.02.23.05.35.37 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Feb 2020 05:35:37 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:52995 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5rQ0-0002Cw-Ts for patch@linaro.org; Sun, 23 Feb 2020 08:35:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41726) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5rIh-00005j-0C for qemu-devel@nongnu.org; Sun, 23 Feb 2020 08:28:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5rIf-0003v2-JM for qemu-devel@nongnu.org; Sun, 23 Feb 2020 08:28:02 -0500 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:45215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5rIf-0003uN-Bl for qemu-devel@nongnu.org; Sun, 23 Feb 2020 08:28:01 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id B08EDE3456; Sun, 23 Feb 2020 22:28:00 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 759D224008E; Sun, 23 Feb 2020 22:28:00 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH RESEND v31 13/22] target/rx: Dump bytes for each insn during disassembly Date: Sun, 23 Feb 2020 22:27:40 +0900 Message-Id: <20200223132750.69480-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200223132750.69480-1-ysato@users.sourceforge.jp> References: <20200223132750.69480-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1