From patchwork Sun Feb 23 06:50:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 183750 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp3932805ile; Sat, 22 Feb 2020 22:57:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzkZ8CMILo+HY6mFXVPyT+ohM6vtThBqPbdJwxgm9opInOUh/zEqtAM9+Xm7thNZA4wL+iu X-Received: by 2002:a05:620a:1ef:: with SMTP id x15mr42888156qkn.479.1582441023249; Sat, 22 Feb 2020 22:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582441023; cv=none; d=google.com; s=arc-20160816; b=wRrkQ32x2xt9BvcOvYwYpa+Z+nnZ4DT5NNO7mp5t6ufgV7mLE5iIBqA16UCMe8yOqf 49bOKtptXmaysjGFwnKEX4vW/DMbByylXEOO/JsGXhvyAbx4neCRLp/D0fy9o40HZ6GE /jF6uSvhubR/uWHK6EnHFzti9xnnV/cmZx5DUghG0CuIvsNg7lT701aXbdcpyfQmOTIn XiVu0fXcilgWsuhKjkHQH1M0QJpvmySTYjBkTNF0QCF53V/W7U/30+r0Tj704JwjUu4R X914u4JarY7grXZBIH0/LN4diK4IFZq3jONkrjQQ2uWHSqGLuaPIVOWCRWEGkq7C6Sid 2Rmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=sLoFhXnN9uM0ghB6WBeXgCQdJtcHUIVYDbWB5oFjtUm3p12q1Wn0YqAv9+H0abRKYI zZwKMNS/N1dFCgjdEDsQ5213hWIq3iqTQoxSjSobaA2Hg9lj/NVbTBCbmB9lQLf3Fyed jGAy9HHYv08WddD7LoC2+4UEnZU39iB30Upeyxi/cLrhAwEIta0daXbaowgkmHyocmZc +CZGV6Pn5j3Lj0NsWFpUN5jwvP+oTDgxtsZZT9Vd555GBDe1zyAXSOtU1hpTyXtrIqKb m+D3m03FcmK+BUqKIqNlxpKYA+ILygyJlRTFtkZwRwEBJfVJcH+zYJ2vDe1eM51Y0wo7 5RVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s195si2519393qke.364.2020.02.22.22.57.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Feb 2020 22:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:50094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5lCI-0000lO-QY for patch@linaro.org; Sun, 23 Feb 2020 01:57:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34453) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5l6j-0004HJ-CX for qemu-devel@nongnu.org; Sun, 23 Feb 2020 01:51:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5l6h-0004l9-Of for qemu-devel@nongnu.org; Sun, 23 Feb 2020 01:51:17 -0500 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:38299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5l6h-0004jC-Ek for qemu-devel@nongnu.org; Sun, 23 Feb 2020 01:51:15 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id BC95153B9C; Sun, 23 Feb 2020 15:51:14 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 6A20A24008E; Sun, 23 Feb 2020 15:51:14 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v31 13/22] target/rx: Dump bytes for each insn during disassembly Date: Sun, 23 Feb 2020 15:50:53 +0900 Message-Id: <20200223065102.61652-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200223065102.61652-1-ysato@users.sourceforge.jp> References: <20200223065102.61652-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.13 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1