From patchwork Tue Feb 18 19:39:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 183618 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp6490260ile; Tue, 18 Feb 2020 11:44:53 -0800 (PST) X-Google-Smtp-Source: APXvYqwgS1dbzMoWYhlkWxKn9jPlwUsY3dAMrIQGauw/CKTp64UgOsDcHzjO4r8sc/9FXNMBnK2A X-Received: by 2002:a0c:e2d1:: with SMTP id t17mr18430294qvl.25.1582055093877; Tue, 18 Feb 2020 11:44:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582055093; cv=none; d=google.com; s=arc-20160816; b=YiTczsh6DUCFtxognpi7NflteEsWTrR6iXvXa53i/Dpavofyc4Xbh9UdvK/2EtQWLG 3i2szKgihawT71fGcCgTXNjUPdQO7I0DT8tTdp3KnY3x0aP68peg4X/bit58tMDA5Rzi wAvydsDnB2nSw1vPs57uXn9Ence3ACpF3v2krp3mymoccCNz7Ww+Ou1tXEsoKgdB8HiI L8pkejuM8+zarhMVlCOz7cUGjsBproISZrl2O/HxTgT3plxOndBxDAgcqfKLtLvNRGbM YecU4yW4TX9/j4DGPsGfo56AkRNK+gaaKY4bzK6n+97aFWhm8Mt9mZ8qQJV4TjgyffoO sKJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=oZO5RKA9Grp6ITlGi7FVOEFNRvhDdW0o8hVNMgXHdmY=; b=Fsw0ZWaoPFAv5L0zxIY3kEIy4wevwr9gxifFSPt6jyzOrw6IXUPODTGaqbnCGOYUiZ M/cCjsoLeqbARo8yDLdENZTG24g0KpI8UX5eObqoYQNrNEwOVsqU75pB4zcwf13jwDCs QpO/jdiHsNaXIa2MMjNbkNNeal2j1aVwz3oo9by/cSXXsXbFomu8nuWwpsySI4DPB06Y 2bqY0x5B/YYnTYJlkyhdrjjIWG/KnXr8edpO+X/b128wTLTu6IlEf4u0t5fPaTxd0Due 4WRBpjD+RMV507Lyuk/RKT1H4rrW7385uwiT8wusXLYHwP86rwjHasELTRgx75QOll+k y4Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z5PZcdM3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g2si2135033qtr.72.2020.02.18.11.44.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Feb 2020 11:44:53 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z5PZcdM3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48nd-0003QX-Fg for patch@linaro.org; Tue, 18 Feb 2020 14:44:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55208) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48ic-0003hz-8G for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j48ib-0004Qo-7J for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:42 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:35795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j48ib-0004PT-1R for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:41 -0500 Received: by mail-pl1-x62a.google.com with SMTP id g6so8487794plt.2 for ; Tue, 18 Feb 2020 11:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oZO5RKA9Grp6ITlGi7FVOEFNRvhDdW0o8hVNMgXHdmY=; b=z5PZcdM3GwfshQMTb+zkOYVWQxLMe8XtkmZqYkJdrc92e/r8MZUVqGsfVy9QAbBAAf /yvajMui0bQH9bVNuH539y0Ce8CedmHmiO5zmiwosDHjFfxOqb/TPpYXAQr1IXfc4FIQ OKCyCbXJ77pbWZ+6UsbXdKOFGPJL1heXOmi+xovIztzXx9+2aXKvQlsA/oQhOGV92prL /FHNURWpHnW28ywc7QsXzNquhaXqt0Vz7bSkyy4Qmzwh8jwy6h47/5Fw5ZutD6rky9ZS YI7JVVnG6Smm25aaNJfyDYfI4gmXsZnLFv/J1IkYAiZfxKSbEHT46Xbr791zWNFdxf7E 0Zrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oZO5RKA9Grp6ITlGi7FVOEFNRvhDdW0o8hVNMgXHdmY=; b=azVHyeTk2uI5MwCXkfBKv3ZT3j6KkiyCsTk0L9f2y6dvWrXYIea2J2tbN972c6Den3 K9xYu3EAoiybl24IbOh/lUKX4XrC+EOYRFguHprGKn5NEED2oM0rw7ebPQtRso1GAl+4 FSqR3DxWUiqDrMUgVcJUY2XrbZf6AJNtcZqPiuJMTOjDJj4R6M5NmEz11d/7TknKqvz8 odPAfgdvz71GOBjmh3mo15voNGS8eyFGCeMg7D7wWkCy/e5eD0aje7ju6ZnRZmJBZrvi gqU0cGerTNLuh+IJ3DfQAKLirEvzD6yv5W6O4snCfw8bgJB7cb3zeWapfo+28+8UeaXZ sbYA== X-Gm-Message-State: APjAAAWgmPRIA83lXY+SvYNcQC6oOfPRKGS0voCqE4KA/iEglK0OwJji H2VtXoyUl+Ir3g9FpuVQDuoTwcA0WU8= X-Received: by 2002:a17:90a:db0b:: with SMTP id g11mr4395370pjv.140.1582054779627; Tue, 18 Feb 2020 11:39:39 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id y15sm424395pgj.78.2020.02.18.11.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 11:39:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 6/9] hw/hppa/dino: Add comments with register name Date: Tue, 18 Feb 2020 11:39:26 -0800 Message-Id: <20200218193929.11404-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200218193929.11404-1-richard.henderson@linaro.org> References: <20200218193929.11404-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62a X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Helge Deller , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Add a comment with the name of each register in the 0x800-0x8ff range. Acked-by: Helge Deller Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200218063355.18577-2-f4bug@amsat.org> Signed-off-by: Richard Henderson --- hw/hppa/dino.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.20.1 diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 9797a7f0d9..c237ad3b1b 100644 --- a/hw/hppa/dino.c +++ b/hw/hppa/dino.c @@ -85,18 +85,18 @@ #define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4) static const uint32_t reg800_keep_bits[DINO800_REGS] = { - MAKE_64BIT_MASK(0, 1), - MAKE_64BIT_MASK(0, 7), - MAKE_64BIT_MASK(0, 7), - MAKE_64BIT_MASK(0, 8), - MAKE_64BIT_MASK(0, 7), - MAKE_64BIT_MASK(0, 9), - MAKE_64BIT_MASK(0, 32), - MAKE_64BIT_MASK(0, 8), - MAKE_64BIT_MASK(0, 30), - MAKE_64BIT_MASK(0, 25), - MAKE_64BIT_MASK(0, 22), - MAKE_64BIT_MASK(0, 9), + MAKE_64BIT_MASK(0, 1), /* GMASK */ + MAKE_64BIT_MASK(0, 7), /* PAMR */ + MAKE_64BIT_MASK(0, 7), /* PAPR */ + MAKE_64BIT_MASK(0, 8), /* DAMODE */ + MAKE_64BIT_MASK(0, 7), /* PCICMD */ + MAKE_64BIT_MASK(0, 9), /* PCISTS */ + MAKE_64BIT_MASK(0, 32), /* Undefined */ + MAKE_64BIT_MASK(0, 8), /* MLTIM */ + MAKE_64BIT_MASK(0, 30), /* BRDG_FEAT */ + MAKE_64BIT_MASK(0, 25), /* PCIROR */ + MAKE_64BIT_MASK(0, 22), /* PCIWOR */ + MAKE_64BIT_MASK(0, 9), /* TLTIM */ }; typedef struct DinoState {