From patchwork Tue Feb 18 19:39:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 183612 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp6487657ile; Tue, 18 Feb 2020 11:41:49 -0800 (PST) X-Google-Smtp-Source: APXvYqzGmM6Co58fVN020sFiiJ4s9Xe2IJXQ973ZEqNg6GxR6Uae9gCYnMCyigFGEDl3WQM4bBop X-Received: by 2002:a37:bc6:: with SMTP id 189mr19734216qkl.459.1582054909064; Tue, 18 Feb 2020 11:41:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582054909; cv=none; d=google.com; s=arc-20160816; b=Zx/xc+D06gcNcjC8UXMjkyfTZdlornB/5lSEGOP2Eysc+Qojuw/tXCvlWzL3r/BkEc jt7IbDGP3vD4t+Vc5UgEDKG+HdUqcrAT2QjH33ZxcjUPKrLP0XLjQA3ybZd2Z10dJLIs z/ZCGnmgRtAZ1ioX2HXAUWzt+I300IB70dQCnYJOm8gQcnIuI7Lodz9tf+OyoshNVRdo wEVpY12VwLB/vHQczBJeR6dLDfsilBIKgBD3tXkwJM8NApGWlB4bsW08AWr1lMivhQWt cXfGsKhVojwj6SNLEeZX5p1t3lBD9Ew46UqcYgn1Bsch2EgLhYAe6lo4K3LVXa96hmXZ wLMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=oxNPd/QkKRHeWi1ZwK35YEXvYDOJm8fo+psN51CFfCE=; b=QM3q5oWdmC/VLJmRPyZAjB7PbA34Ny1Nf6UvZHeItVJsSOKhLHIHjcducfNPlXLVMp Bu9fYM+PDC5+VzCAKEfbOUlUhiC35Msqd7cUHMXIo/C5Jx9Ib++J0n7LdNfCNzP5X9pZ IvjPE6wl5uDv11BXPEUef5GASMfn9S/Ijz7wE4Vqu6jxo2UR5YgjdoBORaOqFveSrwfu brHiS0pGOb6o7Fo1iNaMlSqQNv+Oz0bMq7n3n/ASNTNl+WynMvGvL8//CwuZQfFK+91Q nbueRJ3Eydbg7+r4i3GXPLjVtZCc7gtcg4Q+OcrOCZq7W1qzqCGl7Rft1nif2cu2k01b WJDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QqNDPA96; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n197si2372767qke.95.2020.02.18.11.41.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Feb 2020 11:41:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QqNDPA96; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48ke-00074T-He for patch@linaro.org; Tue, 18 Feb 2020 14:41:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54830) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48iV-0003YQ-DG for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j48iU-0004Cx-AV for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:35 -0500 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:43602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j48iU-0004BO-4v for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:34 -0500 Received: by mail-pf1-x429.google.com with SMTP id s1so11149970pfh.10 for ; Tue, 18 Feb 2020 11:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oxNPd/QkKRHeWi1ZwK35YEXvYDOJm8fo+psN51CFfCE=; b=QqNDPA96P6n8HKuahSWYbC6VO/tDywq9jGpeOVoQIlhZnod8THLzSpU9IJQkmMT9x1 I5/P7WfapfgYf1hLF5GFkAtfK5lBxnU5C+zgOEClroyU/hzD5dKusLAplgJHAP2rhKPN LURe35h5QbwEdLLfrMH8Nn4S7dpLKYZTUTvq0EiivEaZz74NPaFwtG7c7XM7ntcLN1Jo +rF1/9OjvZyvZLk07k+Uov/vEyCF6mqsH4v7YF92g12uRKEAglMco9z3ywatVliCsq/K MOjc59ccpXPdwaR5nuYfr1wZMl1DMDrxj09kGKZiiJ2mTB7ENa3mNxAdTRoL18YjblzB iZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oxNPd/QkKRHeWi1ZwK35YEXvYDOJm8fo+psN51CFfCE=; b=CC6EyFdDQ3MQktAqtrft471LZC3zeMegZ0BNtwfxRmrfGeKIFuk3i4KU+w55ExWL86 9KyOVJqVvyDaX/UZZv0xv1lyUAaAHUnfhXnyF2PoCI4K9NxXNFHLAWeE+3JxVCh6zIJN pwpivyQ7dcPYycc3jYQFg0tmEaSW1U2N9tUgz1dFcrSNAeHaq6j9A4iqWvIpby10hd2U VqLpZU1D91W6vpdvSXrRbkVGPWWa/hppfyUBM6ngzfVZ3/VaGW+2Aah9qHgM1KPZxaUK b5A94NG/mqCP75MttoZqLPBPMOKNYktAGhdApv94oMz5zueeBRNWOwPaZ0Iy3WwDgcAQ xTSQ== X-Gm-Message-State: APjAAAXNXFwsBXv9rgYZ/07ICnl0IN6SfM7gyIB/I11MPY1JXzA3Z2zS rBy+tRsFax4KzToIzpOK9c50NYJtcnM= X-Received: by 2002:aa7:9ec9:: with SMTP id r9mr23001986pfq.85.1582054772794; Tue, 18 Feb 2020 11:39:32 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id y15sm424395pgj.78.2020.02.18.11.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 11:39:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 1/9] hw/display/artist: Move trace event to draw_line() Date: Tue, 18 Feb 2020 11:39:21 -0800 Message-Id: <20200218193929.11404-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200218193929.11404-1-richard.henderson@linaro.org> References: <20200218193929.11404-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::429 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Instead of emitting the trace event before each call to draw_line(), call it once at draw_line() entrance. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Sven Schnelle Message-Id: <20200214001303.12873-2-f4bug@amsat.org> Signed-off-by: Richard Henderson --- hw/display/artist.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.20.1 diff --git a/hw/display/artist.c b/hw/display/artist.c index 65be9e3554..abacb0e27d 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -563,6 +563,7 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2, bool c1; uint8_t *p; + trace_artist_draw_line(x1, y1, x2, y2); if (update_start) { s->vram_start = (x2 << 16) | y2; @@ -654,7 +655,6 @@ static void draw_line_pattern_start(ARTISTState *s) int endy = artist_get_y(s->blockmove_size); int pstart = s->line_pattern_start >> 16; - trace_artist_draw_line(startx, starty, endx, endy); draw_line(s, startx, starty, endx, endy, false, -1, pstart); s->line_pattern_skip = pstart; } @@ -668,7 +668,6 @@ static void draw_line_pattern_next(ARTISTState *s) int endy = artist_get_y(s->blockmove_size); int line_xy = s->line_xy >> 16; - trace_artist_draw_line(startx, starty, endx, endy); draw_line(s, startx, starty, endx, endy, false, s->line_pattern_skip, s->line_pattern_skip + line_xy); s->line_pattern_skip += line_xy; @@ -683,7 +682,6 @@ static void draw_line_size(ARTISTState *s, bool update_start) int endx = artist_get_x(s->line_size); int endy = artist_get_y(s->line_size); - trace_artist_draw_line(startx, starty, endx, endy); draw_line(s, startx, starty, endx, endy, update_start, -1, -1); } @@ -743,7 +741,6 @@ static void draw_line_xy(ARTISTState *s, bool update_start) return; } - trace_artist_draw_line(startx, starty, endx, endy); draw_line(s, startx, starty, endx, endy, false, -1, -1); } @@ -755,7 +752,6 @@ static void draw_line_end(ARTISTState *s, bool update_start) int endx = artist_get_x(s->line_end); int endy = artist_get_y(s->line_end); - trace_artist_draw_line(startx, starty, endx, endy); draw_line(s, startx, starty, endx, endy, update_start, -1, -1); }