From patchwork Wed Feb 12 13:03:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 183312 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp6545890ile; Wed, 12 Feb 2020 05:06:45 -0800 (PST) X-Google-Smtp-Source: APXvYqzB4F9if7yOx3lx1UjhZx48/RWBybd2xFmVOfS7a8T5Twz1LUUX8ARqOzvCYlvaSeVRd47Z X-Received: by 2002:a0c:ee91:: with SMTP id u17mr18563685qvr.22.1581512805502; Wed, 12 Feb 2020 05:06:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581512805; cv=none; d=google.com; s=arc-20160816; b=m5Bh0BJvWI5Rix7t7nm52YvRYy9QSwAHvK+Gay2bMQCjmondl/8HIXmPkQ04A/L8Nf APss+VVko+S/V7kvzqPO1LrA28OVwNZ6N/ZM04Onc+jIwQwF8vbtDu5/PVD7ySh4XyFb qa/T4kJjZ9wVg8ODih71KhQ1uDjZd8/pmCre9FllcMWU1iXt6O5aqDWp81eWUf7/YQF4 6jfsYmYGKEJqjq807tYqqhtj8UmiKfNty+xLXZ/9sRD9mGiWw9Ly3SiBEHW3vSgH63/P s1i1MXSXqJnPn9wqFoAhdb7tCCLi0HPtR8IgY3t2Oh1CzlNb1clDvGB+OeCQD+OFGZZd j8GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=vWNTTcvLVsrozAeWiaV+9h0+oOQUitRlJyBUz9hb64luDxdH16d9ztzFvDh2Q6uGc5 tMkCed44c9Aiit8EszKXNnYPyNDquBfjkB6hMTEvz39nhIqIa3a7M2cyZYj0wlW7WtZ8 RBkSGGHFz2+HbcKI1GDcrSzNm9nCgK7uiDkTNE9ps+xKiSiWUjHQRZmvjjBu/aWrQHGd LteaERE1QyVXYAgUeTlDGKEyECAK3wliTnO/qfBlnbhIqpE4roCjZvfJ5nCmW98nO+tn S7VDt082Gjxrlg+iEXf7df9P1BmvegADRCJ1q24fKHpSLXVdDOiOgPdpPL8bdrspoB9i GNZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x26si88396qtq.63.2020.02.12.05.06.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Feb 2020 05:06:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:37398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1rj2-0008T7-Pf for patch@linaro.org; Wed, 12 Feb 2020 08:06:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33457) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1rgL-0004gC-Fz for qemu-devel@nongnu.org; Wed, 12 Feb 2020 08:03:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1rg1-0008Gy-T6 for qemu-devel@nongnu.org; Wed, 12 Feb 2020 08:03:57 -0500 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:40891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j1rg1-000892-KB for qemu-devel@nongnu.org; Wed, 12 Feb 2020 08:03:37 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 63657DCA88; Wed, 12 Feb 2020 22:03:22 +0900 (JST) Received: from yo-satoh-debian.localdomain (ae231051.dynamic.ppp.asahi-net.or.jp [14.3.231.51]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 36911240090; Wed, 12 Feb 2020 22:03:22 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v30 13/22] target/rx: Dump bytes for each insn during disassembly Date: Wed, 12 Feb 2020 22:03:02 +0900 Message-Id: <20200212130311.127515-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200212130311.127515-1-ysato@users.sourceforge.jp> References: <20200212130311.127515-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1