From patchwork Sat Dec 21 14:42:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 182353 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp1884628ilf; Sat, 21 Dec 2019 06:43:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwXO1RBUDY5FW96SnHZEESuZpdAOHjI39IZSSi0Ur9pzZMQdafZyL+CWQgPFSSFa8qAd6ix X-Received: by 2002:a0c:b38b:: with SMTP id t11mr16393318qve.192.1576939404376; Sat, 21 Dec 2019 06:43:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576939404; cv=none; d=google.com; s=arc-20160816; b=tZCEXvdRu1t9opm+OPeh0z2YlqIsBg0hrPaIjax5cEgFy2TPLvb3Qh8abeMFtg52Bz /OUAz5RN0+wJ7exY3lk3AnhN4l+cIlyxy++0On6HRZzoIent9jprwgtyctcQ8jaSlNy9 dzP+YACbjlr7XbHiHno13qNDgBFpjhyq1cUsVXCE30JIqfBYhl3Tr325dik3my0Q+zkP uPPkax4QhCGdPo9tNQi39vv+KdLGHzp9rZFTkhexhFFbezwTx8dxoiJBHwsO+w0TAO2H wSImswsAImFbensdyxPg2lwJI9vKEPu96u712tyWlfve8qlNab5Uj4FhL0q1dqpAq8GD xZRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=HMqm50KtFTY0yWcR+YrQkhu5kUGZp6mmVBJG4Y+UHDyjG1UmgPnSWRB9d3COwpObBz GVocHNnZWrf06jxdGWeVZwxyK+hHQrq/EDhva0RDraD1Xkeuk+ag4AGzHcBZ6jfQdGso 7rw9KZYY0f0DYLGN9MB9NN6IoUNWuWjBbIpD0b/ng1pWGjoBMno10fCw0av14EriaH7E LYXW6ZEf0IpdBfjXcfb9SBFXdjlOKbuGr8Rj5KFaR61YXgNVhnw08fh9k1kcR4F2fmjm +W7bp002R3+Vago9VPEJpJ9GGGSwpo4e0fNZn/L9YLevMnU6r2j9Kbl7MmOyYwDVxErb JfgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d9si6916191qki.250.2019.12.21.06.43.24 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Dec 2019 06:43:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:39682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iifyV-0005O6-Ns for patch@linaro.org; Sat, 21 Dec 2019 09:43:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46480) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iify2-0005FU-B7 for qemu-devel@nongnu.org; Sat, 21 Dec 2019 09:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iify0-0002DQ-5b for qemu-devel@nongnu.org; Sat, 21 Dec 2019 09:42:53 -0500 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:35479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iifxz-0002Ae-Ka for qemu-devel@nongnu.org; Sat, 21 Dec 2019 09:42:51 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id 4CC201BD09; Sat, 21 Dec 2019 23:42:50 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 0903B24008E; Sat, 21 Dec 2019 23:42:50 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v27 13/21] target/rx: Dump bytes for each insn during disassembly Date: Sat, 21 Dec 2019 23:42:30 +0900 Message-Id: <20191221144238.127766-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191221144238.127766-1-ysato@users.sourceforge.jp> References: <20191221144238.127766-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.13 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1