From patchwork Wed Nov 20 10:57:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 179830 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1932145ilf; Wed, 20 Nov 2019 03:02:05 -0800 (PST) X-Google-Smtp-Source: APXvYqycQU4ZTSCZBTNaa5LkF53SfDE/NnrsW3grYst/JQyPPnDS1JNYa/CRI4LsUcqZTBRP4gcx X-Received: by 2002:a05:6000:12c4:: with SMTP id l4mr2399025wrx.110.1574247725153; Wed, 20 Nov 2019 03:02:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574247725; cv=none; d=google.com; s=arc-20160816; b=FFKLkXNIa2H4744VCncTHtrf4bwmvR7gnOKEaMoNe6InqF1Yw2WETPvgP92Xtqf73n YMB2Ox9s2CRS+Mr1Xylr9bk6KB1VEklzAxWcdJh/ZxCkQ9BGZI9uGVwB5OUmJr2jtYuH xSFdchmKye2y8Ss9+trahHySuWYcgYGHS1eAu2Ig3+jSrKkoeREjr/9HM1PSydIBug+q EybtphJErMigFzofnBxV0oIBZFUsCrjU0T+vYfIx+2qSIVzHCEWHi2NYSrVq6Zg+ABlU G8gJ8RhVMJw8DPJ+3KTGSPd831y7RsKZ1OA9LLHrwZ07FsJ0VS2XTzW+SVOrA+wm/f8Z UIbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=8t5kqmOG1TchdK98D192qu2xreWTn22UibKxxRh5FTw=; b=IQzUJNiIapXcIfVp66WUZIQNMFpEeXRyCuI4jUPk7OhhLZYSg+92ZqrWpCDMsNx0F0 zzSKVntTZRN2ILBAoq1LUfzr/5V1WMpiyTfDj6d89B6flVTUMwLRGKythK1hFAKuvpoa TrCWZAWdYdD8inzB7qvLlu6FU8g46eq8Nmdp/v4maildFFGRXd36tdiz9JESLctjPWnK /HJc+0g/F+TM8c9xF4RtOOoivVKXu+ppZ1om7DxSpL+vezHlIM8OS2kYIUT8OTizCY5E j3dUDbHPpLlt+1e6kzvGP/uc5ZMt7Nfe4SczmVXRiccJq8o1WiIOS5ZIfq5bjxb89NG8 Wvwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YPuLurvi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i6si18521179eda.30.2019.11.20.03.02.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 03:02:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YPuLurvi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXNkK-0002Q2-3E for patch@linaro.org; Wed, 20 Nov 2019 06:02:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34115) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXNgW-0006yk-ER for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:58:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXNgV-0006sa-7Q for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:58:08 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXNgU-0006qh-Us for qemu-devel@nongnu.org; Wed, 20 Nov 2019 05:58:07 -0500 Received: by mail-wr1-x436.google.com with SMTP id i12so27602225wro.5 for ; Wed, 20 Nov 2019 02:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8t5kqmOG1TchdK98D192qu2xreWTn22UibKxxRh5FTw=; b=YPuLurvi0pYCdiGZsXvJHM0FRTDktG+pTHbzeQinSm+2cZm22+hS70vW5M5VeFliAi uwoaifoRo1XMjYz9C59Q+osvTq6jrf8Ans87c0+pk4Wx8Z7GmrR+B2uLPl7Mscdoyakl WMp7dDh6CadEPX9w7icT9gBUTtdX2S+SW13o+NUa5QzWbAhGJVM7TISAxAsjlBX8sEWk 5o2djDLn/EiuFoK3lldy6NOYbBKRRBCjOf94mJbgN4IvLMaumNsHkuhtqCa4n1HDREbY yfd1zdaqyavOZJb3d5T2ZQq5AAIqAu/5Jy91DOG5RX2/L9L9HVq270pYZf1BeMRD+iNd rbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8t5kqmOG1TchdK98D192qu2xreWTn22UibKxxRh5FTw=; b=UF/zoUzRgRqL0R2eey80KOciIaEm9KIn/Vh5YoVzXQV/5PdSYxXsgmo0+i0UfBYSoy 4mFjU8CD1TkK08XnCFCv0WQ28l2CMPlZ4nAVZwP/JFZ+reWqtkrKPmGCm5HA0N9ohTSY fRoghZ6UfvkJV/vIGVJTlxOhX3wh3mDeHp7du0P0PLE8mKUiiAB0rkT2ZHKSafbfZtUn v4WOJpNLythSE8rsxyJ7tTOKGZNFyhU7OofQQt4iWBTUgVbRQ0ppVXBpRi9tGPO4oPt/ tMll/IplVA9duw1baSh3vyXUwGzbYNWD99HCBzOkRXszwowgZylmHaWHH4rhezbxZhN0 Okbg== X-Gm-Message-State: APjAAAUic60fos0735b18C32OVVl85v2PluKgHAHcyni1VIwMi5XxRUE /Ahqxa702+44jKK7tXdhf7rLIFFlulQ= X-Received: by 2002:adf:f4c9:: with SMTP id h9mr2408400wrp.354.1574247485817; Wed, 20 Nov 2019 02:58:05 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h124sm6644615wmf.30.2019.11.20.02.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 02:58:02 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 58E4C1FF8C; Wed, 20 Nov 2019 10:58:01 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional Date: Wed, 20 Nov 2019 10:57:57 +0000 Message-Id: <20191120105801.2735-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191120105801.2735-1-alex.bennee@linaro.org> References: <20191120105801.2735-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While the concept of only dropping to ssh if a test fails is nice it is more useful for this to be unconditional. You usually just want to get the build up and running and then noodle around debugging or attempting to replicate. Cc: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth -- 2.20.1 diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 91a9226026d..0b8c1b26576 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -403,7 +403,7 @@ def main(vmcls): exitcode = 0 if vm.ssh(*cmd) != 0: exitcode = 3 - if exitcode != 0 and args.interactive: + if args.interactive: vm.ssh() if not args.snapshot: