diff mbox series

[PULL,1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional

Message ID 20191120105801.2735-2-alex.bennee@linaro.org
State Accepted
Commit bcc388df07b8ac69660c2ad0200d4f242513e642
Headers show
Series a few doc and testing tweaks | expand

Commit Message

Alex Bennée Nov. 20, 2019, 10:57 a.m. UTC 
While the concept of only dropping to ssh if a test fails is nice it
is more useful for this to be unconditional. You usually just want to
get the build up and running and then noodle around debugging or
attempting to replicate.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Thomas Huth <thuth@redhat.com>


-- 
2.20.1
diff mbox series

Patch

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 91a9226026d..0b8c1b26576 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -403,7 +403,7 @@  def main(vmcls):
     exitcode = 0
     if vm.ssh(*cmd) != 0:
         exitcode = 3
-    if exitcode != 0 and args.interactive:
+    if args.interactive:
         vm.ssh()
 
     if not args.snapshot: