From patchwork Tue Nov 19 14:12:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Patchwork-Id: 179763 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp709811ilf; Tue, 19 Nov 2019 06:26:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxUCialSieBHGIrdn2ICBF5456+WoOPxjYrx/yoYzqquwpf+tbaQsZdqcIjLibTiZFwd1cy X-Received: by 2002:adf:e78c:: with SMTP id n12mr34802316wrm.94.1574173618491; Tue, 19 Nov 2019 06:26:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574173618; cv=none; d=google.com; s=arc-20160816; b=ml2y9DtIp7XLRqGu8AlNv2XRf5hE/SyV9qWcwXBXmDO7Kvj5wpBpoqv+zSG/hpGoMn T59Qw994DH1Uljd3BrDdIStSKWQiP6JqrOjHPV3RD4oLNoy7NGOdKjw+JrqrXi2/YCJF xku4GlcNPAFTy62hMhH0nnp8oqq1D38Z37ZAI74pT/lgrBlwr/qA5BP89o8F1mJOmOCt X3qkFF996Zt6BRZPVq1TzvLyamD02mtIY8/M+HPVy9LMCwPuiyjq2MaJ8wXj+hCfhwke so5tT6BOyArd1ycYQ5NWDb8cNJBtmbYz7veXgxJDXpKWx3Vg0J4AAVex0yNQBwzR4NEF gZCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=PtqjRBaGybWs39PwwvBLI4BES0N7Q9slA6bV9+LiiCM=; b=E1SvAJfjOoEH6RhNj6SPWl7KERhhMmh8OSTHhSFvcyh+UQZTThtuyhfO3HVj9RSEGJ DksHN8XoPU48PyPsmvvvvFpEqVzfnzgKo4yY0UKa675mtgS63tK18LJQVb5YKy8Ul4Az SAglgQeoyXMQG2emgdI9wKU2QG86yCGoIPol1fjztKnlVxIG9ZeQ4HcySBQ802/VI2pu D4Mn2s9eItA1HB65uDjVbxsjUUJ9h75Dcn+pdZHpnY4ZGyVt+6Id5oYCjGg79JshzIcf 1zVK4yBvL2v1YmKkLs+gWYpYUPG7c6OrRZMXrm6EvH8HZxH/C8jYES32QOHnM0kB8uBW JGEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u93si18008356edc.184.2019.11.19.06.26.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Nov 2019 06:26:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:46078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX4T3-0005T8-7i for patch@linaro.org; Tue, 19 Nov 2019 09:26:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42045) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX4G3-0006XW-Qz for qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iX4G2-0005Tr-OS for qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:31 -0500 Received: from 3.mo68.mail-out.ovh.net ([46.105.58.60]:41182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iX4G2-0005T6-IA for qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:30 -0500 Received: from player795.ha.ovh.net (unknown [10.108.57.43]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id 3008914CEDE for ; Tue, 19 Nov 2019 15:13:29 +0100 (CET) Received: from kaod.org (deibp9eh1--blueice1n4.emea.ibm.com [195.212.29.166]) (Authenticated sender: clg@kaod.org) by player795.ha.ovh.net (Postfix) with ESMTPSA id 8EA5CC18AB7F; Tue, 19 Nov 2019 14:13:20 +0000 (UTC) From: =?utf-8?q?C=C3=A9dric_Le_Goater?= To: Peter Maydell Subject: [PATCH 08/17] watchdog/aspeed: Improve watchdog timeout message Date: Tue, 19 Nov 2019 15:12:02 +0100 Message-Id: <20191119141211.25716-9-clg@kaod.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191119141211.25716-1-clg@kaod.org> References: <20191119141211.25716-1-clg@kaod.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 17908845394972281617 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudegkedgiedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepveorughrihgtucfnvgcuifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucfkpheptddrtddrtddrtddpudelhedrvdduvddrvdelrdduieeinecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejleehrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpeeh X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.58.60 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , =?utf-8?q?Alex_Benn=C3=A9e?= , Joel Stanley Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Joel Stanley Users benefit from knowing which watchdog timer has expired. The address of the watchdog's registers unambiguously indicates which has expired, so log that. Reviewed-by: Cédric Le Goater Reviewed-by: Alex Bennée Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/watchdog/wdt_aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.21.0 diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c index 145be6f99ce2..d283d07d6546 100644 --- a/hw/watchdog/wdt_aspeed.c +++ b/hw/watchdog/wdt_aspeed.c @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev) return; } - qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n"); + qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %" HWADDR_PRIx " expired.\n", + s->iomem.addr); watchdog_perform_action(); timer_del(s->timer); }