From patchwork Mon Nov 18 21:15:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Foley X-Patchwork-Id: 179608 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp3424296ilf; Mon, 18 Nov 2019 13:16:13 -0800 (PST) X-Google-Smtp-Source: APXvYqxkTLwicrRKOTslmSZ4EoW0mD5cBiWUunT7Lis7I+xVYRJj4xC5gcxD2Y+sOo2OAvdnA5wG X-Received: by 2002:a05:6214:2c6:: with SMTP id g6mr28636659qvu.176.1574111773778; Mon, 18 Nov 2019 13:16:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574111773; cv=none; d=google.com; s=arc-20160816; b=eTUHQFOz/qgcdR3eEoXReGk3XpXmIZ8+IA4LRxtGp6TOvVoERWy50p3Or6FBosW6r6 nKg0F73gQJYPoZGGFDF1Fp3MwAXIjXha7hl1N1S4PK5gqJ/nG656MVPMSTBowneb0oai LwRO2p/vuVD8leDbKhRHAvgG4LjjDNvr/a6A1dHOJPx8IuyOc8SA6jTSTDZ+Vw8OoOY1 H3fHiEkNngfURdU9PNMuqLvEouW85OPti8gvfFOm77AeEpdMTVElT1OG21/LoFCL+lyf I0V1Q7JIQYPIyRrBOS/29LsXGeBiJKPXPf62rIJE8yCUfNxxOidgDybdTy1ol3rTtN2L 5QPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=diXnF1IPkkxinXlGIqTBKK6HjgFjUcsfRfseHjAG8V0=; b=b9zkMutWZIzI5WLjnWM+CxLx6LTZ7rE7q5/HuUKNmGBsh1qdQ5mWmjC4pjnavQZX9a 9EBr4+mU3OphyET2SkDwRZncOsD2ZaxHlY0mIy/6GcKhoJvTxkeYYUf/A4FALoZn+Xo3 emFd/p83v+xCV7et8rBs+KgAkiBax5XhHXMY5o4zPa1s5TZ1rZC+x2CtKf3zGftbvqT3 O48az00kmctslaJcv8s3usa/Me+JPAwtgBb7YjrVfwmWdyn1wono1QU2QUNgcI+XbkxZ bQ+vFg4UHQPzpsmQxw71TxyAlki+HixH9pFSzMRVxeajwOirNnzD3B65i2J58KeAXYjx kPeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=h+2Qho2v; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q26si11680668qtn.249.2019.11.18.13.16.13 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Nov 2019 13:16:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=h+2Qho2v; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWoNY-00006Z-NT for patch@linaro.org; Mon, 18 Nov 2019 16:16:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35764) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWoN8-0008R6-Rn for qemu-devel@nongnu.org; Mon, 18 Nov 2019 16:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWoN5-0005iU-1c for qemu-devel@nongnu.org; Mon, 18 Nov 2019 16:15:46 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:33983) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWoN4-0005hz-Sj for qemu-devel@nongnu.org; Mon, 18 Nov 2019 16:15:42 -0500 Received: by mail-pg1-x544.google.com with SMTP id z188so10239807pgb.1 for ; Mon, 18 Nov 2019 13:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=diXnF1IPkkxinXlGIqTBKK6HjgFjUcsfRfseHjAG8V0=; b=h+2Qho2vTpunhRLfbyinfHSPOa+YoaWCod/ZWn6WgkDrMlTjLAmIGN/bNzgia5xPpk YRk7BKwtye0qLaJijKZ+PfGxmnzlLWXYqbsv0Bk3hwxphR7kSPhEUt3+nyK3w3Z/p1fL 1WtJMn6s0cGQ+pfsZW5C0KmmJ+QNXfbbQq/JRVQGl8Ao5WBxAlibD1bk+vnlpfMDAqn+ wlgj9DEZe0ZqnxsboGd8Qh/X+qVvbXWyAs765Mem3hW5tAGlbWn2YaX/kuDhEdjeAJGa jXnnDaES1oFauz2IQ50oizgSXt+2az0+WcGe5Y4GDpUFm2nW35DUOhbo+ob1ucfi1Sp7 nHRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=diXnF1IPkkxinXlGIqTBKK6HjgFjUcsfRfseHjAG8V0=; b=Kt4hV26hjg51C4Pes0FkFZ30FKMR5GgshlenpSDinP9elN29Wq+h1jMvEU1XhuoMyY xrPsiVJ0MKejaF9TOPognr9IB8/86/p/F2k3Gb+4PVYb1+JmB0APVuB4+C2QIlSqCDUn Fw/e4tqbchS5Ke5ZZ93anbFFMn/JNfXj/vDIoaj34EHj5szbZGfoig6qU3FrtchN/pEU EUnz+LPezvSirQVkeIqYCkPQz4KXcgMmjZoC6AJoaA0MUqF6+harEIENvyJ5oruiOlfP chiju0tN+XedjgFZcQoUVeyc8NIUDphZPHVuAQV5XCsDmPme4oLcVJoeZACmgXEn/FQs pFeA== X-Gm-Message-State: APjAAAWmCFfZ3gA8TtTiJ622D9f4Tf9qZoJVwYFjt4cXsXZDCfrkXTOu Xuivo/zW79dst4aVyx4FE9aVglbKrko= X-Received: by 2002:a62:e914:: with SMTP id j20mr1510186pfh.245.1574111741581; Mon, 18 Nov 2019 13:15:41 -0800 (PST) Received: from Rfoley-MA01.usrd.futurewei.com ([12.111.81.71]) by smtp.gmail.com with ESMTPSA id v15sm22301728pfe.44.2019.11.18.13.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 13:15:41 -0800 (PST) From: Robert Foley To: qemu-devel@nongnu.org Subject: [PATCH v3 1/6] Fix double free issue in qemu_set_log_filename(). Date: Mon, 18 Nov 2019 16:15:23 -0500 Message-Id: <20191118211528.3221-2-robert.foley@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191118211528.3221-1-robert.foley@linaro.org> References: <20191118211528.3221-1-robert.foley@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.henderson@linaro.org, alex.bennee@linaro.org, robert.foley@linaro.org, peter.puhov@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" After freeing the logfilename, we set logfilename to NULL, in case of an error which returns without setting logfilename. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- v2 - moved this change to the beginning of the patch series. --- v1 - This is new in the patch v1. --- util/log.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/util/log.c b/util/log.c index 1ca13059ee..4316fe74ee 100644 --- a/util/log.c +++ b/util/log.c @@ -113,6 +113,7 @@ void qemu_set_log_filename(const char *filename, Error **errp) { char *pidstr; g_free(logfilename); + logfilename = NULL; pidstr = strstr(filename, "%"); if (pidstr) {