From patchwork Fri Nov 15 17:29:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 179512 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp12754062ilf; Fri, 15 Nov 2019 09:31:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzM8ByG5i/3uQItJxjvn9ksRCT5zyQT/FAX8ggXCzy/SwAHpQQuuNIzbVupcagx2hloGs+e X-Received: by 2002:a05:6000:104:: with SMTP id o4mr15804098wrx.309.1573839081605; Fri, 15 Nov 2019 09:31:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573839081; cv=none; d=google.com; s=arc-20160816; b=o4p6pr9mNlh+cNdttzKtzS6xIKAH9T7n9zVGjjtcnr6RLsiKbt2ao2fidQFggNx9Yp +XIUJYNG0jR3kaOe79oYTvITO2BZpP65mCTC+rujniCMWj7EzKi4FFEZ048cxVQj5VTE YdbNrx91qkN77baM2Cv9+nb/ZTtDUiDlOPmftut/vRgT8/VQyOJ5k0dHfwZQ72KHzD4u 5koPaF3MltMjpL5+m8JI7IzC2LYhPMoa67oxgpSSzj7DrRFU1iPlb5bAbTPteGbn48PE ieqNnbDij+2CRYGob/0cx/S4yAShWCCIseg1nrPirJFQUP5sVxuTIcw8fbLFbHyQTRX7 8ixQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=FvqkNjD95DMP7rRbR4+6wxS5O0FAiAqBbCxy5IHZW2U=; b=zGuw9FGOjzO0UNmpQDNrY45e0n8qopDWFOlarq/qP05cyU2vxFItyqHvkjRTYwZNBB SCWgxVuP8IZrjww9FEm9QP4kUXvypDJDfGOHV86uCZHrILK/1XGyAIc+UfeBL+oXgjDM iclV8h8uhdt5KzpgD/rAn8rfJJxDe2X6sTb6gKZb7Zvsto4teYUyar5fZTkHL7407E5V NBMavcbIb1XXYziOGG9AHWo6xH0cAzBA9uWk2nEq9PEn8IrsRqis00yHnLNDZhElljbb ndFyp7l39fSgjZgplEDxK1Y1u5ZVZVbL7cgCAat6v5BkKjq4HgAqxLNvDunl5v+VnJYi sJqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UBvrS5tr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t18si6299387eds.247.2019.11.15.09.31.21 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Nov 2019 09:31:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UBvrS5tr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfRH-0007L1-6C for patch@linaro.org; Fri, 15 Nov 2019 12:31:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34815) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfQD-0007Hy-KO for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVfQC-0002v0-Cw for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:13 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:38250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVfQC-0002u0-4j for qemu-devel@nongnu.org; Fri, 15 Nov 2019 12:30:12 -0500 Received: by mail-wm1-x341.google.com with SMTP id z19so11300838wmk.3 for ; Fri, 15 Nov 2019 09:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FvqkNjD95DMP7rRbR4+6wxS5O0FAiAqBbCxy5IHZW2U=; b=UBvrS5trbwfttiOHG7vjnXoSs2bp/NypEi8eDE5ZtlnEBlX1kce5ScEyciNbaJZTcS 5aMHUjPHPRG4Dw6d6TwNIVhVAoUEt5tFzR0kzc8y+wHv24GEfteVEtC+ZVIjbKBkHhaH S9WJR1s6nQl+l9ubUKLitI1ETv9BiO9KWkCsIMrZsDqYhWAq0pubj5wAelMycsMUyUlI JiX4ejyt6WHd0Db62wkfDWqa0XIxc+3vQd4AOLd/L/ONhhsOsQLJfliYF1Ko7qW0MNg/ SUZ7UpXWpxyMygEEpQP2763OFMDRD3QHSJtEaAdAGo3Wkixll4IstriHFIbPTnlHSkPR DCNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FvqkNjD95DMP7rRbR4+6wxS5O0FAiAqBbCxy5IHZW2U=; b=DGO93A9xGw8Z+2c+uTWmEBN0YqkAQ2TO0YbWIKK0Tq1VNunHBL5oRd2U3/p0fH7mYX tIRma+F1uVdMEaXWYj/dXRy1BZe5I+y4F/iJyMFOGab3pWaGPyfnGg9JDY44n3XUzP48 P7ObOpXx8fHvcotKVRr2nn6tQl3drxc4ZeyAaeOsU4LH5pwBm8IbtdPntLhqO0yFknXo lyMtv4ere5BonHC1sTqaLt5n3DKp2ZDDYrJVsvedsVT6jSXU1HTqGzgN/Qv+xmZUjblw hiDAH8T6tfNJZ+S63tedWK1j9TWscLFf6saj2pt03FwhxrM6eOhuhG5WN24EJorSPrrU aA7A== X-Gm-Message-State: APjAAAXTieNauXbdIcFXrKkttrYTu6fRN/ld865KcNvMuKcUuGF6YTRJ 2IlnPu5FEThurk4QhE5HQOPDZA== X-Received: by 2002:a1c:3b08:: with SMTP id i8mr15322001wma.56.1573839010924; Fri, 15 Nov 2019 09:30:10 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d18sm12464309wrm.85.2019.11.15.09.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 09:30:06 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 53E681FF93; Fri, 15 Nov 2019 17:30:01 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 06/11] target/arm: use gdb_get_reg helpers Date: Fri, 15 Nov 2019 17:29:55 +0000 Message-Id: <20191115173000.21891-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191115173000.21891-1-alex.bennee@linaro.org> References: <20191115173000.21891-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: damien.hedde@greensocs.com, Peter Maydell , luis.machado@linaro.org, richard.henderson@linaro.org, "open list:ARM TCG CPUs" , alan.hayward@arm.com, =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Bennée --- target/arm/helper.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) -- 2.20.1 diff --git a/target/arm/helper.c b/target/arm/helper.c index be67e2c66d6..bd821931b3d 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -105,21 +105,17 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env, uint8_t *buf, int reg) { switch (reg) { case 0 ... 31: + { /* 128 bit FP register */ - { - uint64_t *q = aa64_vfp_qreg(env, reg); - stq_le_p(buf, q[0]); - stq_le_p(buf + 8, q[1]); - return 16; - } + uint64_t *q = aa64_vfp_qreg(env, reg); + return gdb_get_reg128(buf, q[0], q[1]); + } case 32: /* FPSR */ - stl_p(buf, vfp_get_fpsr(env)); - return 4; + return gdb_get_reg32(buf, vfp_get_fpsr(env)); case 33: /* FPCR */ - stl_p(buf, vfp_get_fpcr(env)); - return 4; + return gdb_get_reg32(buf,vfp_get_fpcr(env)); default: return 0; }