From patchwork Wed Nov 6 11:33:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 178668 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp479428ilf; Wed, 6 Nov 2019 03:36:29 -0800 (PST) X-Google-Smtp-Source: APXvYqzlVQzCmadRhXyCjvbCgoC8xwoYCdKaZG1mZC3gDfRqVcV3Z81fXASuf0zjxdBiq5iVrtgc X-Received: by 2002:aa7:c6c9:: with SMTP id b9mr2045424eds.1.1573040189583; Wed, 06 Nov 2019 03:36:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573040189; cv=none; d=google.com; s=arc-20160816; b=lxthFkALfVDdFzIzM8ReGJHEK7KHHrLSomD1gqbziPlqFPvkN8GvNVbQaUofMBYgQp Cxz3iMT/+fHw47iYCT7lNuCFGBxgcwnuKHOyxrRzo8eDOHmZf8uXRC/nnwA/BRr/AKTm X6FJLjMA5WQXzw06bBKzCdVcoXxotVpmm2zRhFMzwn8gvQRG1GWAQJp3tHe/Pai8eMEY iYxlzdxgiixb1CxIhYe1xvIvpFuVn8TkFNyw+0iL2obAMWx84ZzTO0J80cmB58LdQcq8 0OGd4OooJ/TK3lAnrabafrcK6N44THkbrObVuteuR7lhEaJGGflXA20zysxUxupjrYQD C7hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=c9UPRPKHJUNhzqq+bqS8IJr3Nntx8YxeU90N3YYxIP4=; b=x5UFec5K5EKusOpBB5zdphIDgfFjOYH5XNOVB9YEcm3i3P5tmEBKzdS88DMr9csbHG yAEu8tesLwAydSRsuKqbK6UJfPfDXx4b0+S5S39N4/GhBY9GhpddB8hgebMoStZ/RltL ekZFwlaWzbC6r8MbRWlDuNq/9gA368BXjcER0ma1mxW3ZRh7x5qnCk7ukr8D5liGPG+S Gx+GLUumw+5MGKUtiakyL2PhqJ4zp7tsUjCL54CZ61q9tgf8hgfNp5mrqfOFn95KQz4+ XUYVU9pgwnjk2JRWFFqycKL8rc7u5YDk6r01TJsI0YIpTdJqwQ+5Z05Z4S653wvRF4Yg 4k8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aOjCzRcb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i13si3341541ejc.76.2019.11.06.03.36.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 03:36:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aOjCzRcb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSJbw-0007ji-1H for patch@linaro.org; Wed, 06 Nov 2019 06:36:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37789) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSJZA-0003m4-7j for qemu-devel@nongnu.org; Wed, 06 Nov 2019 06:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSJZ8-0007F0-GE for qemu-devel@nongnu.org; Wed, 06 Nov 2019 06:33:35 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:40357) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSJZ8-0007DG-A1 for qemu-devel@nongnu.org; Wed, 06 Nov 2019 06:33:34 -0500 Received: by mail-wm1-x341.google.com with SMTP id f3so2896204wmc.5 for ; Wed, 06 Nov 2019 03:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c9UPRPKHJUNhzqq+bqS8IJr3Nntx8YxeU90N3YYxIP4=; b=aOjCzRcbQWDShqOS/dQd5Ioj1a5B13l3MPPMSqKMK0wjR4r9wMcjosBdIL1V2Zc+xO 3d3dT0TylBhZOsoQgFJQVcXPyDYK1uEbH5qH0KuQgDpnBz7yrr/LjuNxRLNVfEvzIY3X N0MChXKCcQjpFH9u/LDFpAhvvYz74mPOQZ1bFbtJc2zjsysCx9fGE2Of2MWIU5uG8tTi B3iQXLgKLCPJykI3DpEYIs6mtNmjOXFtrujF9DQjWJZTwgyZs8PKDyPtjuPOKzGf7kdK t0mlTY7ZvM1EKvElw432Ae6a24xg7sxZPAAzCSKkiZPWcTGIHAsfoP8woyI7wLipP380 qEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c9UPRPKHJUNhzqq+bqS8IJr3Nntx8YxeU90N3YYxIP4=; b=fBiNXdXrsbMZrIia7Gko1ON+KAEqw7vBQxuwkC2BcJ2G/xdFjDu1l1Pzih7aH4vYoL crQkvxYXP/QvuNbsFFIgbpH9OyZLNMr8pNBJjLqQJYnXPVXI3jBFQL7ztc/wmGeE0bY7 px6ghBnjDlMbv35vJ6WI1N3oWNAxlR3phl7vP5WvVOtfOo7cmnDVxgIfGrFefOyxOHNe V7BAz+q6EMh6rONecjFvKclzEe9EyrOBHC/KsZCFIoNhtKtpWDSrN9aIjzEfVhBC3rfN r2AkCDa2/8NKWgD9bOKXOEogPSsa85B8dIyDWtaUtpvSRLwONNfgAAqmH4IyPXArIc3L AJMQ== X-Gm-Message-State: APjAAAUVsI829kqHX3eooZObEZlHzjsk1KXzzCr66s31yJmgTVy/TMR2 UsudiI5p+Pvuq0AzhoGZZ1aYmKsfxTFjNQ== X-Received: by 2002:a05:600c:28c:: with SMTP id 12mr1989359wmk.25.1573040012975; Wed, 06 Nov 2019 03:33:32 -0800 (PST) Received: from localhost.localdomain (31.red-176-87-122.dynamicip.rima-tde.net. [176.87.122.31]) by smtp.gmail.com with ESMTPSA id q124sm1776907wme.13.2019.11.06.03.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 03:33:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat Date: Wed, 6 Nov 2019 12:33:08 +0100 Message-Id: <20191106113318.10226-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191106113318.10226-1-richard.henderson@linaro.org> References: <20191106113318.10226-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The error indicator for this syscall is -1, not 0. Fixes: e374bfa35bfb ("shm tests - disabled clone test") Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191025113921.9412-3-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index fa4243fc04..673d7c8a1c 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr = shmat(shmid, NULL, 0); - if (!ptr) + if (ptr == (void *)-1) { error("shmat"); + } memset(ptr, 0, SHM_SIZE);