From patchwork Tue Nov 5 18:11:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 178539 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1119798ilf; Tue, 5 Nov 2019 10:19:15 -0800 (PST) X-Google-Smtp-Source: APXvYqz8/sbB8QyIc3uQn/HmTGLe/PyejtfvNnFnvVAU/kqZtTsiNLrMdxfZrRm21Xi+lZe899oU X-Received: by 2002:a37:4f83:: with SMTP id d125mr21244885qkb.205.1572977955484; Tue, 05 Nov 2019 10:19:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572977955; cv=none; d=google.com; s=arc-20160816; b=ftuvzx0MjD91oWwrOozn3SmRDW8+UvphHIer4joU9EgjjXA2ChsRHetTtmGk/zBbcF BOA06HnKYscT8lBkTQMh61M+AsAVJwZyyTyMT1ETW0TRyiyjCac0NqGs24oPU4qgS8uY 6xZGOI0w5XcT1jKChA7RSygSa+sSQaEfvQQR/S/U9m0KoiEHdGVBSVQGhfegoeNtMiSi LaQLmiJ2JL7HoG3idZGilHROJYHHyE5k5OmDtFUFdjR3GHzDCTNO++wXD2wjqH5VPShJ npDvEbUm1gyAju9azflNEHn5ga018FGyxYyFrlgJN0HlvFPTOD8dTyrburKVoYeYqOZX IG9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=lPemnGQGksT0K3hjuTUKc7M2IcF8hx0rZE/s64UA7BY=; b=XGDXsczQAWOizM2gvPYFXtJHmjkLsPsdYVb4Tvpoea9a0Eu8ntK6SfOajJf5rSh6db gCs1S4V1YenKbklMS7Gi21OVeDlkipRjo6ZjRxnrJF6fMn36vmYfty7Wv4kJFAEkPylb EPLKj2JwZHxGPwhLvgmEOlE8TYt+A2gAATqhUuySxSXUD9M6bKjgalzscJODOHqnlz1F hvS8m4ChtIVODUTVOGz60vp1DeTo2Xh4CnYeOXrGlWioxBah8KR9p0ZpfY7WHJ15UK4u /4d/s47P+on2w7K6VbnNKj9S+R5SVuPjGHpc/Oh+QZUybW/xCtHQtThFOUA6W0DFWKQf sKcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w9si13326486qka.21.2019.11.05.10.19.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Nov 2019 10:19:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:47204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS3QA-0006C5-SV for patch@linaro.org; Tue, 05 Nov 2019 13:19:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52124) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS3Iv-00063j-Ca for qemu-devel@nongnu.org; Tue, 05 Nov 2019 13:11:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iS3Iu-0004kZ-80 for qemu-devel@nongnu.org; Tue, 05 Nov 2019 13:11:45 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:46583) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iS3It-0004jr-Ui for qemu-devel@nongnu.org; Tue, 05 Nov 2019 13:11:44 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MKbwg-1iDojs3Nng-00KwLt; Tue, 05 Nov 2019 19:11:29 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat Date: Tue, 5 Nov 2019 19:11:09 +0100 Message-Id: <20191105181119.26779-4-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191105181119.26779-1-laurent@vivier.eu> References: <20191105181119.26779-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:guFf6kPoCev83970K61xUpTlYtpwIv48BL2vM28Yn6KhRBNECBn YR70Je6cEpMeOXp025Yoodu8WGSKnNgxNhWcqQ6u4lvUl2wmhQK1ujxhrWi5Gk1NGt/wHSK Su8wAy+e+HdOGB8FG8iEGnTnsmltEIJeWfAGf9LBdfLvoIA5pfDA+7N840HAVoCa6YRrKzO Nt4HZCIh1szLx6iCycfOg== X-UI-Out-Filterresults: notjunk:1; V03:K0:RbszguFOBm4=:4mHeeaEiSRAWMqaQWXEwMk KhHhTMd0v0mQ8cgw9SUQayU6jyt+ViAox4TDsTjZoV+bmztIS9oXYOccO/OPLzGtS635hQBjp NCipTPK7qbkXgSawtyiRSsdgn3Pb/ech+wQG4KkaTiUkBEfMADxads9jRYwULUMoePFO++OL+ HvTedJ3iRCDGYJ28hg1zV4r/IGASWgG1F12RZTOCGRH29qtByNJxO78CpLpI+UDuXq5wXHzbY U5IGRM0dJzeSRaBfPW9u3cZge8pIGYu34enH/iB0dpDsRKFMoPi8XAB0e6RFw/u2kkHl/k6PM ukTNSFmC5IoDiA7MVLxB97USkUPrOOLEJY+bJiLxP8f8WDG+PR3xHQ+POl9v/7ez5vPoi8B1k 0+x3IWPKxddHG1biN1HUdXmpRKC0EYwuEqRcCWibUyZ2fyMslDmsvX/uu/T7CSYojPW3yVWwh bf+nlMpZvRi1RvOeqbwkKfAo3hAfnmMqZ2JKCAFHUP+2rzFMNXGWW3yRPou3W2tap/rIcNaZJ 4E5ljQoy0qptqNubL4hAIsHVZr39zuBNCLXAxM2gUSu7o9aUqqNrcHxUqsHRw8n3WaOxJ0ADC CJ4BSX1+xploak7/JzPAr7jF1GnZ7ZQ10YzKjp7TJt1qlf3B+AzBM0+R0BRSM55e4fJzeltEV RCdKfyyXzYVcMSeLn659Ag5Vsn6ilEHXvCXIIGu6RFjk/VBcsM3H7H3dWrggQzp3YfU7ht6V8 +2i3h3sbm9Lk+/+QSlw3q9xVoP8OTy1h2jsV6w8doT2/b+sNn/ujjWZZJDcAU8Mw7nA4qqJmS EFx1i8X6sYmJHsEZqo0BI0s+hnjA99k4L/FhDx0rk+BfbfmaWbgHMDDdWI3l6/YJTx/RWujm0 XZ/L5qDSmxz20yD0MA03KX7JTQ+FYj+Z3jaznOEfk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , Riku Voipio , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , Artyom Tarasenko Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The error indicator for this syscall is -1, not 0. Fixes: e374bfa35bfb ("shm tests - disabled clone test") Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191025113921.9412-3-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.21.0 diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index fa4243fc0426..673d7c8a1c25 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr = shmat(shmid, NULL, 0); - if (!ptr) + if (ptr == (void *)-1) { error("shmat"); + } memset(ptr, 0, SHM_SIZE);