[PULL,08/12] exec: Promote TARGET_PAGE_MASK to target_long

Message ID	20191025142159.12459-9-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PULL 08/12] exec: Promote TARGET_PAGE_MASK to target_long Date: Fri, 25 Oct 2019 10:21:55 -0400 Message-Id: <20191025142159.12459-9-richard.henderson@linaro.org> In-Reply-To: <20191025142159.12459-1-richard.henderson@linaro.org> References: <20191025142159.12459-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	tcg patch queue \| expand [PULL,00/12] tcg patch queue [PULL,01/12] tci: Add implementation for INDEX_op_ld16u_i64 [PULL,02/12] cputlb: ensure _cmmu helper functions follow the naming standard [PULL,03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN [PULL,04/12] exec: Split out variable page size support to exec-vary.c [PULL,05/12] configure: Detect compiler support for __attribute__((alias)) [PULL,06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY [PULL,07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG [PULL,08/12] exec: Promote TARGET_PAGE_MASK to target_long [PULL,09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY [PULL,10/12] cputlb: Fix tlb_vaddr_to_host [PULL,11/12] translate-all: fix uninitialized tb->orig_tb [PULL,12/12] translate-all: Remove tb_alloc

Message ID

20191025142159.12459-9-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 08/12] exec: Promote TARGET_PAGE_MASK to target_long
Date: Fri, 25 Oct 2019 10:21:55 -0400
Message-Id: <20191025142159.12459-9-richard.henderson@linaro.org>
In-Reply-To: <20191025142159.12459-1-richard.henderson@linaro.org>
References: <20191025142159.12459-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: peter.maydell@linaro.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

tcg patch queue | expand

Commit Message

Richard Henderson Oct. 25, 2019, 2:21 p.m. UTC

There are some uint64_t uses that expect TARGET_PAGE_MASK to
extend for a 32-bit, so this must continue to be a signed type.
Define based on TARGET_PAGE_BITS not TARGET_PAGE_SIZE; this
will make a following patch more clear.

This should not have a functional effect so far.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/exec/cpu-all.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index d3e4660d50..ba6d3306bf 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -229,7 +229,7 @@  extern TargetPageBits target_page;
 #endif
 
 #define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
-#define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
+#define TARGET_PAGE_MASK ((target_long)-1 << TARGET_PAGE_BITS)
 #define TARGET_PAGE_ALIGN(addr) ROUND_UP((addr), TARGET_PAGE_SIZE)
 
 /* Using intptr_t ensures that qemu_*_page_mask is sign-extended even

[PULL,08/12] exec: Promote TARGET_PAGE_MASK to target_long

Commit Message

Patch