[PULL,11/12] translate-all: fix uninitialized tb->orig_tb

Message ID	20191025142159.12459-12-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PULL 11/12] translate-all: fix uninitialized tb->orig_tb Date: Fri, 25 Oct 2019 10:21:58 -0400 Message-Id: <20191025142159.12459-12-richard.henderson@linaro.org> In-Reply-To: <20191025142159.12459-1-richard.henderson@linaro.org> References: <20191025142159.12459-1-richard.henderson@linaro.org> Precedence: list Cc: peter.maydell@linaro.org, Clement Deschamps <clement.deschamps@greensocs.com> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	tcg patch queue \| expand [PULL,00/12] tcg patch queue [PULL,01/12] tci: Add implementation for INDEX_op_ld16u_i64 [PULL,02/12] cputlb: ensure _cmmu helper functions follow the naming standard [PULL,03/12] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN [PULL,04/12] exec: Split out variable page size support to exec-vary.c [PULL,05/12] configure: Detect compiler support for __attribute__((alias)) [PULL,06/12] exec: Use const alias for TARGET_PAGE_BITS_VARY [PULL,07/12] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG [PULL,08/12] exec: Promote TARGET_PAGE_MASK to target_long [PULL,09/12] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY [PULL,10/12] cputlb: Fix tlb_vaddr_to_host [PULL,11/12] translate-all: fix uninitialized tb->orig_tb [PULL,12/12] translate-all: Remove tb_alloc

Message ID

20191025142159.12459-12-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 11/12] translate-all: fix uninitialized tb->orig_tb
Date: Fri, 25 Oct 2019 10:21:58 -0400
Message-Id: <20191025142159.12459-12-richard.henderson@linaro.org>
In-Reply-To: <20191025142159.12459-1-richard.henderson@linaro.org>
References: <20191025142159.12459-1-richard.henderson@linaro.org>
Precedence: list
Cc: peter.maydell@linaro.org,
	Clement Deschamps <clement.deschamps@greensocs.com>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

tcg patch queue | expand

Commit Message

Richard Henderson Oct. 25, 2019, 2:21 p.m. UTC

From: Clement Deschamps <clement.deschamps@greensocs.com>


This fixes a segmentation fault in icount mode when executing
from an IO region.

TB is marked as CF_NOCACHE but tb->orig_tb is not initialized
(equals previous value in code_gen_buffer).

The issue happens in cpu_io_recompile() when it tries to invalidate orig_tb.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Clement Deschamps <clement.deschamps@greensocs.com>

Message-Id: <20191022140016.918371-1-clement.deschamps@greensocs.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 accel/tcg/translate-all.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 66d4bc4341..f9b7ba159d 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1722,6 +1722,7 @@  TranslationBlock *tb_gen_code(CPUState *cpu,
     tb->cs_base = cs_base;
     tb->flags = flags;
     tb->cflags = cflags;
+    tb->orig_tb = NULL;
     tb->trace_vcpu_dstate = *cpu->trace_dstate;
     tcg_ctx->tb_cflags = cflags;
  tb_overflow:

[PULL,11/12] translate-all: fix uninitialized tb->orig_tb

Commit Message

Patch