From patchwork Mon Oct 14 11:57:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 176204 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4411873ill; Mon, 14 Oct 2019 04:59:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9aBMQfuY4v2xx4AD98kaJsSfN7aep+R7miXBDXobsMfdnpfTTvy8rev1A6FxCWbgSXN6K X-Received: by 2002:a05:620a:218f:: with SMTP id g15mr28651981qka.3.1571054372980; Mon, 14 Oct 2019 04:59:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571054372; cv=none; d=google.com; s=arc-20160816; b=PBVj+3o1vKQ/A09s1NiIq6eZ7yx5YbI1vOssw7MhmyUXpevFQkGRq3g7KOGUmvmpUo fJJZSEjZe9LizrB1V4qcYWsIEj5AVNvBykrO01Ir+WCMsNI6iizFI5m1jnzZY+gjKZWh nHCtpNkt4kyTOCB9wpT8Xy0L/cFUEXkZrPWgQrE4MvxE4gCgOU29uuzFhvYyX2Cxn8f1 CTZE/2IohlOKNz9CeGRmhoAV6rQHTCqgCW2tz36lAORCITT5JMY9cYo4P+fGKWwLlYGj Flx4X0k6e8a9nvS692AKcDdG01nyPtfiC0P2vKhgX1Peg0ZMjszml0OCI2WrcbPPQNsu 5/RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=aFSAgYdenf7JuyTdPpDmxPf6V7Sdyp40yAI+kWsMGoVOd/hAqkzwlIN9asS4idqHaX +JgkpcRy6csGFXDq9ZoNCW3I6hsWmW7Ay2hiU3WTfedZFHyGBmQVUHfiNZ9BDgBjOyVA dgFw2MzLtzffsBxJmWh6Fy37HaVwxqcG2fSQmgf8zlkNWTEJnPzvzZ4RImW3eNExswGj Ofti0R557TmW7sKhWpZ9orFIHTsg0uSakT5c8AUW6T/0s1vQUsZszoNOoS14ALep7Mdl Fu3TJbswE0iCMYbTByXdYXF16l4dlr2kijc+Ox2s/7cjIEAIE8xp7wo6GgKdTCiZMu7x TDAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a20si18249567qtb.403.2019.10.14.04.59.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 04:59:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:48312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJz0d-0005Uv-Vr for patch@linaro.org; Mon, 14 Oct 2019 07:59:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53429) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJyzL-0005R2-77 for qemu-devel@nongnu.org; Mon, 14 Oct 2019 07:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJyzJ-0003WW-Fl for qemu-devel@nongnu.org; Mon, 14 Oct 2019 07:58:11 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:35689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJyzJ-0003VR-7f for qemu-devel@nongnu.org; Mon, 14 Oct 2019 07:58:09 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 9EB996E184; Mon, 14 Oct 2019 20:58:08 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 5C81324008E; Mon, 14 Oct 2019 20:58:08 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v26 13/21] target/rx: Dump bytes for each insn during disassembly Date: Mon, 14 Oct 2019 20:57:49 +0900 Message-Id: <20191014115757.51866-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191014115757.51866-1-ysato@users.sourceforge.jp> References: <20191014115757.51866-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1