From patchwork Fri Sep 27 06:22:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 174582 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp3088091ill; Thu, 26 Sep 2019 23:43:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqqGOsYD6BqgSq40uxZOcoOO2rGXBUn4gXwOiopvYXVD3thKDGXTGWjuoivgLxims2rUWE X-Received: by 2002:a0c:eb10:: with SMTP id j16mr1243968qvp.207.1569566607521; Thu, 26 Sep 2019 23:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569566607; cv=none; d=google.com; s=arc-20160816; b=KvJ+nIW4TNKOCcgHygVONLQ4Kd8kUM260vnr14AmkjUq4MvoewNKdrSO+AxLmN3CqK 2pFtMiyQVqvXmAGnk77PFA+wRuD0DyUelWefv7iBKFczXeKd3WFeMTwKfE1OzjatqmRo QSmuulakf/Tq57vvM9YHaM+u+dsjMQEgSERVeo1UZ6LhEoN2stEoFKxKJ8GWR1Oos8RG 9XlwayBQZxRVl5RdfLI8oJgkvzImv0oCwo5ZU5MV+cVJWXbjM3+baV3Full0Yk6F82Tt l1lMVWsnjzIRLRgfMapsatkS8m7ih7s/zOOKG3FQN/FHQZNbM97FMerCdvokP55h6WEr TzeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=hqSW1uZKx26gNVkb114hwEi6fa81lRzrM1hgng00qV0EEf2DTzZPIHWxLDmsFpi1o3 zW2F4X9uGl06vbP9CHKROnCiX3uUJKSim/JSjjvR1jwUnLjOtEty3YT8yyDWD2X9LenE ZR3Rxl1gey8WFwTDDrWD9an1oprOZHuuHLjri7xCaP9zXccvbg4keVPQxAGhruqQph0w TdxbS8jerbJzYSxLTKRfuniUtvARxxOd+kUg3Hx4XWZ7XubX0dM8dgMp7usKr5uJe8rp DJvbFabxrSLWQPw3mv6zE/P49GHUycPAIaZkwsQrcSTiivMmWH7u34qAOmma8I8tcIpV Gwig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c22si298389qko.286.2019.09.26.23.43.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Sep 2019 23:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:47028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDjyQ-0000wb-GL for patch@linaro.org; Fri, 27 Sep 2019 02:43:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDjev-0007Dx-9V for qemu-devel@nongnu.org; Fri, 27 Sep 2019 02:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDjes-000483-0i for qemu-devel@nongnu.org; Fri, 27 Sep 2019 02:23:16 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:59674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iDjer-00046D-Ms for qemu-devel@nongnu.org; Fri, 27 Sep 2019 02:23:13 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 1F26069A96; Fri, 27 Sep 2019 15:23:13 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id CC62D240085; Fri, 27 Sep 2019 15:23:12 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v25 13/22] target/rx: Dump bytes for each insn during disassembly Date: Fri, 27 Sep 2019 15:22:53 +0900 Message-Id: <20190927062302.110144-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190927062302.110144-1-ysato@users.sourceforge.jp> References: <20190927062302.110144-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1